Issue metadata
Sign in to add a comment
|
3.4%-7% regression in speedometer at 396897:396957 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 6 2016
===== BISECT JOB RESULTS ===== Status: completed === Bisection aborted === The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression. Please contact the the team (see below) if you believe this is in error. === Warnings === The following warnings were raised by the bisect job: * Bisect failed to reproduce the regression with enough confidence. ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@396926 592.265 62.9106 18 good chromium@396928 592.958 51.7978 18 bad Bisect job ran on: winx64_zen_perf_bisect Bug ID: 617519 Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests speedometer Test Metric: BackboneJS-TodoMVC/BackboneJS-TodoMVC Relative Change: 6.28% Score: 0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_zen_perf_bisect/builds/182 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9010621298965629168 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5835844452089856 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jun 6 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Expand WTF::StringView's API to be more like StringPiece. Author : esprehn Commit description: StringView no longer owns the string passed into it, and can now wrap a raw ptr to some characters. This allows us to leverage the inline strlen optimization where the compiler will embed the length of literal strings into the binary. It also allows the deletion many overloaded methods that used to take an LChar*, UChar* or String and can now just take a StringView instead. For example the two constructors in TextRun are now a single one that takes a StringView. This needed to be done in this patch to avoid ambiguous constructors. Future patches will replace CSSParserString with StringView, and also vastly simplify the huge number of overloads on various methods. We'll also expand the API surface of StringView to include the many useful operations that StringPiece has. This was originally committed as: https://crrev.com/330deea56e27bc760fa52101040a51428bb7f582 but was reverted due an incorrect assert in the StringView(const UChar*, unsigned length) constructor. The assert was incorrectly calling lengthOfNullTerminatedString on the UChar in the assert, but this constructor is used for byte sequences which are not null terminated. BUG= 615174 Review-Url: https://codereview.chromium.org/2007103003 Cr-Commit-Position: refs/heads/master@{#396942} Commit : 9b0aad1eca55ac75f437789514224e9b922fe514 Date : Tue May 31 21:53:32 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@396926 789.255 11.6184 8 good chromium@396939 792.822 14.7461 18 good chromium@396941 805.667 15.7999 41 good chromium@396942 818.769 15.2458 41 bad <-- chromium@396943 821.242 18.675 41 bad chromium@396946 824.185 17.2545 8 bad chromium@396952 826.848 17.7197 8 bad Bisect job ran on: mac_10_11_perf_bisect Bug ID: 617519 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests speedometer Test Metric: jQuery-TodoMVC/jQuery-TodoMVC Relative Change: 4.10% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/663 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9010608632187196784 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5776814421573632 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by hablich@chromium.org
, Jun 6 2016