New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617516 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

AlsaAPI.move test fails on some boards

Project Member Reported by cychiang@chromium.org, Jun 6 2016

Issue description

move: https://wmatrix.googleplex.com/matrix/unfiltered?tests=audio_AlsaAPI.move&days_back=20&hide_missing=True

It is surprising that this simple API test fails on so many boards.

We need to fix these things:
1. Use Test.FAIL(show red) instead of Test.ERROR (show yellow).

2. Check why test result is not consistent on some boards eg.cyan.

3. Identify the failure on the boards that we want to drive low latency.

I think we should target samus and other cheets board like cyan, minnie, oak first.

Hi Dylan, besides these boards, do you have any good candidate in mind where we want to drive low latency ? I can look at those boards first.

Thanks!



 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/909c210fb662fc1d6c9afa96cf242d151be8482e

commit 909c210fb662fc1d6c9afa96cf242d151be8482e
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Fri Jun 24 09:26:24 2016

[autotest] audio_AlsaAPI: use hw:X,Y to access playback devices

The ALSA API behavior when accessing device using sysdefault is different
from the behavior when accessing device using hw:X,Y directly.
Use hw:X,Y to access and test all playback devices on the board instead
of testing only sysdefault device.

BUG=chromium:617516
TEST=run audio_AlsAPI test on auron_paine.

Change-Id: Ic43edf5b06ae398c0fd34bd83326de5948340262
Reviewed-on: https://chromium-review.googlesource.com/355893
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/909c210fb662fc1d6c9afa96cf242d151be8482e/client/site_tests/audio_AlsaAPI/audio_AlsaAPI.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/a566ab803e4294b8c0cd25329c6ff5518da4f0f7

commit a566ab803e4294b8c0cd25329c6ff5518da4f0f7
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Fri Jun 24 07:22:25 2016

alsa_api_test: Tolerate more sample consumption rate fluctuation

Loose the threshold of checking device consumes rate.

BUG=chromium:617516
TEST=run alsa_api --move test on auron_paine for 10 times.

Change-Id: I8e1d65c41aa2429de469eb17e26f492e7c40cd83
Reviewed-on: https://chromium-review.googlesource.com/355818
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/a566ab803e4294b8c0cd25329c6ff5518da4f0f7/alsa_api_test.c

Status: Started (was: Assigned)
There are still some failures:
1. chell failed on HDMI port 3. hw:0,6.
Skl HDMI Port3: ASoC: no backend DAIs enabled for Skl HDMI Port3
We should skip the device if it is not going to be used.

2. The wake up time is not accurate. Sometimes it sleeps for over 16 ms instead of 6 ms.
The checking criterion should be the consumption rate (buffer level diff) / (time diff).

06/29 19:35:00.112 DEBUG|        base_utils:0278| [stdout] time: 21711.062839397 state: 3, avail frames: 5778, hw_level: 2414
06/29 19:35:00.112 DEBUG|        base_utils:0278| [stdout] time: 21711.068627896 state: 3, avail frames: 6062, hw_level: 2130
06/29 19:35:00.112 DEBUG|        base_utils:0278| [stdout] time: 21711.074551813 state: 3, avail frames: 6346, hw_level: 1846
06/29 19:35:00.113 DEBUG|        base_utils:0278| [stdout] time: 21711.080114812 state: 3, avail frames: 6610, hw_level: 1582
06/29 19:35:00.113 DEBUG|        base_utils:0278| [stdout] time: 21711.085625812 state: 3, avail frames: 6874, hw_level: 1318
06/29 19:35:00.114 DEBUG|        base_utils:0278| [stdout] time: 21711.091478561 state: 3, avail frames: 7158, hw_level: 1034
06/29 19:35:00.114 DEBUG|        base_utils:0278| [stdout] time: 21711.107759727 state: 3, avail frames: 7958, hw_level: 234  <------ slept for 16 ms
06/29 19:35:00.115 DEBUG|        base_utils:0278| [stdout] time: 21711.116734809 state: 3, avail frames: 8362, hw_level: -170
06/29 19:35:00.115 DEBUG|        base_utils:0278| [stdout] time: 21711.121831058 state: 3, avail frames: 8606, hw_level: -414
06/29 19:35:00.115 DEBUG|        base_utils:0278| [stdout] time: 21711.126925558 state: 3, avail frames: 8850, hw_level: -658
Other than these two failures, the test passes consistently.
I think this is a good sign that we can enable optimized no_stream ops on every ALSA device.

These two CLs should solve the remaining failures.

https://chromium-review.googlesource.com/357684
https://chromium-review.googlesource.com/357691
Also, filed issue https://code.google.com/p/chrome-os-partner/issues/detail?id=54942 to track the failure on chell.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/547ee7b5c86235308527c0ddd5e43c1673e7fcf1

commit 547ee7b5c86235308527c0ddd5e43c1673e7fcf1
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Thu Jun 30 07:50:10 2016

alsa_api_test: Check device consumption rate

The sleep time in each period might not be accurate.
Check device consumption rate rather than checking buffer level.

BUG=chromium:617516
TEST=run alsa_api_test --move on samus.

Change-Id: I6d60c7839717a485fbe744dd6500041cbdcebfd6
Reviewed-on: https://chromium-review.googlesource.com/357691
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/547ee7b5c86235308527c0ddd5e43c1673e7fcf1/alsa_api_test.c

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/547ee7b5c86235308527c0ddd5e43c1673e7fcf1

commit 547ee7b5c86235308527c0ddd5e43c1673e7fcf1
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Thu Jun 30 07:50:10 2016

alsa_api_test: Check device consumption rate

The sleep time in each period might not be accurate.
Check device consumption rate rather than checking buffer level.

BUG=chromium:617516
TEST=run alsa_api_test --move on samus.

Change-Id: I6d60c7839717a485fbe744dd6500041cbdcebfd6
Reviewed-on: https://chromium-review.googlesource.com/357691
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/547ee7b5c86235308527c0ddd5e43c1673e7fcf1/alsa_api_test.c

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/0ce0655c340d8769a97cec9f6e59e99f0c6f208f

commit 0ce0655c340d8769a97cec9f6e59e99f0c6f208f
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Wed Jul 13 07:18:06 2016

alsa_api_test: Extends playback period after move

We should play for a longer time so estimated sampling rate can be more
accurate.

BUG=chromium:617516
TEST=run alsa_api_test --move on veyron_minnie

Change-Id: Icc8e1af9951903ed8d1f93feb8af7966ac8b5d83
Reviewed-on: https://chromium-review.googlesource.com/360054
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/0ce0655c340d8769a97cec9f6e59e99f0c6f208f/alsa_api_test.c

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/71d7af07c2ac14c5cd3f5b41008405a27c9628a3

commit 71d7af07c2ac14c5cd3f5b41008405a27c9628a3
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Thu Jun 30 09:20:07 2016

[autotest] audio_AlsaAPI: Skip some devices on some boards

Chell's HDMI device hw:0,4 can not be used without it being plugged.
Also, its HDMI device hw:0,5 and hw:0,6 are dummy devices.

BUG=chromium:617516
TEST=run audio_AlsaAPI.move test on chell and samus.

Change-Id: Ibaa95720e80b3ed14aad1e66c731b3f72b723236
Reviewed-on: https://chromium-review.googlesource.com/357684
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Chinyue Chen <chinyue@chromium.org>

[modify] https://crrev.com/71d7af07c2ac14c5cd3f5b41008405a27c9628a3/client/site_tests/audio_AlsaAPI/audio_AlsaAPI.py

Status: Archived (was: Started)

Comment 12 by ketakid@google.com, Mar 18 2017

Labels: Pri-3
Status: Available (was: Archived)
Activating. Please assign to the right owner and the appropriate priority.
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Sign in to add a comment