New issue
Advanced search Search tips

Issue 617515 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Multiple entries for the same password

Project Member Reported by sdefresne@chromium.org, Jun 6 2016

Issue description

I got some duplicate entries when I look at my password, for example, www.dropbox.com (see screenshot).

I inspected the entries and they use the same URL / username / password. Could be related to sync (which is enabled).

vabr: can you triage?
 
Screen Shot 2016-06-06 at 09.12.12.png
47.6 KB View Download
No showing the password as it is sensitive, but I checked and they are identical.

Comment 2 by vabr@chromium.org, Jun 6 2016

Cc: kolos@chromium.org
Labels: Hotlist-Polish
Thanks for the report!

When you hover over the hostname, are those links for different URLs (in particular, please check the scheme).

Maxim, should the de-duplication logic in PasswordManagerPresenter have merged these two together?

Comment 3 by vabr@chromium.org, Jun 6 2016

Components: UI>Browser>Passwords
Yes, I checked that and they are both for https://www.dropbox.com/1/connect

Comment 5 by kolos@chromium.org, Jun 6 2016

Cc: var@chromium.org
Owner: kolos@chromium.org
Yes, it seems that the entries should have been merged. Looks like a bug. 

Thanks for reporting, sdefresne@.


Comment 6 by kolos@chromium.org, Jun 6 2016

But I have no idea what happened...

1. What is OS? What is the version of Chrome? The UI on screenshot looks like it is old UI (no Auto Signin checkbox). 

2. Could you output the variable "key" right before the return statement in CreateSortKey(https://cs.chromium.org/chromium/src/chrome/browser/ui/passwords/password_manager_presenter.cc?q=CreateSortKey)? And provide the console output.
It will output unhashed passwords! Replace them with "???" or so. 
This is the current stable version on Mac (50.0.2661.102). I also have duplicates on my Android device though (running version 50.0.2661.89).

I'll try to get the value of key, but I do not have a build of Chromium available at the moment.

Comment 8 by kolos@chromium.org, Jun 6 2016

Password entries deduping is since 51. Please check how it works in dev channel. Thanks.

Best regards,
Maxim

Comment 9 by vabr@chromium.org, Jun 7 2016

Cc: -kolos@chromium.org -var@chromium.org
Status: Fixed (was: Assigned)
Updated desktop to M51 and the duplicate entry disappeared. Thank you.

Sign in to add a comment