New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 617514 link

Starred by 2 users
Status: Duplicate
Merged: issue 617694
Owner: ----
Closed: Jul 2016
Cc:
█ tkonch...@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

CSSStyleDeclaration.setProperty funky parsing for custom variables

Reported by mauricio...@gmail.com, Jun 6 2016 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36

Steps to reproduce the problem:
Set an rgb value to a custom variable: `element.style.setProperty('--some-variable', '#123456')`.

What is the expected behavior?
The custom variable should accept the right rgb value.

What went wrong?
Instead, it adds garbage to the value.

This only happens for rgb colors starting with a number:
'#123456' -> '#\31 23456'
'#012345' -> '#\30 12345'
'123456' -> '123456'
'abcdef' -> 'abcdef'
'#abcdef' -> '#abcdef'
'#a00' -> '#a00'
'#0a0' -> '#\30 a0'

Did this work before? N/A 

Chrome version: 51.0.2704.79  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 21.0 r0

Tested on Stable and Canary channels -- both presented the same problem.

Comment 1 by tkonch...@chromium.org, Jun 7 2016

Cc: tkonch...@chromium.org
Labels: Needs-Feedback
Could you please provide a sample testcase to reproduce the issue from test team end.

Comment 2 by mauricio...@gmail.com, Jun 7 2016 

Surely. See attachment or head over to https://f001.backblaze.com/file/mrkishi/tests/chromium-issue-617514.html (the code is readily displayed, by the way).
chromium-issue-617514.html
899 bytes View Download
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 8 2016

Labels: -Needs-Feedback Needs-Review
Owner: tkonch...@chromium.org
Thank you for providing more feedback. Adding requester "tkonchada@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by tkonch...@chromium.org, Jul 15 2016

Components: Blink>CSS
Labels: -Needs-Review Needs-Feedback OS-Linux OS-Mac
Owner: ----
Status: Untriaged (was: Unconfirmed)
Thanks for the html file.

Able to reproduce the issue on mac, win8 and linux chrome version 51.0.2704.106 and 52.0.2743.75 - Black color displayed

This is working fine in latest dev 53.0.2785.8 and canary 54.0.2797.0

Could you please upgrade to latest builds and update the thread with your observations. 

@dev: Could you please let us know if a reverse bisect is needed in this case.

Comment 5 by mauricio...@gmail.com, Jul 15 2016 

Thank you!

I have confirmed it to be working on the latest Canary (54.0.2797.0), while still broken in the latest stable  (51.0.2704.106).

I don't have access to a box with the dev channel *right now*, but given our other experiences matched, that one should as well.

Let me know if there's anything I could help with.

Comment 6 by timloh@chromium.org, Jul 18 2016

Mergedinto: 617694
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment