Issue metadata
Sign in to add a comment
|
Regression: Tab focus is not proper on chevron icon of Book mark bar.
Reported by
dmascare...@etouch.net,
Jun 6 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 53.0.2759.0 (Official Build)5a1a04452d17cdc3c669949ad74a2f9b6e66b97e-refs/heads/master@{#397936} OS: Mac Pro (10.10.5,10.11.4),Mac Retina(10.11.4) What steps will reproduce the problem? 1. Launch chrome and bookmark 8-10 webpage such that chevron icon appears on the bookmark bar. 2. Press ‘Tab’ from keyboard till focus reaches on chevron icon and observe. Actual:Tab focus is not proper on chevron icon. Expected:Tab focus should be proper on chevron icon. This is regression issue,broken in ‘M 53’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/b35e69696d63b00693ea4bf2563babb20c51be30..384032da30351eb07a56b86e9dd38e316add54d6?pretty=fuller&n=100 Suspecting: r396851 Good build: 53.0.2753.0 Bad build: 53.0.2754.0 Note: Issue is not seen on Windows and Linux OS.
,
Jun 6 2016
Above issue is reproducible on Latest Chrome Version: 53.0.2760.0 (Official Build) 851eb42016eeca7ac932921164bb1fdb3a5844b3-refs/heads/master@{#397956}
,
Jun 15 2016
Unable to reproduce the issue on MacBook Pro (Retina) 10.11.5 chrome version 53.0.2768.0 - Observed that focus is not going to bookmark bar dmascarenhas@etouch.net, Could you please recheck the same and update the thread.
,
Jun 15 2016
With response to comment #4: Above issue is still reproducible on Mac Pro(10.10.5, 10.11.4), Mac Retina (10.11.4) Chrome Version:53.0.2768.0 (Official Build)9cd2e77b728d6d5ac115acd944b37df70423c355-refs/heads/master@{#399800} Please refer attached screencast.
,
Jun 15 2016
,
Jun 15 2016
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce0f71bffa40beb738e2579efd91d3a0260dd010 commit ce0f71bffa40beb738e2579efd91d3a0260dd010 Author: shrike <shrike@chromium.org> Date: Fri Jun 17 00:14:27 2016 [Mac][Material Design] Fix bookmark chevron button focus ring location. This cl adjusts the bookmark bar's chevron button's focus ring, which is 2pt too low. R=tapted@chromium.org BUG= 617511 Review-Url: https://codereview.chromium.org/2074503002 Cr-Commit-Position: refs/heads/master@{#400309} [modify] https://crrev.com/ce0f71bffa40beb738e2579efd91d3a0260dd010/chrome/app/nibs/BookmarkBar.xib [modify] https://crrev.com/ce0f71bffa40beb738e2579efd91d3a0260dd010/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
,
Jun 17 2016
,
Jun 17 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 21 2016
verified this issue on Mac OS X 10.11.5 using Chrome canary #53.0.2774.2, working as intended. adding TE-verified labels.
,
Jun 21 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c8408ac25aa7b3381f35228bd267dff6d4528e0 commit 9c8408ac25aa7b3381f35228bd267dff6d4528e0 Author: Jayson Adams <shrike@chromium.org> Date: Tue Jun 21 14:59:55 2016 [Mac][Material Design] Fix bookmark chevron button focus ring location. This cl adjusts the bookmark bar's chevron button's focus ring, which is 2pt too low. R=tapted@chromium.org BUG= 617511 Review-Url: https://codereview.chromium.org/2074503002 Cr-Commit-Position: refs/heads/master@{#400309} (cherry picked from commit ce0f71bffa40beb738e2579efd91d3a0260dd010) Review URL: https://codereview.chromium.org/2089653002 . Cr-Commit-Position: refs/branch-heads/2743@{#429} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/9c8408ac25aa7b3381f35228bd267dff6d4528e0/chrome/app/nibs/BookmarkBar.xib [modify] https://crrev.com/9c8408ac25aa7b3381f35228bd267dff6d4528e0/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
,
Jun 21 2016
,
Jun 21 2016
Thank you Jason for merging the CL in to M52 branch.
,
Jun 21 2016
You bet.
,
Jun 22 2016
verified this issue on Mac OS X 10.11.4 using Chrome version #52.0.2743.49, working as intended. adding TE-verified labels. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dmascare...@etouch.net
, Jun 6 2016