Specializations for OwnedPtrDeleter<T> are now a blocker for migrating all OwnPtrs to std::unique_ptr, since they cannot be replaced mechanically. The usage is rare, so we can manually convert each instance instead.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4395bd8231b38b9b467f1141ccf0a4a7258f1f5c commit 4395bd8231b38b9b467f1141ccf0a4a7258f1f5c Author: yutak <yutak@chromium.org> Date: Mon Jun 06 09:19:38 2016 Remove the use of OwnedPtrDeleter in HarfBuzzFace. It's hard to mechanically replace specializations of OwnedPtrDeleter<T> to std::unique_ptr equivalents. Therefore, they are converted to std::unique_ptr manually. The specializations in HarfBuzzFace.h are only used from HarfBuzzFace.cpp, so the new deleters are added in .cpp file. New typedefs are created so people can always use std::unique_ptr with a correct deleter. BUG= 617504 Review-Url: https://codereview.chromium.org/2043613002 Cr-Commit-Position: refs/heads/master@{#397996} [modify] https://crrev.com/4395bd8231b38b9b467f1141ccf0a4a7258f1f5c/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp [modify] https://crrev.com/4395bd8231b38b9b467f1141ccf0a4a7258f1f5c/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b06121b2024e23574d9f8423a326368e6cf6313 commit 8b06121b2024e23574d9f8423a326368e6cf6313 Author: yutak <yutak@chromium.org> Date: Tue Jun 07 01:03:10 2016 Remove obsolete friend declarations for MSVC. These friend declarations were added because MSVC had a bug around the visibility of nested classes. They are no longer necessary. BUG= 617504 Review-Url: https://codereview.chromium.org/2043633002 Cr-Commit-Position: refs/heads/master@{#398181} [modify] https://crrev.com/8b06121b2024e23574d9f8423a326368e6cf6313/third_party/WebKit/Source/platform/graphics/ContiguousContainer.h [modify] https://crrev.com/8b06121b2024e23574d9f8423a326368e6cf6313/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.h [modify] https://crrev.com/8b06121b2024e23574d9f8423a326368e6cf6313/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd commit 353f2d5d9303dc221bb39493f0fe0f4294d3b3dd Author: yutak <yutak@chromium.org> Date: Tue Jun 07 03:07:14 2016 Remove the use of OwnedPtrDeleter in WebMessagePortChannel. It's hard to mechanically replace specializations of OwnedPtrDeleter<T> to std::unique_ptr equivalents, so they are converted manually. A new typedef WebMessagePortChannelUniquePtr is introduced so people can always use std::unique_ptr with a correct deleter. BUG= 617504 Review-Url: https://codereview.chromium.org/2043583002 Cr-Commit-Position: refs/heads/master@{#398213} [modify] https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd/third_party/WebKit/Source/core/dom/MessageChannel.cpp [modify] https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd/third_party/WebKit/Source/core/dom/MessagePort.cpp [modify] https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd/third_party/WebKit/Source/core/dom/MessagePort.h [modify] https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd/third_party/WebKit/Source/core/workers/SharedWorker.cpp [modify] https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd/third_party/WebKit/Source/core/workers/SharedWorkerRepositoryClient.h [modify] https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd/third_party/WebKit/Source/platform/CrossThreadCopier.h [modify] https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp [modify] https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.h [modify] https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd/third_party/WebKit/Source/web/WebDOMMessageEvent.cpp [modify] https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp [modify] https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd/third_party/WebKit/Source/web/WebSharedWorkerImpl.h [modify] https://crrev.com/353f2d5d9303dc221bb39493f0fe0f4294d3b3dd/third_party/WebKit/public/platform/WebMessagePortChannel.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d588ed27838ec6df972ccdf662ab0ed39ec9514 commit 3d588ed27838ec6df972ccdf662ab0ed39ec9514 Author: yutak <yutak@chromium.org> Date: Tue Jun 07 08:24:18 2016 Remove obsolete friend declarations for MSVC. These friend declarations were added because MSVC had a bug around the visibility of nested classes. They are no longer necessary. BUG= 617504 Review-Url: https://codereview.chromium.org/2041273002 Cr-Commit-Position: refs/heads/master@{#398255} [modify] https://crrev.com/3d588ed27838ec6df972ccdf662ab0ed39ec9514/third_party/WebKit/Source/platform/PODArena.h [modify] https://crrev.com/3d588ed27838ec6df972ccdf662ab0ed39ec9514/third_party/WebKit/Source/platform/fonts/SimpleFontData.h [modify] https://crrev.com/3d588ed27838ec6df972ccdf662ab0ed39ec9514/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h [modify] https://crrev.com/3d588ed27838ec6df972ccdf662ab0ed39ec9514/third_party/WebKit/Source/platform/testing/TestPaintArtifact.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cac603089a768537fef525ee0d86054127f713f commit 7cac603089a768537fef525ee0d86054127f713f Author: yutak <yutak@chromium.org> Date: Tue Jun 07 10:27:54 2016 Remove yet another obsolete MSVC workaround. The workaround is no longer necessary. BUG= 617504 Review-Url: https://codereview.chromium.org/2048583003 Cr-Commit-Position: refs/heads/master@{#398266} [modify] https://crrev.com/7cac603089a768537fef525ee0d86054127f713f/third_party/WebKit/Source/wtf/LinkedStack.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2ba5dac4355691372f643a0af03681769dae2c7 commit b2ba5dac4355691372f643a0af03681769dae2c7 Author: yutak <yutak@chromium.org> Date: Tue Jun 07 17:16:18 2016 Remove the use of OwnedPtrDeleter in ImageDecoder. It's hard to mechanically replace specializations of OwnedPtrDeleter<T> to std::unique_ptr equivalents. Therefore, they are converted to std::unique_ptr manually. New typedefs named XXXXUniquePtr is introduced so people can always use std::unique_ptr with a correct deleter. BUG= 617504 Review-Url: https://codereview.chromium.org/2037373002 Cr-Commit-Position: refs/heads/master@{#398319} [modify] https://crrev.com/b2ba5dac4355691372f643a0af03681769dae2c7/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp [modify] https://crrev.com/b2ba5dac4355691372f643a0af03681769dae2c7/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb9b91321850375af904a3f9fc017ee18a9d32b3 commit fb9b91321850375af904a3f9fc017ee18a9d32b3 Author: yutak <yutak@chromium.org> Date: Wed Jun 08 09:36:09 2016 Remove the use of OwnedPtrDeleter in WebHelperPlugin. It's hard to mechanically replace specializations of OwnedPtrDeleter<T> to std::unique_ptr equivalents. Therefore, they are converted to std::unique_ptr manually. A new typedef WebHelperPluginUniquePtr is created so people can always use std::unique_ptr with a correct deleter. BUG= 617504 Review-Url: https://codereview.chromium.org/2041263002 Cr-Commit-Position: refs/heads/master@{#398508} [modify] https://crrev.com/fb9b91321850375af904a3f9fc017ee18a9d32b3/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp [modify] https://crrev.com/fb9b91321850375af904a3f9fc017ee18a9d32b3/third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp [modify] https://crrev.com/fb9b91321850375af904a3f9fc017ee18a9d32b3/third_party/WebKit/public/web/WebHelperPlugin.h
Renaming Blink>WTF to Blink>Internals>WTF.
Renaming Blink>Architecture to Blink>Internals
Comment 1 by bugdroid1@chromium.org
, Jun 6 2016