New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 617499 link

Starred by 4 users
Status: Fixed
Owner:
wychen@chromium.org
Closed: Jun 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Theme doesn't apply to Incognito window

Project Member Reported by sc00335...@techmahindra.com, Jun 6 2016 
Version: 53.0.2759.0 dev
OS: Ubuntu 14.04

Test URL: https://chrome.google.com/webstore/detail/superman-theme-red-on-blu/dmodppofjbaoggbchnngcaljngfffloj?hl=en-GB

What steps will reproduce the problem?
(1) Launch chrome, add above theme and open incognito window and observe for theme on NTP

Expected: Theme should be applied to NTP of Incognito window
Actual: Instead theme is not applied to incognito window.

This is regression issue broken in M53. Will provide bisect info soon.
Expected_theme.png
1.2 MB View Download
Actual_theme.png
148 KB View Download

Comment 1 by sc00335...@techmahindra.com, Jun 6 2016 

Issue is seen in windows too. Issue is seen on adding any theme. i.e; No image of theme applied is seen in Incognito new tab.

Comment 2 by brajkumar@chromium.org, Jun 6 2016

Labels: ReleaseBlock-Beta OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Windows 7 and Mac OS 10.11.5 using chrome latest Dev M53-53.0.2759.0. Observed the theme is not applied on incognito mode.

Comment 3 by sc00335...@techmahindra.com, Jun 6 2016

Labels: -Needs-Bisect hasbisect
Owner: wychen@chromium.org
Status: Assigned (was: Untriaged)
Manual Changelog:

Good Build: 53.0.2757.0 dev
Bad Build: 53.0.2758.0 dev

CHANGELOG URL: 
 https://chromium.googlesource.com/chromium/src/+log/7b64dd5086f01d62d746d89e9cc7c2888094a631..0702b27a85c1b650e1a7f162b7484b2a7f71cf6e

Suspecting https://codereview.chromium.org/2003963004 from changelog.

@wychen: Please help in re-assigning if t is not related to your change.

Comment 4 by geki...@gmail.com, Jun 6 2016 

could my  Issue 617080  be related?

Comment 5 by wychen@chromium.org, Jun 6 2016

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d6c38c4ea96577313566d1f0ba4b41d86242b6e

commit 4d6c38c4ea96577313566d1f0ba4b41d86242b6e
Author: wychen <wychen@chromium.org>
Date: Tue Jun 07 17:21:39 2016

Whitelist themes in CSP of chrome://newtab

BUG= 617499 

Review-Url: https://codereview.chromium.org/2040903002
Cr-Commit-Position: refs/heads/master@{#398321}

[modify] https://crrev.com/4d6c38c4ea96577313566d1f0ba4b41d86242b6e/chrome/browser/ui/webui/ntp/new_tab_ui.cc

Comment 8 by ssamanoori@chromium.org, Jun 15 2016

Labels: TE-Verified-M53 TE-Verified-53.0.2768.0
Tested the issue on Windows 7, Mac 10.11.5, Ubuntu 14.04 using latest M-53(53.0.2768.0).Unable to reproduce the issue.
Please find attached screenshot.

Marking it as TE-Verified.
617499.png
3.1 MB View Download

Comment 9 by manoranj...@chromium.org, Jun 16 2016 

wychen@, could you please mark this issue as 'Fixed'?

Thank you!

Comment 10 by rnimmagadda@chromium.org, Jun 20 2016 

wychen@, could you please mark this issue as 'Fixed'?

Thank you!

Comment 11 by wychen@chromium.org, Jun 20 2016

Status: Fixed (was: Started)
►

Sign in to add a comment