Network Utilization audit prints spurious warning about cookie size
Reported by
i...@jameside.com,
Jun 6 2016
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36 Steps to reproduce the problem: 1. Visit google.com and open the Web Inspector 2. On the Audits tab, select "Reload Page and Audit on Load" and run an audit 3. Under the "Network Utilization" section, there is a warning about the average cookie size even though the cookie is tiny What is the expected behavior? No warning when the average cookie size is sufficiently small, except when there are a very large number of requests with no cookies and one request with an enormous cookie. However, the Audit tool already checks for large outlier cookies, so fixing this issue is just a matter of suppressing the warning when the average cookie size is small. Also see https://stackoverflow.com/questions/10105602/why-does-chrome-audit-recommend-me-to-minimize-cookie-size for more people who interpret this warning to mean something is wrong or can be meaningfully improved. What went wrong? The audit reports that the average cookie size per request on google.com is 113B. Did this work before? No Chrome version: 50.0.2661.102 Channel: stable OS Version: OS X 10.11.4 Flash Version: Shockwave Flash 21.0 r0 The code here unconditionally prints a warning: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js?sq=package:chromium&dr=C&l=1501
,
Jun 6 2016
I don't think that we need to look into this from a privacy perspective.
,
Jun 7 2016
Tested the issue on Windows 7, Mac 10.11.5, Ubuntu 14.04 using 50.0.2661.,102, latest stable 51.0.2704.84, canary 53.0.2761.2 as per above steps. Observed the behavior as in screencast. Please find attached screencast. ide@ Could you please provide expected behavior screencast for further triaging the issue.
,
Jun 8 2016
In the attached screenshot, the average cookie size is 116B. Since this is tiny and below the 400B threshold used by another audit heuristic, my suggestion is that the suggestion to "Minimize cookie size" should not be displayed at all.
,
Jun 8 2016
As for triaging, git blame shows that apavlov@ would probably be the best person to look at this.
,
Jun 8 2016
Thank you for providing more feedback. Adding requester "ssamanoori@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 9 2016
ccing 'apavlov@' to look into this issue as per comment #5.
,
Jun 9 2016
I transferred off the project 1.5 years ago, sorry.
,
Jun 9 2016
allada@, since this audit is network-related, would you like to take alook?
,
Jun 9 2016
Audits are designed to give information and place emphasis on certain items when parameters are triggered. It is setup to always show average cookie size and intended. We are not telling the user "lower your cookies always", we are simply saying: "Hey your average cookie size is: xxxx". If the size goes over (I think the threshold is) 400 bytes we tell the user it's a potential problem. I do not see this as a bad thing, so I am going to close it. Thanks for the suggestion though! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kolos@chromium.org
, Jun 6 2016