enable_print_preview = false build is broken
Reported by
filosott...@gmail.com,
Jun 5 2016
|
||||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.24 Safari/537.36
Steps to reproduce the problem:
1. add enable_print_preview = false to args.gn
2. gn gen
What is the expected behavior?
What went wrong?
```
ERROR at //chrome/test/BUILD.gn:1344:9: Item not found
"../browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc",
^-----------------------------------------------------------------------
You were trying to remove "../browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc"
from the list but it wasn't there.
See //BUILD.gn:142:7: which caused the file to be included.
"//chrome/test:browser_tests",
^----------------------------
```
Did this work before? N/A
Chrome version: 52.0.2743.24 Channel: beta
OS Version: OS X 10.11.5
Flash Version: Shockwave Flash 22.0 r0
,
Jun 6 2016
This flag seems to work for GYP. Have CC'd rsesek@ who might know more about this / who to assign it to.
,
Jun 6 2016
For the record, this works on Linux.
,
Jun 7 2016
This is because the file is explicitly excluded on Mac already: https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?q=cloud_print_policy_browsertest.cc&sq=package:chromium&dr=C&l=1229 And then setting enable_print_preview=false tries to remove it a second time: https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?q=cloud_print_policy_browsertest.cc&sq=package:chromium&l=1344&dr=C
,
Jun 7 2016
,
Jun 17 2016
Moving to Internals>Printing as this doesn't appear to be Cloud Print specific.
,
Jun 17 2016
https://codereview.chromium.org/2073283002
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/788d0f8e2a4e19db99b1336aff379f60c3f0063d commit 788d0f8e2a4e19db99b1336aff379f60c3f0063d Author: thestig <thestig@chromium.org> Date: Fri Jun 17 23:25:39 2016 GN: Consolidate some printing test exclusion rules. BUG= 617477 Review-Url: https://codereview.chromium.org/2073283002 Cr-Commit-Position: refs/heads/master@{#400539} [modify] https://crrev.com/788d0f8e2a4e19db99b1336aff379f60c3f0063d/chrome/test/BUILD.gn
,
Jun 17 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by filosott...@gmail.com
, Jun 5 2016