remote_assistance_host crashes if client disconnects the connection |
||
Issue descriptionVersion: M53, up to e1f7c121717a5b0272e0011415eb8698a6fde1d2, won't reproduce on M51 OS: Windows 10 as host, gubuntu as client What steps will reproduce the problem? (1) Connect to IT2Me scenario (2) Disconnect by clicking disconnect button on client webapp What is the expected output? Disconnect, and nothing wrong from both host and client side. What do you see instead? Host pops up Windows error, an unhandled win32 exception occurred in remote_assistance_host.exe. Please use labels and text to provide additional information. Stack trace, remoting_core.dll!base::debug::BreakDebugger() Line 21 remoting_core.dll!logging::LogMessage::~LogMessage() Line 743 remoting_core.dll!remoting::It2MeHost::SetState(remoting::It2MeHostState state, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & error_message) Line 415 remoting_core.dll!remoting::It2MeHost::Shutdown() Line 123 Current state_ == kDisconnected, new state == kDisconnected. i.e. SetState from kDisconnected to kDisconnected. A quick investigation shows It2MeHost::Shutdown function has been called twice, one is from It2MeHost::OnClientDisconnected, the other is from It2MeHost::Disconnect.
,
Jun 7 2016
I think the right fix is to make Shutdown() return if it's called in kDisconnected state.
,
Jun 8 2016
Agree, I am working on it.
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f36aac5517dc426a97f23531fd5291aff982dc50 commit f36aac5517dc426a97f23531fd5291aff982dc50 Author: zijiehe <zijiehe@chromium.org> Date: Thu Jun 09 04:34:10 2016 [Chromoing] Fix DCHECK when shutting down It2Me host from client side This change is to fix a DCHECK issue in It2Me scenario. remote_assistance_host triggers a DCHECK failure if client disconnects the connection. So this change modified It2MeHost::Shutdown function to return directly if current state is kDisconnected. See bug for details. BUG= 617474 Review-Url: https://codereview.chromium.org/2040353002 Cr-Commit-Position: refs/heads/master@{#398783} [modify] https://crrev.com/f36aac5517dc426a97f23531fd5291aff982dc50/remoting/host/it2me/it2me_host.cc [modify] https://crrev.com/f36aac5517dc426a97f23531fd5291aff982dc50/remoting/host/it2me/it2me_host.h
,
Jun 9 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by jamiewa...@chromium.org
, Jun 7 2016Status: Assigned (was: Untriaged)