New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617403 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue skia:3489



Sign in to add a comment

Print output doesn't have color Emoji

Project Member Reported by ebra...@gnu.org, Jun 4 2016

Issue description

Version: Version 53.0.2757.0
OS: Win 10

Open
data:text/html;charset=utf8,<title>%F0%9F%98%8A</title>%F0%9F%98%8A%F0%9F%98%8A%F0%9F%98%8A
Press Ctrl+P

What is the expected output?
Color Emoji also on print and print preview

What do you see instead?
B&W emoji

Probably related to  Issue 617379  and  Issue 617376 .
 

Comment 1 by ebra...@gnu.org, Jun 4 2016

Cc: kulshin@chromium.org e...@chromium.org
Components: Blink>Fonts>Emoji
Labels: OS-Windows

Comment 2 by e...@chromium.org, Jun 6 2016

Components: -Blink>Fonts>Emoji Internals>Plugins>PDF
Labels: OS-Mac
This is a more general problem. Mac also doesn't render color emoji (at all, not even in B/W) in print preview.

Comment 4 by ebra...@gnu.org, Jun 7 2016

Cc: bunge...@chromium.org
Cc: halcanary@chromium.org
I think we send the glyph ids out to the generated PDF, but if we're subsetting maybe they're getting dropped? Maybe this is a view issue?

Comment 6 by kotah@chromium.org, Aug 19 2016

Cc: kotah@chromium.org
Components: Internals>Printing
Labels: Hotlist-Enterprise OS-Chrome
ChromeOS users also report this issue - print output drops emojis.

Repro steps:
1. Open Google Docs, copy & paste emojis from https://en.wikipedia.org/wiki/Emoji
2. Ctrl+P. Confirm eomjis are dropped from print preview

Comment 7 by ebra...@gnu.org, Aug 21 2016

I'd guess the best approach here and well, the most difficult one perhaps, would be converting raster based glyphs to actual images on print output and converting MS format color glyphs to separate B&W layers associated with their color (instead going through fixing font subsetter and implementing viewer path, re: c5)

Comment 8 by ebra...@gnu.org, Aug 21 2016

^ just like Firefox, which wouldn't need to make cross-platform PDF viewers to deal with different color emoji standards. 

Comment 9 by npm@chromium.org, Oct 25 2016

Note: emojis cannot be seen when opening the pdf on Mac Preview app.
Components: Internals>Skia>PDF
Labels: OS-Linux
Owner: halcanary@chromium.org
Status: Assigned (was: Untriaged)
My gut feeling is this is a SkPDF issue, so I'm going to let halcanary own this.

Below are my test results from today:

On Linux, Chrome 58 renders "white :)" in the omnibox and "black -_-" in the renderer. The print preview shows up as "black -_-"

On Linux, with Firefox, the output is consistently white smilies.

On ChromeOS with Chrome 57, both the omnibox and the renderer shows coloried smileys, but print preview does not render them.

On Windows 10 with Chrome 58, the original bug report behavior still occurs.

Comment 11 by ebra...@gnu.org, Mar 26 2017

Cc: behdad@chromium.org
\
Blockedon: skia:3489
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/10ccb02feeefdad2c34621d20cc858d65169d7be

commit 10ccb02feeefdad2c34621d20cc858d65169d7be
Author: Hal Canary <halcanary@google.com>
Date: Wed Jul 19 14:49:57 2017

SkPDF: Fix color glyphs with absolute positioning

BUG= chromium:617403 
BUG= chromium:717570 
BUG= skia:3489 
Change-Id: I6b336836359e2cdccf5712edce5efd89f682a74d
Reviewed-on: https://skia-review.googlesource.com/24620
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>

[modify] https://crrev.com/10ccb02feeefdad2c34621d20cc858d65169d7be/src/pdf/SkPDFDevice.cpp

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a76b1d6d66b131e3ead86d85dafcb6c6d2c7545

commit 7a76b1d6d66b131e3ead86d85dafcb6c6d2c7545
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Wed Jul 19 16:51:00 2017

Roll src/third_party/skia/ 5af44defb..925f52d03 (12 commits)

https://skia.googlesource.com/skia.git/+log/5af44defbd5f..925f52d03b73

$ git log 5af44defb..925f52d03 --date=short --no-merges --format='%ad %ae %s'
2017-07-19 ethannicholas fixed SPIR-V int->uint conversion
2017-07-14 bsalomon Remove GrAnalyticRectOp, the last legacy GrMeshDrawOp
2017-07-19 reed experimental: draw into unpremul
2017-07-19 reed remove google3 colortable flag
2017-07-19 fmalita Singleton SRGB color filters
2017-07-19 egdaniel Add blacklist to vk win intel for skp
2017-07-19 halcanary SkPDF: Fix color glyphs with absolute positioning
2017-07-18 scroggo Report first GIF frame after knowing its meta data
2017-07-19 rmistry Download material design SVGs from Google Storage
2017-07-18 brianosman Some basic Flutter/Fuchsia docs
2017-07-18 jshin Add aliases mapping Windows CJ fonts to Noto Serif CJK
2017-07-18 bsalomon Revert "Revert "Make GrAtlasTextOp a non-legacy GrMeshDrawOp""

Created with:
  roll-dep src/third_party/skia
BUG= 617403 , 722470 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I75eac4d2db0d0c21b05c5561ad44556fb25dcf8f
Reviewed-on: https://chromium-review.googlesource.com/577769
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487889}
[modify] https://crrev.com/7a76b1d6d66b131e3ead86d85dafcb6c6d2c7545/DEPS

Comment 15 by js...@chromium.org, Jul 19 2017

Cc: -kotah@chromium.org js...@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment