Chrome UI doesn't support Color Emoji |
|||||
Issue descriptionVersion: Version 53.0.2757.0 OS: Win 10 data:text/html;charset=utf8,<title>%F0%9F%98%8A</title>%F0%9F%98%8A%F0%9F%98%8A%F0%9F%98%8A What is the expected output? Color Emoji also on tab and Omnibar What do you see instead? B&W emoji
,
Jun 4 2016
Expected behaviour is to have Color Emoji also on UI, just like Firefox with same testcase.
,
Jun 4 2016
I'd guess this is because getting fallback font from uniscribe fallback instead directwrite on Windows, https://cs.chromium.org/chromium/src/ui/gfx/render_text_harfbuzz.cc?l=1399 as it seems UI B&W Emojis are being rendered with Segoe UI Symbol instead Segoe UI Emoji.
,
Jun 6 2016
,
Jun 8 2016
Confirmed that if fallback is forced to fall back on "Segoe UI Emoji" the emoji render in color in UI. TBD what's the right way to actually make that happen.
,
Jun 9 2016
,
Jun 16 2016
Issue 620419 has been merged into this issue.
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce612ebdb8874b563d020338969f20f227b8dd9f commit ce612ebdb8874b563d020338969f20f227b8dd9f Author: kulshin <kulshin@chromium.org> Date: Wed Jun 29 18:46:51 2016 Updates UI font fallback to use DirectWrite when available so that we can fallback to the color emoji font. Summary of changes: TextAnalysisSource was moved from content/common to gfx/ui/win, namespace was changed accordingly, and users updated. The public GetUniscribeFallbackFont API was renamed to GetFallbackFont. This API will now check if it can use DirectWrite font fallback; otherwise it will call the old codepath. Using DirectWrite for fallback allows the UI code to correctly fallback on the color emoji font when available. BUG= 617376 Review-Url: https://codereview.chromium.org/2054273002 Cr-Commit-Position: refs/heads/master@{#402879} [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/components/url_formatter/elide_url_unittest.cc [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/content/child/dwrite_font_proxy/font_fallback_win_unittest.cc [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/content/content_common.gypi [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/BUILD.gn [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/font_fallback_win.cc [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/font_fallback_win.h [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/gfx.gyp [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/gfx_tests.gyp [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/platform_font_win.cc [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/platform_font_win.h [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/render_text_harfbuzz.cc [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/render_text_unittest.cc [modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/text_elider_unittest.cc [rename] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/win/text_analysis_source.cc [rename] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/win/text_analysis_source.h [add] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/win/text_analysis_source_unittest.cc
,
Jun 29 2016
Checked on Version 53.0.2784.0 and works great. Thanks!
,
Jul 7 2016
Rechecked this on Windows 10 for chrome version 53.0.2785.8. fix is working as intended. Attached screen shot for the same. Adding TE-verified labels. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ebra...@gnu.org
, Jun 4 2016