New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617376 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Chrome UI doesn't support Color Emoji

Project Member Reported by ebra...@gnu.org, Jun 4 2016

Issue description

Version: Version 53.0.2757.0
OS: Win 10

data:text/html;charset=utf8,<title>%F0%9F%98%8A</title>%F0%9F%98%8A%F0%9F%98%8A%F0%9F%98%8A

What is the expected output?
Color Emoji also on tab and Omnibar

What do you see instead?
B&W emoji

 

Comment 1 by ebra...@gnu.org, Jun 4 2016

Labels: OS-Windows

Comment 2 by ebra...@gnu.org, Jun 4 2016

Expected behaviour is to have Color Emoji also on UI, just like Firefox with same testcase.

Comment 3 by ebra...@gnu.org, Jun 4 2016

I'd guess this is because getting fallback font from uniscribe fallback instead directwrite on Windows, https://cs.chromium.org/chromium/src/ui/gfx/render_text_harfbuzz.cc?l=1399 as it seems UI B&W Emojis are being rendered with Segoe UI Symbol instead Segoe UI Emoji.
Owner: kulshin@chromium.org
Confirmed that if fallback is forced to fall back on "Segoe UI Emoji" the emoji render in color in UI. TBD what's the right way to actually make that happen.
Status: Started (was: Untriaged)

Comment 7 by ajha@chromium.org, Jun 16 2016

 Issue 620419  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce612ebdb8874b563d020338969f20f227b8dd9f

commit ce612ebdb8874b563d020338969f20f227b8dd9f
Author: kulshin <kulshin@chromium.org>
Date: Wed Jun 29 18:46:51 2016

Updates UI font fallback to use DirectWrite when available
so that we can fallback to the color emoji font.

Summary of changes:
TextAnalysisSource was moved from content/common to
gfx/ui/win, namespace was changed accordingly, and users
updated.
The public GetUniscribeFallbackFont API was renamed to
GetFallbackFont. This API will now check if it can use
DirectWrite font fallback; otherwise it will call the old
codepath. Using DirectWrite for fallback allows the UI
code to correctly fallback on the color emoji font when
available.

BUG= 617376 

Review-Url: https://codereview.chromium.org/2054273002
Cr-Commit-Position: refs/heads/master@{#402879}

[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/components/url_formatter/elide_url_unittest.cc
[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc
[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/content/child/dwrite_font_proxy/font_fallback_win_unittest.cc
[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/content/content_common.gypi
[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/BUILD.gn
[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/font_fallback_win.cc
[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/font_fallback_win.h
[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/gfx.gyp
[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/gfx_tests.gyp
[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/platform_font_win.cc
[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/platform_font_win.h
[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/render_text_harfbuzz.cc
[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/render_text_unittest.cc
[modify] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/text_elider_unittest.cc
[rename] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/win/text_analysis_source.cc
[rename] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/win/text_analysis_source.h
[add] https://crrev.com/ce612ebdb8874b563d020338969f20f227b8dd9f/ui/gfx/win/text_analysis_source_unittest.cc

Comment 9 by ebra...@gnu.org, Jun 29 2016

Status: Fixed (was: Started)
Checked on Version 53.0.2784.0 and works great. Thanks!
Cc: ranjitkan@chromium.org
Labels: TE-Verified-53.0.2785.8 TE-Verified-M53
Rechecked this on Windows 10 for chrome version 53.0.2785.8. fix is working as intended. Attached screen shot for the same. Adding TE-verified labels.
Emoji Icons.png
3.5 KB View Download

Sign in to add a comment