New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617366 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 617791

Blocking:
issue 557181



Sign in to add a comment

Push layer lists instead of layer tree during commit and activation

Project Member Reported by jaydasika@chromium.org, Jun 4 2016

Issue description

Layer hierarchy is no longer used on impl outside tests, so we should be able to push layer list at commit and activation.  
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4340ea0bedd552170d50ca6ff91fe094c5b16b35

commit 4340ea0bedd552170d50ca6ff91fe094c5b16b35
Author: jaydasika <jaydasika@chromium.org>
Date: Mon Jun 06 19:44:26 2016

cc : Add layer_list to LayerTreeImpl and build it for tests

Right now, we do a layer tree walk for iteration over all
layers on impl-side (LayerListIterator). Once we start
pushing layer list instead of layer tree during
commit/activation, we will use layer_list instead(layers
will be added to layer_list in stacking  order during
commit/activation). A lot of tests build layer
tree on the impl-side and don't go through
commit/activation. So, we need to explicitly build the
layer_list for these tests.

BUG= 617366 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2032303004
Cr-Commit-Position: refs/heads/master@{#398100}

[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/input/scrollbar_animation_controller_linear_fade_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/input/scrollbar_animation_controller_thinning_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/layers/heads_up_display_layer_impl_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/layers/layer_utils_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/layers/picture_image_layer_impl_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/layers/picture_layer_impl_perftest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/layers/picture_layer_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/layers/render_surface_impl_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/layers/render_surface_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/layers/video_layer_impl_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/test/fake_layer_tree_host_impl.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/test/test_layer_tree_host_base.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/tiles/tile_manager_perftest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/trees/layer_tree_host_unittest_scroll.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35/cc/trees/occlusion_tracker_perftest.cc

Blockedon: 617791
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b0fd7519392558947d58d3c35265bdc3cc7342c

commit 4b0fd7519392558947d58d3c35265bdc3cc7342c
Author: jaydasika <jaydasika@chromium.org>
Date: Thu Jun 09 18:12:53 2016

cc : Push layer lists instead of layer tree at commit and activation

BUG= 617366 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2051013002
Cr-Commit-Position: refs/heads/master@{#398948}

[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/layers/layer_list_iterator_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/layers/layer_position_constraint_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/layers/layer_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/layers/picture_layer_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/test/layer_tree_host_common_test.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/layer_tree_host_unittest_scroll.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/tree_synchronizer.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/tree_synchronizer_unittest.cc

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b0fd7519392558947d58d3c35265bdc3cc7342c

commit 4b0fd7519392558947d58d3c35265bdc3cc7342c
Author: jaydasika <jaydasika@chromium.org>
Date: Thu Jun 09 18:12:53 2016

cc : Push layer lists instead of layer tree at commit and activation

BUG= 617366 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2051013002
Cr-Commit-Position: refs/heads/master@{#398948}

[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/layers/layer_list_iterator_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/layers/layer_position_constraint_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/layers/layer_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/layers/picture_layer_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/test/layer_tree_host_common_test.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/layer_tree_host_unittest_scroll.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/tree_synchronizer.cc
[modify] https://crrev.com/4b0fd7519392558947d58d3c35265bdc3cc7342c/cc/trees/tree_synchronizer_unittest.cc

Cc: jaydasika@chromium.org
 Issue 603613  has been merged into this issue.

Sign in to add a comment