New issue
Advanced search Search tips

Issue 617364 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug

Blocking:
issue 614588



Sign in to add a comment

MD Settings: Secondary text for multilingual spellcheck section

Project Member Reported by michae...@chromium.org, Jun 4 2016

Issue description

The Spell check part of the Languages section is initially collapsed, so the secondary text should give a summary:

----------------------------------
|   _Spell check_              v |
|   =secondary=text=here=        |
----------------------------------

When it's expanded, it should show the list of enabled languages, with toggle buttons for the ones that support spell check; the buttons are "on" for languages that are enabled for spell check.

----------------------------------
|   _Spell check_              v |
|   =secondary=text=here         |
|                                |
|  [x] English (United States)   |
|  [ ] Spanish (Latin America)   |
|  [x] Spanish (Spain)           |
----------------------------------

What should the secondary text be? The mocks assume a single-spellcheck world, but multilingual is now force-enabled. Do we:

A. List all languages enabled for spellcheck, comma-separated (how should we handle overflow)
B. List only one language
C. ???
 
Do we have an idea of what the average number of languages people will have enabled? 

A. feels a little risky assuming there is a long-tail of languages enabled
B. doesn't feel helpful

A possible "C" option is showing: 
"English (United States), Spanish (Spain), and [x] others"

The first two languages can be the top two preferred based on the order of them in the subpage, and then we handle the overflow with just "and [x] other" for one, and "and [x] others" for more than one. 

Thoughts?


Screen Shot 2016-06-05 at 11.00.32 PM.png
71.6 KB View Download

Comment 2 by groby@chromium.org, Jun 6 2016

Cc: rouslan@chromium.org
+rouslan@ who worked on multilingual spellcheck. Rouslan, do we have any number on "average number of languages"?
We never got around to measuring this number. In general it is believed that ~50% of users are multilingual. Does that help?
Cc: bettes@chromium.org
Owner: michae...@chromium.org
Alan's "C" proposal in #1 seems fine to me. I don't think users can reorder their spellcheck languages, but if they have more than 2 it doesn't seem critical to show the "top" languages.
In the old settings UI, the order of languages also specifies user's preferred website languages, where order matters. Does the new settings UI behave differently?
There are different sections in MD Settings for "Language" and for "Spell check". My understanding is that the Language section can be reordered, while the Spell check section cannot.
SGTM

Comment 8 Deleted

screenshot of proposed patch attached
spellcheck.png
104 KB View Download
Looks good!
LGTM. Thanks! 
Labels: Hotlist-MD-Settings-Languages
so, WebUI doesn't have great tools for translating plurals

we're using 4 string formats:

* "Lang1"
* "Lang1, Lang2"
* "Lang1, Lang2, and 1 other"
* "Lang1, Lang2, and N others"

It's not terrible, but it will be awkward in some languages which have different pluralities (e.g., a different suffix for "2 others" vs. "3 others").


jungshik suggested:

* "Lang1"     
* "Lang1 and Lang2"
* "Lang1, Lang2, ...  (total: N)"

IMO that's more awkward in general, but would be easier to get right for languages with different plural numbers.
@michaelpg, is this done?
I'd honestly be fine with just indicating that there are more, eg:
- "Lang1, Lang2, ..."
- "Includes Lang1, Lang2, Lang3"
- "Lang1, Lang2, and others"
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 8872.18.0, 55.0.2883.20

Spell check shows entries in  "Lang1, Lang2, and N others" format
Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck

Sign in to add a comment