MD Settings: Secondary text for multilingual spellcheck section |
|||||||
Issue descriptionThe Spell check part of the Languages section is initially collapsed, so the secondary text should give a summary: ---------------------------------- | _Spell check_ v | | =secondary=text=here= | ---------------------------------- When it's expanded, it should show the list of enabled languages, with toggle buttons for the ones that support spell check; the buttons are "on" for languages that are enabled for spell check. ---------------------------------- | _Spell check_ v | | =secondary=text=here | | | | [x] English (United States) | | [ ] Spanish (Latin America) | | [x] Spanish (Spain) | ---------------------------------- What should the secondary text be? The mocks assume a single-spellcheck world, but multilingual is now force-enabled. Do we: A. List all languages enabled for spellcheck, comma-separated (how should we handle overflow) B. List only one language C. ???
,
Jun 6 2016
+rouslan@ who worked on multilingual spellcheck. Rouslan, do we have any number on "average number of languages"?
,
Jun 6 2016
We never got around to measuring this number. In general it is believed that ~50% of users are multilingual. Does that help?
,
Jun 6 2016
Alan's "C" proposal in #1 seems fine to me. I don't think users can reorder their spellcheck languages, but if they have more than 2 it doesn't seem critical to show the "top" languages.
,
Jun 6 2016
In the old settings UI, the order of languages also specifies user's preferred website languages, where order matters. Does the new settings UI behave differently?
,
Jun 6 2016
There are different sections in MD Settings for "Language" and for "Spell check". My understanding is that the Language section can be reordered, while the Spell check section cannot.
,
Jun 7 2016
SGTM
,
Jun 7 2016
screenshot of proposed patch attached
,
Jun 7 2016
Looks good!
,
Jun 8 2016
LGTM. Thanks!
,
Jun 9 2016
,
Jun 13 2016
so, WebUI doesn't have great tools for translating plurals we're using 4 string formats: * "Lang1" * "Lang1, Lang2" * "Lang1, Lang2, and 1 other" * "Lang1, Lang2, and N others" It's not terrible, but it will be awkward in some languages which have different pluralities (e.g., a different suffix for "2 others" vs. "3 others"). jungshik suggested: * "Lang1" * "Lang1 and Lang2" * "Lang1, Lang2, ... (total: N)" IMO that's more awkward in general, but would be easier to get right for languages with different plural numbers.
,
Jun 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a commit 9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a Author: michaelpg <michaelpg@chromium.org> Date: Mon Jun 13 22:33:11 2016 MD Settings: Spellcheck subsection secondary text Show the enabled spellcheck languages, if any. The list is comma-separated but cut off after 2 entries per issue 617364 . Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=238202&inline=1 R=dbeam@chromium.org BUG= 617364 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2047733003 Cr-Commit-Position: refs/heads/master@{#399579} [modify] https://crrev.com/9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a/chrome/app/settings_strings.grdp [modify] https://crrev.com/9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Jun 13 2016
@michaelpg, is this done?
,
Jun 13 2016
I'd honestly be fine with just indicating that there are more, eg: - "Lang1, Lang2, ..." - "Includes Lang1, Lang2, Lang3" - "Lang1, Lang2, and others"
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a commit 9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a Author: michaelpg <michaelpg@chromium.org> Date: Mon Jun 13 22:33:11 2016 MD Settings: Spellcheck subsection secondary text Show the enabled spellcheck languages, if any. The list is comma-separated but cut off after 2 entries per issue 617364 . Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=238202&inline=1 R=dbeam@chromium.org BUG= 617364 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2047733003 Cr-Commit-Position: refs/heads/master@{#399579} [modify] https://crrev.com/9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a/chrome/app/settings_strings.grdp [modify] https://crrev.com/9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Jun 22 2016
,
Oct 20 2016
Verified on ChromeOS 8872.18.0, 55.0.2883.20 Spell check shows entries in "Lang1, Lang2, and N others" format
,
Apr 27 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bettes@chromium.org
, Jun 6 201671.6 KB
71.6 KB View Download