New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617360 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Source map is broken in DOM distiller

Project Member Reported by wychen@chromium.org, Jun 4 2016

Issue description

Version: M52

What steps will reproduce the problem?
(1) Follow https://github.com/chromium/dom-distiller#interactive-debugging
(2) Try to debug and view source in developer tool

What is the expected output?
Java source files are available.

What do you see instead?
Only JavaScript files.

It's broken by https://github.com/chromium/dom-distiller/commit/b27ab2b
 
Cc: mrobin...@igalia.com
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6bda67c0ddcc984c0f27da39b95fa018fcde652

commit b6bda67c0ddcc984c0f27da39b95fa018fcde652
Author: wychen <wychen@chromium.org>
Date: Mon Jan 09 18:11:00 2017

Roll DOM Distiller JavaScript distribution package

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/072fe57b48...aab1a1b038

Picked up changes:
aab1a1b Revert "Replace create_standalone_js.py with a custom GWT linker"
ac91168 Use stricter comment-detecting heuristics
936bafa Skip <svg> elements when scanning the DOM
315e460 Skip lead image finder when no text content

BUG= 617360 , 658113 , 676638 

Review-Url: https://codereview.chromium.org/2619253002
Cr-Commit-Position: refs/heads/master@{#442292}

[modify] https://crrev.com/b6bda67c0ddcc984c0f27da39b95fa018fcde652/DEPS
[modify] https://crrev.com/b6bda67c0ddcc984c0f27da39b95fa018fcde652/third_party/dom_distiller_js/README.chromium

Comment 3 by wychen@chromium.org, Jan 10 2017

Cc: k...@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment