New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 617324 link

Starred by 6 users
Status: Fixed
Owner:
jinsuk...@chromium.org
Closed: Jun 2018
Cc:
michaelbai@chromium.org
hanxi@chromium.org
torne@chromium.org
pkotw...@chromium.org
tedc...@chromium.org
jinsuk...@chromium.org
boliu@chromium.org
yfried...@chromium.org
█ mariakho...@chromium.org
█ ingem...@opera.com
changwan@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 620102
Blocking:
issue 617313
issue 773200



Sign in to add a comment

Android: Enforce embedder checkdeps for content-layer Java API

Project Member Reported by siev...@chromium.org, Jun 3 2016 
Currently embedders can (and Chrome does) import Java sources that are not from 'content_public' packages.

The goal here is to have some working DEPS rule in chrome/ (and android_webview etc.) that allows for only including content_public packages.

It gets complicated because java sources have a package path and a directory path. Currently all Java sources (private and public) are under content/public/android/java.

If I understand buildtools/checkdeps/java_checker.py correctly, then it converts import statements to directory paths, and then checks that path against the *directory* the class to be imported is in (and not the package name of the imported class).

That means we'd either have to change or extend checkdeps or change the current directory layout in content so that all non_public packages move out from content/public/android/java to content/android/java or so.

Comment 1 by siev...@chromium.org, Jun 3 2016

Blocking: 617313

Comment 2 by jinsuk...@chromium.org, Jun 13 2016

Status: Started (was: Assigned)
The package path 'content_public' looks odd. I think it is better to move non-public stuff to their own directory.

Comment 3 by jinsuk...@chromium.org, Jun 17 2016

Cc: changwan@chromium.org siev...@chromium.org
I'm splitting content java classes into two - public 'content_java' which is referenced by outside (like chrome_java) and 'content_internal_java' implementing inner details. Made an initial patch - all the build targets work now with the new 'content_internal_java' placed in a new directory /content/android.

Then I got confused - should content_java have dependency on content_internal_java or the other way around? i.e., with suitable rules in DEPS in place to keep chrome from including only content_java not internal one, which is right:

//content/public/android/BUILD.gn:
android_lib("content_java") {
  deps = [ "//content/android:content_internal_java" ... ]
  ...
}

or 
//content/android/BUILD.gn:
android_lib("content_internal_java") {
  deps = [ "//content/public/android:content_java" ... ]
  ...
} ?

Conceptually I think the latter is right - public is supposed to contain only "interface" exposed both to outside and internal side which uses the instantiations of the interface passed to it to construct inner workings. But I'm not certain if content_java can really be a collection of interfaces and such distinction is applicable. My initial patch is taking the former approach. 

Penny for your thoughts?

Comment 4 by jinsuk...@chromium.org, Jun 17 2016

Cc: jinsuk...@chromium.org
 Issue 602503  has been merged into this issue.

Comment 5 by changwan@chromium.org, Jun 17 2016 

People will be more conscious about 'where' to put the impl files and where to put public files, but this does not technically stop people from importing impl classes  because indirect dependency has been created. For some cases we may define those impl files as package-private, but that is a separate issue.

In order to mandate the separation better, could we extend 'gn check' to Java libraries as well?

https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/check.md#Visibility

Comment 6 by changwan@chromium.org, Jun 17 2016 

Please disregard comment #5. As mentioned in comment #0, javachecker should prevent such incorrect import from happening.

Comment 7 by changwan@chromium.org, Jun 17 2016 

Re #3, public library should not only expose interfaces, but also provide a way to instantiate the impl class.

Ideally delegation pattern can separate public and internal classes clearly:

public Foo {
  private mImpl = new FooImpl();

  public method_a() {
    mImpl.method_a();
  }
}

public FooImpl {
  public method_a() {
    ...
  }
}

This way, internal will only be referenced by public.
But I think it can have a negative performance and memory impact depending on how JVM optimizes it. Has anyone looked into this pattern and its impact closely? We probably did this in many places when we had to keep upstream / downstream versions of classes.

Another idea would be to provide abstract class along with static Create() method to instantiate the impl, but this way public and internal should reference each other, which might be a bad design.

Comment 8 by aelias@chromium.org, Jun 17 2016 

> But I think it can have a negative performance and memory impact depending on how JVM optimizes it. Has anyone looked into this pattern and its impact closely?

No, but I think it's safe to assume the performance cost is negligible and only think about the best factoring.  I've found that calling overheads are almost always negligible except in cases of very heavy inner loops that are invoked at 60fps (which we can specially optimize if and when they come up in profiling).  That's been the case even for JNI hops which I'm positive are way more expensive than this pattern (JNI hops are ~1usec: https://docs.google.com/spreadsheets/d/1ulggKOZ7VQ8IytP1hKr-1wvBu70qG2qxKT4vRbHDIGw/edit#gid=0 , normal Java calls are probably a few nanosecs).  So let's not let ourselves get distracted by hypothetical perf problems.

Comment 9 by siev...@chromium.org, Jun 17 2016 

Regarding build dependencies: It probably should be the former since the external application target should depend on the public layer and that in turn then would have to depend on the internals. (Also see some comments in src/content/BUILD.gn and how that works similarly for native with more complications for the component build.)

Agreed with the goal of not having real implementation in the public layer. Also see https://www.chromium.org/developers/content-module/content-api

Regarding delegating: Why do we need to delegate to another object though instead of using subclassing?
We already have the pattern, see for example WebContents.java and WebContentsImpl.java (or NavigationControllerImpl.java).

There are multiple ways to inject the dependency from the private layer. For WebContents and NavigationController it's done by performing the instantiation into the native code in the private layer and having a public getter to retrieve the base interface through JNI.

At the same time I'm wondering about the convolution of all of this.

What's the point of this Java layer? Mostly these seem to be convenience wrappers around the JNI boundary (including potentially caching state to avoid hops).

The drawback is that we have one public layer with both a C++ and a Java API.
In practice this seems to lead to both backdoor public APIs through Java and overall makes it way harder to enforce or even just understand the boundary. (There was a long discussion in a recent code review about NavigationController related to this.)

I'm wondering if this JNI helper bridge should be a layer on top instead. Then this wouldn't all have to be split up into interface and impl and would make things overall cleaner.

The main practical reason against this that I can think of is if there is a substantial benefit from some of these Java impl classes to interact with other Java impl classes that are in the content *private* layer (rather than native classes). Or in other words if there is a lot of useful interaction between the Java implementations in the two layers (i.e. the wrapper layer I'm suggesting and the content private/impl layer).

Another way to think of it is: Is 'impl layer (content java wrapper) on top of C++ public API on top of content impl layer' better than 'content public C++ and Java API mixed on top of content impl layer'?

A cursory look at WebContentsImpl.java and NavigationController.java suggests that that is the case and these are mostly convenience wrappers (and probably exposed some private APIs in the way that should maybe be more officially exposed).
But it might be worth looking more recursively at what the dependencies are.

Comment 10 by siev...@chromium.org, Jun 17 2016

Blockedon: 620102

Comment 11 by siev...@chromium.org, Jun 17 2016 

I'm thinking we can start pragmatically by

a) Moving Java code that is only referenced internally from the content layer to the new private layer and enforce DEPS for those classes (so an embedder can't import those). This should be straightforward.

b) Cleaning up the imports from WebView/Chrome/etc. that are currently not in content_public and figuring out where they belong. I've started a list in that spirit: https://docs.google.com/a/chromium.org/spreadsheets/d/17JEvLECvckybBuvaFzxpPujjqLCSZFVJHLnpkNshsRQ/edit?usp=sharing

We can start with WebView since it has less dependencies and enforce DEPS there. Enforcing DEPS from Java content_public to Java private will be harder and maybe should be last, mainly because of ContentViewCore which spans the layers (we could also split it up into CVC and CVCImpl, but maybe we rather go and eliminate it rightaway.)


And when we are done with all of that we can revisit the Java bits that actually span the public and private layer (like WebContents) regarding the question whether this should be a layer on top of content rather than a layer adjacent to the C++ content API.

wdyat?

Comment 12 by siev...@chromium.org, Jun 23 2016

Cc: mariakho...@chromium.org pkotw...@chromium.org hanxi@chromium.org

Comment 13 by siev...@chromium.org, Jun 23 2016

Cc: torne@chromium.org michaelbai@chromium.org
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbed3229058fc046539cd20cc546a740179d1fc4

commit dbed3229058fc046539cd20cc546a740179d1fc4
Author: sievers <sievers@chromium.org>
Date: Tue Aug 02 17:29:58 2016

Android: Don't require RegisterNatives if there are none

Nowadays the calls up to Java are lazily resolved, so
RegisterNatives() actually does again what the name implies.

Allow not calling RegisterNatives() if there are no native methods
by marking it with the 'unused' attribute.

In follow-up patches all references will be removed so that the
generator can stop emiting the NOP functions where there are no
native methods.

This makes it more straightforward to design one-way JNI interfaces.

BUG= 603936 ,  617313 ,  617324 

Review-Url: https://codereview.chromium.org/2204623002
Cr-Commit-Position: refs/heads/master@{#409221}

[modify] https://crrev.com/dbed3229058fc046539cd20cc546a740179d1fc4/base/android/jni_generator/golden_sample_for_tests_jni.h
[modify] https://crrev.com/dbed3229058fc046539cd20cc546a740179d1fc4/base/android/jni_generator/jni_generator.py
[modify] https://crrev.com/dbed3229058fc046539cd20cc546a740179d1fc4/base/android/jni_generator/testCalledByNatives.golden
[modify] https://crrev.com/dbed3229058fc046539cd20cc546a740179d1fc4/base/android/jni_generator/testConstantsFromJavaP.golden
[modify] https://crrev.com/dbed3229058fc046539cd20cc546a740179d1fc4/base/android/jni_generator/testFromJavaP.golden
[modify] https://crrev.com/dbed3229058fc046539cd20cc546a740179d1fc4/base/android/jni_generator/testFromJavaPGenerics.golden
[modify] https://crrev.com/dbed3229058fc046539cd20cc546a740179d1fc4/base/android/jni_generator/testMultipleJNIAdditionalImport.golden
[modify] https://crrev.com/dbed3229058fc046539cd20cc546a740179d1fc4/base/android/jni_generator/testNativeExportsOnlyOption.golden
[modify] https://crrev.com/dbed3229058fc046539cd20cc546a740179d1fc4/base/android/jni_generator/testSingleJNIAdditionalImport.golden

Comment 15 by ingem...@opera.com, Sep 12 2016

Cc: ingem...@opera.com

Comment 16 by jinsuk...@chromium.org, Sep 29 2016

Owner: ----
Status: Available (was: Started)
Busy working on other parts of the refactoring at this moment, I'm releasing this for anyone else to take.

Comment 17 by wychen@chromium.org, Jan 11 2017

Owner: wychen@chromium.org
Status: Assigned (was: Available)

Comment 18 by jinsuk...@chromium.org, Oct 16 2017

Blocking: 773200
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/buildtools/+/3275a099f3c199b50ff97117aa0184f3e91f8a32

commit 3275a099f3c199b50ff97117aa0184f3e91f8a32
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Thu Oct 19 02:38:48 2017

Output warning only in verbose mode in Java deps checker

Like other DepsCheckers, this CL make Java DepsChecker output
warnings only in verbose mode. This is in preparation for enabling
Java deps checker in presubmit.

Bug:  617324 
Change-Id: I302de1b4a4ac78162836481f7592764ed813f9b9

[modify] https://crrev.com/3275a099f3c199b50ff97117aa0184f3e91f8a32/checkdeps/java_checker.py
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a092677c2b7c092f816903c05ef6b227ca32807

commit 5a092677c2b7c092f816903c05ef6b227ca32807
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue Oct 24 22:42:24 2017

Enforce CheckDeps on embedder Java files

Currently embedders can (and do) import Java sources that are
not from 'content_public' packages. This CL turns on java_checker.py
in presubmit script, and enforces basic DEPS rules in chrome/ (and
android_webview etc.) that allows for only including content_public
packages. This is to define content layer API boundary clearly on
Java side.

There are still exceptions allowed inevitably. But the updated rules
will still help discourage any more non-public classes from being
referenced by embedders. All the exceptions will be fixed moving forward,
and the include rules will be updated to be more intuitive by changing
the current directory layout in content so that all non_public packages
move out from content/public/android/java to somewhere else, like
content/android/java or so.

Test: python buildtools/checkdeps/checkdeps.py

Bug:  617324 
Change-Id: Ibb00fdfcd3166f502babc7f424917b8ffa6e5c94
Reviewed-on: https://chromium-review.googlesource.com/727079
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511288}
[modify] https://crrev.com/5a092677c2b7c092f816903c05ef6b227ca32807/PRESUBMIT.py
[modify] https://crrev.com/5a092677c2b7c092f816903c05ef6b227ca32807/android_webview/glue/java/DEPS
[modify] https://crrev.com/5a092677c2b7c092f816903c05ef6b227ca32807/android_webview/java/DEPS
[modify] https://crrev.com/5a092677c2b7c092f816903c05ef6b227ca32807/android_webview/javatests/DEPS
[modify] https://crrev.com/5a092677c2b7c092f816903c05ef6b227ca32807/android_webview/test/shell/DEPS
[modify] https://crrev.com/5a092677c2b7c092f816903c05ef6b227ca32807/chrome/android/java/DEPS
[modify] https://crrev.com/5a092677c2b7c092f816903c05ef6b227ca32807/chrome/android/javatests/DEPS
[modify] https://crrev.com/5a092677c2b7c092f816903c05ef6b227ca32807/chrome/android/junit/DEPS
[modify] https://crrev.com/5a092677c2b7c092f816903c05ef6b227ca32807/chrome/android/sync_shell/javatests/DEPS
[modify] https://crrev.com/5a092677c2b7c092f816903c05ef6b227ca32807/components/autofill/android/DEPS
[modify] https://crrev.com/5a092677c2b7c092f816903c05ef6b227ca32807/components/dom_distiller/content/browser/android/java/src/org/chromium/components/dom_distiller/content/DEPS
[modify] https://crrev.com/5a092677c2b7c092f816903c05ef6b227ca32807/components/gcm_driver/DEPS
[modify] https://crrev.com/5a092677c2b7c092f816903c05ef6b227ca32807/components/web_contents_delegate_android/java/DEPS

Comment 21 by jinsuk...@chromium.org, Oct 24 2017

Owner: jinsuk...@chromium.org
Status: Started (was: Assigned)

Comment 22 by jinsuk...@chromium.org, Oct 31 2017

Cc: -aelias@chromium.org -siev...@chromium.org boliu@chromium.org
Still need cleanup for embedder tests. Their DEPSes have "+content/public/test" or "+content/public/test/android/javatests" that includes non-public content test utils for android like CriteriaHelper. They also should include public content test classes only. I'll have to add more exceptions for them.

Comment 23 by boliu@chromium.org, Oct 31 2017 

a bunch of test things like CriteriaHelper should just be public, probably move those to public first before introducing stricter DEPS rules

Comment 24 by wychen@chromium.org, Oct 31 2017 

I touched CriteriaHelper recently to make it support lambda expression. One suggestion coming up during review was to move it to other layers like base. Public in content sounds like a good choice as well.

Comment 25 by jinsuk...@chromium.org, Oct 31 2017 

> a bunch of test things like CriteriaHelper should just be public, probably move those to public first before introducing stricter DEPS rules

I'll move the package path org.chromium.{content -> content_public}.test.util.* like other content classes meant to be really public.
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ee7eae13babba76712c18b8cb4727a2d42353ae

commit 1ee7eae13babba76712c18b8cb4727a2d42353ae
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Thu Nov 02 09:16:07 2017

Enforce DEPS rules for content test classes

All the content test classes should not be allowed for inclusion
by embedders since they are the details internal to content layer.
Exception is org.chromium.content.browser.test* which are meant
to be public utility classes for embedders tests. This CL
enforces DEPS rules so that only the test util classes can be
included.

Bug:  617324 
Change-Id: I9b07a3033b8167b6a3d0b21d8968b52a70185c05
Reviewed-on: https://chromium-review.googlesource.com/748341
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513434}
[modify] https://crrev.com/1ee7eae13babba76712c18b8cb4727a2d42353ae/android_webview/javatests/DEPS
[modify] https://crrev.com/1ee7eae13babba76712c18b8cb4727a2d42353ae/android_webview/tools/automated_ui_tests/DEPS
[modify] https://crrev.com/1ee7eae13babba76712c18b8cb4727a2d42353ae/android_webview/tools/system_webview_shell/page_cycler/DEPS
[modify] https://crrev.com/1ee7eae13babba76712c18b8cb4727a2d42353ae/chrome/android/javatests/DEPS
[modify] https://crrev.com/1ee7eae13babba76712c18b8cb4727a2d42353ae/chrome/android/sync_shell/javatests/DEPS
Project Member

Comment 27 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3880fc0790070701b33f2aa84930a9accc09c632

commit 3880fc0790070701b33f2aa84930a9accc09c632
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Fri Apr 27 03:00:49 2018

Android: Move webview-only classes out of content

The two classes below are used by WebView only and don't have to be in
content layer.

Bug:  617324 
Change-Id: I6962bb81dd67953711017d3ebabd74996693cb21
Reviewed-on: https://chromium-review.googlesource.com/1029756
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554275}
[modify] https://crrev.com/3880fc0790070701b33f2aa84930a9accc09c632/android_webview/BUILD.gn
[modify] https://crrev.com/3880fc0790070701b33f2aa84930a9accc09c632/android_webview/java/DEPS
[modify] https://crrev.com/3880fc0790070701b33f2aa84930a9accc09c632/android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java
[rename] https://crrev.com/3880fc0790070701b33f2aa84930a9accc09c632/android_webview/java/src/org/chromium/android_webview/PositionObserver.java
[rename] https://crrev.com/3880fc0790070701b33f2aa84930a9accc09c632/android_webview/java/src/org/chromium/android_webview/ViewPositionObserver.java
[modify] https://crrev.com/3880fc0790070701b33f2aa84930a9accc09c632/chrome/android/java/DEPS
[modify] https://crrev.com/3880fc0790070701b33f2aa84930a9accc09c632/content/public/android/BUILD.gn
Project Member

Comment 28 by bugdroid1@chromium.org, Apr 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61cc0481e46ab9647a8394f8921cfde5718d2f95

commit 61cc0481e46ab9647a8394f8921cfde5718d2f95
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Mon Apr 30 02:20:42 2018

Android: Remove DEPS exception rule for AppWebMessagePort

AppWebMessagePort is the only implementation of the interface MessagePort.
Replaced the direct reference to the class with the interface and added
a public helper method |MessagePort.createPair()|. That makes
AppWebMessagePort an implementation detail, and exposes only the public
interface to embedders. Updated DEPS rules to remove the exception.

Bug:  617324 
Change-Id: I3f35c2db2436bc3c82a00c07cfede1062d447d29
Reviewed-on: https://chromium-review.googlesource.com/1031690
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554689}
[modify] https://crrev.com/61cc0481e46ab9647a8394f8921cfde5718d2f95/android_webview/glue/java/DEPS
[modify] https://crrev.com/61cc0481e46ab9647a8394f8921cfde5718d2f95/android_webview/glue/java/src/com/android/webview/chromium/WebMessagePortAdapter.java
[modify] https://crrev.com/61cc0481e46ab9647a8394f8921cfde5718d2f95/android_webview/java/DEPS
[modify] https://crrev.com/61cc0481e46ab9647a8394f8921cfde5718d2f95/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/61cc0481e46ab9647a8394f8921cfde5718d2f95/android_webview/javatests/DEPS
[modify] https://crrev.com/61cc0481e46ab9647a8394f8921cfde5718d2f95/android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java
[modify] https://crrev.com/61cc0481e46ab9647a8394f8921cfde5718d2f95/chrome/android/java/DEPS
[modify] https://crrev.com/61cc0481e46ab9647a8394f8921cfde5718d2f95/chrome/android/java/src/org/chromium/chrome/browser/browserservices/PostMessageHandler.java
[modify] https://crrev.com/61cc0481e46ab9647a8394f8921cfde5718d2f95/content/public/android/java/src/org/chromium/content_public/browser/MessagePort.java
Project Member

Comment 29 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c43d6f29d858d00f099be6f2b49c7aa5ce881662

commit c43d6f29d858d00f099be6f2b49c7aa5ce881662
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue May 01 02:05:40 2018

Android: Turned ContentViewStatics to an interface

ContentViewStatics is a collection of static methods.
Made this an interface, and moved the implementation
to ContentViewStaticsImpl that is hidden from embedders.

Bug:  617324 
Change-Id: Ic4a1fe2be24ce998995b36f6f13e14c5ccc5b821
Reviewed-on: https://chromium-review.googlesource.com/1034420
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554970}
[modify] https://crrev.com/c43d6f29d858d00f099be6f2b49c7aa5ce881662/android_webview/java/DEPS
[modify] https://crrev.com/c43d6f29d858d00f099be6f2b49c7aa5ce881662/android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java
[modify] https://crrev.com/c43d6f29d858d00f099be6f2b49c7aa5ce881662/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/c43d6f29d858d00f099be6f2b49c7aa5ce881662/android_webview/javatests/DEPS
[modify] https://crrev.com/c43d6f29d858d00f099be6f2b49c7aa5ce881662/android_webview/javatests/src/org/chromium/android_webview/test/ContentViewMiscTest.java
[modify] https://crrev.com/c43d6f29d858d00f099be6f2b49c7aa5ce881662/content/browser/android/content_view_statics.cc
[modify] https://crrev.com/c43d6f29d858d00f099be6f2b49c7aa5ce881662/content/public/android/BUILD.gn
[rename] https://crrev.com/c43d6f29d858d00f099be6f2b49c7aa5ce881662/content/public/android/java/src/org/chromium/content/browser/ContentViewStaticsImpl.java
[copy] https://crrev.com/c43d6f29d858d00f099be6f2b49c7aa5ce881662/content/public/android/java/src/org/chromium/content_public/browser/ContentViewStatics.java
Project Member

Comment 30 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/129345b66af261a602e75d857f927225eefa5a70

commit 129345b66af261a602e75d857f927225eefa5a70
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue May 01 02:48:52 2018

Android: Delete obsolete DEPS exception rules

Some classes got deleted or refactored over time but their DEPS
exception rules were not updated accordingly. This CL deletes
the rules that are not necessary any more.

Bug:  617324 
Change-Id: Ide43c2748a73dec4fd3e95d3ff669f073811fd48
Reviewed-on: https://chromium-review.googlesource.com/1034422
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554979}
[modify] https://crrev.com/129345b66af261a602e75d857f927225eefa5a70/android_webview/test/shell/DEPS
[modify] https://crrev.com/129345b66af261a602e75d857f927225eefa5a70/chrome/android/java/DEPS
Project Member

Comment 31 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/495ab86e02ea1bc3a46ca5c66ab059a43ac532a2

commit 495ab86e02ea1bc3a46ca5c66ab059a43ac532a2
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue May 01 22:29:13 2018

Android: Remove DEPS exception rule for RenderFrameHostImpl

Adding one method |isIncognito| to the interface RenderFrameHost
makes it possible to avoid exposing impl class RenderFrameHostImpl
to embedders. This CL does that and replaces the reference
to the impl with the interface.

Bug:  617324 
Change-Id: I815bbea06554eae470cf3dee83dbb90e06e9d3c9
Reviewed-on: https://chromium-review.googlesource.com/1034427
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555201}
[modify] https://crrev.com/495ab86e02ea1bc3a46ca5c66ab059a43ac532a2/chrome/android/java/DEPS
[modify] https://crrev.com/495ab86e02ea1bc3a46ca5c66ab059a43ac532a2/chrome/android/java/src/org/chromium/chrome/browser/installedapp/InstalledAppProviderFactory.java
[modify] https://crrev.com/495ab86e02ea1bc3a46ca5c66ab059a43ac532a2/content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java
[modify] https://crrev.com/495ab86e02ea1bc3a46ca5c66ab059a43ac532a2/content/public/android/java/src/org/chromium/content_public/browser/RenderFrameHost.java
[modify] https://crrev.com/495ab86e02ea1bc3a46ca5c66ab059a43ac532a2/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockRenderFrameHost.java
Project Member

Comment 32 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5534d8ff2ab7503c89ddd5f671c4497fd72ef81

commit f5534d8ff2ab7503c89ddd5f671c4497fd72ef81
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue May 08 02:59:07 2018

Android: Remove DEPS exception for ChromiumBaseInputConnection

Added a test method in ImeAdapter to avoid exposing an impl-detail class
ChromiumBaseInputConnection to embedder.

Bug:  617324 
Change-Id: Ie0f3a4e6db3b161deb00731a52767d9d10273bfb
Reviewed-on: https://chromium-review.googlesource.com/1034424
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556659}
[modify] https://crrev.com/f5534d8ff2ab7503c89ddd5f671c4497fd72ef81/chrome/android/javatests/DEPS
[modify] https://crrev.com/f5534d8ff2ab7503c89ddd5f671c4497fd72ef81/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
[modify] https://crrev.com/f5534d8ff2ab7503c89ddd5f671c4497fd72ef81/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapterImpl.java
[modify] https://crrev.com/f5534d8ff2ab7503c89ddd5f671c4497fd72ef81/content/public/android/java/src/org/chromium/content_public/browser/ImeAdapter.java
Project Member

Comment 33 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0

commit 6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue May 08 13:06:01 2018

Android: Moves InterstitialPageDelegateAndroid to test

Java class InterstitialPageDelegateAndroid and its native class are
used by content/chrome test only. This CL moves the classes to
content/test/android. For this, content shell test apk is configured
to have a native library of target name content_native_test_support.

Bug:  617324 
Change-Id: I81b757fe636e96139f61dce781d14fe55da341dd
Reviewed-on: https://chromium-review.googlesource.com/1039305
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556773}
[modify] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/chrome/android/BUILD.gn
[modify] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/chrome/android/javatests/DEPS
[modify] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java
[modify] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/browser/BUILD.gn
[modify] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/public/android/BUILD.gn
[modify] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
[modify] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
[modify] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/public/test/android/BUILD.gn
[rename] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/public/test/android/interstitial_page_delegate_android.cc
[rename] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/public/test/android/interstitial_page_delegate_android.h
[rename] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/public/test/android/javatests/src/org/chromium/content/browser/test/InterstitialPageDelegateAndroid.java
[modify] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockWebContents.java
[modify] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/shell/android/BUILD.gn
[add] https://crrev.com/6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0/content/shell/android/shell_test_library_loader.cc
Project Member

Comment 34 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4b7fec80296a5e142fd99503ae8715ad7589ba0

commit a4b7fec80296a5e142fd99503ae8715ad7589ba0
Author: agrieve <agrieve@chromium.org>
Date: Wed May 09 03:01:12 2018

Revert "Android: Moves InterstitialPageDelegateAndroid to test"

This reverts commit 6235a6562a0fb9fadb32592eb8ef8c1dd4df5fc0.

Reason for revert: Broke chrome_public_test_apk on kitkat
https://ci.chromium.org/buildbot/chromium.android/KitKat%20Phone%20Tester%20%28dbg%29/6066

Original change's description:
> Android: Moves InterstitialPageDelegateAndroid to test
> 
> Java class InterstitialPageDelegateAndroid and its native class are
> used by content/chrome test only. This CL moves the classes to
> content/test/android. For this, content shell test apk is configured
> to have a native library of target name content_native_test_support.
> 
> Bug:  617324 
> Change-Id: I81b757fe636e96139f61dce781d14fe55da341dd
> Reviewed-on: https://chromium-review.googlesource.com/1039305
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556773}

TBR=boliu@chromium.org,tedchoc@chromium.org,jinsukkim@chromium.org

Change-Id: If4d3c02b32b0887f6be6981dd5e8ea14af759ced
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  617324 , 840974
Reviewed-on: https://chromium-review.googlesource.com/1051036
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557072}
[modify] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/chrome/android/BUILD.gn
[modify] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/chrome/android/javatests/DEPS
[modify] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java
[modify] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/content/browser/BUILD.gn
[rename] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/content/browser/android/interstitial_page_delegate_android.cc
[rename] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/content/browser/android/interstitial_page_delegate_android.h
[modify] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/content/public/android/BUILD.gn
[rename] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/content/public/android/java/src/org/chromium/content/browser/InterstitialPageDelegateAndroid.java
[modify] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
[modify] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
[modify] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/content/public/test/android/BUILD.gn
[modify] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockWebContents.java
[modify] https://crrev.com/a4b7fec80296a5e142fd99503ae8715ad7589ba0/content/shell/android/BUILD.gn
[delete] https://crrev.com/9fa1ead4d5729778579732623623cf8a1a9a847d/content/shell/android/shell_test_library_loader.cc
Project Member

Comment 35 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e17369bbb8761ba7839f74dfc15660141626445d

commit e17369bbb8761ba7839f74dfc15660141626445d
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Thu May 10 23:30:24 2018

Android: Makes ContentVideoView a public interface

Turns ContentVideoView/ContentVideoViewEmbedder public interfaces,
and removes the corresponding DEPS exceptions.

Bug:  617324 
Change-Id: I2e1fdd5b48e6a11e204c3d145458a58561dc0fb8
Reviewed-on: https://chromium-review.googlesource.com/1043305
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557722}
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/android_webview/java/DEPS
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/android_webview/java/src/org/chromium/android_webview/AwContentVideoViewEmbedder.java
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/android_webview/javatests/DEPS
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/android_webview/javatests/src/org/chromium/android_webview/test/util/VideoSurfaceViewUtils.java
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/chrome/android/java/DEPS
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsSurfaceHelper.java
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/chromecast/browser/android/junit/src/org/chromium/chromecast/shell/CastWebContentsSurfaceHelperTest.java
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/components/web_contents_delegate_android/java/DEPS
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/content/browser/android/content_video_view.cc
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/content/public/android/BUILD.gn
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewEmbedder.java
[rename] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewImpl.java
[add] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/content/public/android/java/src/org/chromium/content_public/browser/ContentVideoView.java
[rename] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/content/public/android/java/src/org/chromium/content_public/browser/ContentVideoViewEmbedder.java
[modify] https://crrev.com/e17369bbb8761ba7839f74dfc15660141626445d/content/shell/android/java/src/org/chromium/content_shell/Shell.java
Project Member

Comment 36 by bugdroid1@chromium.org, May 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c640fca37b644e7950495cf72811dc75984c0fe

commit 9c640fca37b644e7950495cf72811dc75984c0fe
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Sun May 13 01:05:51 2018

Android: Move cipher lib to Chrome

ByteArrayGenerator, CipherFactory are used by Chrome only, and
don't have to be in content layer. This CL moves it to chrome
directory, and deletes the corresponding DEPS exception rules.

Bug:  617324 
Change-Id: Iee5d8effe2148ef3e50375e8848048a58a0cc046
Reviewed-on: https://chromium-review.googlesource.com/1049769
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558149}
[modify] https://crrev.com/9c640fca37b644e7950495cf72811dc75984c0fe/chrome/android/java/DEPS
[modify] https://crrev.com/9c640fca37b644e7950495cf72811dc75984c0fe/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/9c640fca37b644e7950495cf72811dc75984c0fe/chrome/android/java/src/org/chromium/chrome/browser/TabState.java
[modify] https://crrev.com/9c640fca37b644e7950495cf72811dc75984c0fe/chrome/android/java/src/org/chromium/chrome/browser/cookies/CookiesFetcher.java
[rename] https://crrev.com/9c640fca37b644e7950495cf72811dc75984c0fe/chrome/android/java/src/org/chromium/chrome/browser/crypto/ByteArrayGenerator.java
[rename] https://crrev.com/9c640fca37b644e7950495cf72811dc75984c0fe/chrome/android/java/src/org/chromium/chrome/browser/crypto/CipherFactory.java
[rename] https://crrev.com/9c640fca37b644e7950495cf72811dc75984c0fe/chrome/android/java/src/org/chromium/chrome/browser/crypto/OWNERS
[modify] https://crrev.com/9c640fca37b644e7950495cf72811dc75984c0fe/chrome/android/java/src/org/chromium/chrome/browser/installedapp/PackageHash.java
[modify] https://crrev.com/9c640fca37b644e7950495cf72811dc75984c0fe/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/9c640fca37b644e7950495cf72811dc75984c0fe/chrome/android/java_sources.gni
[rename] https://crrev.com/9c640fca37b644e7950495cf72811dc75984c0fe/chrome/android/javatests/src/org/chromium/chrome/browser/crypto/CipherFactoryTest.java
[copy] https://crrev.com/9c640fca37b644e7950495cf72811dc75984c0fe/chrome/android/javatests/src/org/chromium/chrome/browser/crypto/OWNERS
[modify] https://crrev.com/9c640fca37b644e7950495cf72811dc75984c0fe/content/public/android/BUILD.gn
[delete] https://crrev.com/63b87fb096cb857236ae1918dfd8415016f0d3e5/content/public/android/javatests/src/org/chromium/content/browser/crypto/OWNERS
Project Member

Comment 37 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb

commit 7ff0db5ce04a795c9aa2daf52340ff5a64b569fb
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Wed May 16 03:03:05 2018

Reland "Android: Moves InterstitialPageDelegateAndroid to test"

The new dependency content_java_test_support added to
chrome_public_apk_for_test inadvertently pushed
BaseChromiumAndroidJUnitRunner to secondary dex, which
made some buildbots fail to work. This CL relands the culprit
CL after annotating the class with @MainDex to make it stay
in the main dex.

Locally tested with Nexus 5 with the build version KTU84P.

TBR=boliu@chromium.org,tedchoc@chromium.org

Bug:  617324 

This reverts commit a4b7fec80296a5e142fd99503ae8715ad7589ba0.

Change-Id: I483fa72dd7fa76a73fc2d9994243102cb06c6a46
Reviewed-on: https://chromium-review.googlesource.com/1053046
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558949}
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/base/test/android/javatests/src/org/chromium/base/test/BaseChromiumAndroidJUnitRunner.java
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/chrome/android/BUILD.gn
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/chrome/android/javatests/DEPS
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/browser/BUILD.gn
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/public/android/BUILD.gn
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/public/test/android/BUILD.gn
[rename] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/public/test/android/interstitial_page_delegate_android.cc
[rename] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/public/test/android/interstitial_page_delegate_android.h
[rename] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/public/test/android/javatests/src/org/chromium/content/browser/test/InterstitialPageDelegateAndroid.java
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockWebContents.java
[modify] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/shell/android/BUILD.gn
[add] https://crrev.com/7ff0db5ce04a795c9aa2daf52340ff5a64b569fb/content/shell/android/shell_test_library_loader.cc
Project Member

Comment 38 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/172b2faf3eca98c967015e5d40d27d00142fc752

commit 172b2faf3eca98c967015e5d40d27d00142fc752
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Wed May 16 04:46:59 2018

Android: SpeechRecognition interface

Split SpeechRecognition into an interface and an implementation,
and move the interface to content public. Deletes the corresponding
DEPS exception.

Bug:  617324 
Change-Id: I85c63e24f0a066d4e24f7b211afa4a9142654be2
Reviewed-on: https://chromium-review.googlesource.com/1056771
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558976}
[modify] https://crrev.com/172b2faf3eca98c967015e5d40d27d00142fc752/chrome/android/java/DEPS
[modify] https://crrev.com/172b2faf3eca98c967015e5d40d27d00142fc752/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
[modify] https://crrev.com/172b2faf3eca98c967015e5d40d27d00142fc752/content/browser/speech/speech_recognizer_impl_android.cc
[modify] https://crrev.com/172b2faf3eca98c967015e5d40d27d00142fc752/content/public/android/BUILD.gn
[rename] https://crrev.com/172b2faf3eca98c967015e5d40d27d00142fc752/content/public/android/java/src/org/chromium/content/browser/SpeechRecognitionImpl.java
[add] https://crrev.com/172b2faf3eca98c967015e5d40d27d00142fc752/content/public/android/java/src/org/chromium/content_public/browser/SpeechRecognition.java
Project Member

Comment 39 by bugdroid1@chromium.org, May 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb7e0c83c459192d1b8b5915eb9040fe3715443e

commit eb7e0c83c459192d1b8b5915eb9040fe3715443e
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Thu May 17 02:02:12 2018

Android: Remove DEPS exception for BindingManager

BindingManager.java is not in use by the target defined in Chrome
build any more. This CL removes the corresponding DEPS exception rule.

Bug:  617324 
Change-Id: I1c0a35d6f950d237b72b33c2dad69847d5bfc50c
Reviewed-on: https://chromium-review.googlesource.com/1060719
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559394}
[modify] https://crrev.com/eb7e0c83c459192d1b8b5915eb9040fe3715443e/chrome/android/javatests/DEPS
Project Member

Comment 40 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f433b85611a169358e24db492b711eb31db0398

commit 1f433b85611a169358e24db492b711eb31db0398
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Fri May 18 04:08:10 2018

Android: Makes static method classes public

Following classes are collection of static methods. Moved the declaration
to content_public, and left implementation in content.

 - ContentSwitches
 - DeviceUtils
 - LGEmailActionModeWorkaround

Bug:  617324 
Change-Id: I209ff2c0e54cdc36d525db5349bdf9e9bebfdc35
Reviewed-on: https://chromium-review.googlesource.com/1055139
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559796}
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/android_webview/glue/java/DEPS
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/android_webview/javatests/DEPS
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/android_webview/javatests/src/org/chromium/android_webview/test/ConsoleMessagesForBlockedLoadsTest.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/java/DEPS
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/java/src/org/chromium/chrome/browser/ApplicationInitialization.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/javatests/DEPS
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/javatests/src/org/chromium/chrome/browser/page_info/PageInfoControllerTest.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappNavigationTest.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chrome/android/javatests/src/org/chromium/chrome/browser/webauth/AuthenticatorTest.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastBrowserHelper.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/content/public/android/BUILD.gn
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/content/public/android/java/src/org/chromium/content/app/ContentChildProcessServiceDelegate.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java
[rename] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/content/public/android/java/src/org/chromium/content/browser/DeviceUtilsImpl.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/content/public/android/java/src/org/chromium/content/browser/selection/FloatingPastePopupMenu.java
[rename] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/content/public/android/java/src/org/chromium/content/browser/selection/LGEmailActionModeWorkaroundImpl.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java
[add] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/content/public/android/java/src/org/chromium/content/common/ContentSwitchUtils.java
[copy] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/content/public/android/java/src/org/chromium/content_public/browser/DeviceUtils.java
[add] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/content/public/android/java/src/org/chromium/content_public/browser/LGEmailActionModeWorkaround.java
[rename] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/content/public/android/java/src/org/chromium/content_public/common/ContentSwitches.java
[modify] https://crrev.com/1f433b85611a169358e24db492b711eb31db0398/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java
Project Member

Comment 41 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e46dbb1f8afa9388ddef2e5cb19c073aa3bb813d

commit e46dbb1f8afa9388ddef2e5cb19c073aa3bb813d
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Thu May 24 02:19:46 2018

Android: Make MotionEventSynthesizer a public interface

MotionEventSynthesizer class is used by Chrome (VR) and content
internally. This CL splits it into public interface with create
method and implementation class. Helps remove the exception rule
in DEPS.

Bug:  617324 
Change-Id: I99fa8c01089ede078a7c2b2929897fdbbd7b40aa
Reviewed-on: https://chromium-review.googlesource.com/1058873
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561360}
[modify] https://crrev.com/e46dbb1f8afa9388ddef2e5cb19c073aa3bb813d/chrome/android/java/DEPS
[modify] https://crrev.com/e46dbb1f8afa9388ddef2e5cb19c073aa3bb813d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/AndroidUiGestureTarget.java
[modify] https://crrev.com/e46dbb1f8afa9388ddef2e5cb19c073aa3bb813d/content/public/android/BUILD.gn
[rename] https://crrev.com/e46dbb1f8afa9388ddef2e5cb19c073aa3bb813d/content/public/android/java/src/org/chromium/content/browser/MotionEventSynthesizerImpl.java
[modify] https://crrev.com/e46dbb1f8afa9388ddef2e5cb19c073aa3bb813d/content/public/android/java/src/org/chromium/content/browser/SyntheticGestureTarget.java
[add] https://crrev.com/e46dbb1f8afa9388ddef2e5cb19c073aa3bb813d/content/public/android/java/src/org/chromium/content_public/browser/MotionEventSynthesizer.java
Project Member

Comment 42 by bugdroid1@chromium.org, May 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c53794796ad5d80369751a166a060bfe921c3b07

commit c53794796ad5d80369751a166a060bfe921c3b07
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Sat May 26 11:38:49 2018

Android: Makes ScreenOrientationProvider public

Moves ScreenOrientationProvider to content_public, and removes
the corresponding DEPS exception rule.
ScreenOrientationProviderManager was merged to ScreenOrientationProvider
as it doesn't have to be a stand-alone manager class.

Bug:  617324 
Change-Id: Iaf721713e15a145de731a50f295c5b1efb76235e
Reviewed-on: https://chromium-review.googlesource.com/1071129
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562124}
[modify] https://crrev.com/c53794796ad5d80369751a166a060bfe921c3b07/chrome/android/java/DEPS
[modify] https://crrev.com/c53794796ad5d80369751a166a060bfe921c3b07/chrome/android/java/src/org/chromium/chrome/browser/FullscreenActivity.java
[modify] https://crrev.com/c53794796ad5d80369751a166a060bfe921c3b07/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/c53794796ad5d80369751a166a060bfe921c3b07/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/c53794796ad5d80369751a166a060bfe921c3b07/content/browser/screen_orientation/screen_orientation_delegate_android.cc
[modify] https://crrev.com/c53794796ad5d80369751a166a060bfe921c3b07/content/public/android/BUILD.gn
[rename] https://crrev.com/c53794796ad5d80369751a166a060bfe921c3b07/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProviderImpl.java
[delete] https://crrev.com/71dba344e19bf7855c3fc3cd11e08b8ad666f204/content/public/android/java/src/org/chromium/content_public/browser/ScreenOrientationDelegateManager.java
[add] https://crrev.com/c53794796ad5d80369751a166a060bfe921c3b07/content/public/android/java/src/org/chromium/content_public/browser/ScreenOrientationProvider.java
[modify] https://crrev.com/c53794796ad5d80369751a166a060bfe921c3b07/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java
Project Member

Comment 43 by bugdroid1@chromium.org, May 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d

commit 796efeafdd23c1425afbfa35e79bcd7ef06e6e6d
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Sun May 27 01:41:55 2018

Android: BrowserStartupController public interface

Turns BrowserStartupController to a public interface and moves to
content_public. Deletes the corresponding DEPS exception rules.

Previously @mocked BrowserStartupController doesn't need mocking
any more since it is now a pure interface. Used
TestBrowserStartupController extending BrowserStartupController
for testing.

Bug:  617324 
Change-Id: I1687b3ce3bde2b6e3765513115d48cfa5c99de6c
Reviewed-on: https://chromium-review.googlesource.com/1056754
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562138}
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/android_webview/java/DEPS
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/DEPS
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/DefaultBrowserInfo.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/background_task_scheduler/NativeBackgroundTask.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/browserservices/OriginVerifier.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService2.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/metrics/ActivityTabStartupMetricsTracker.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotifier.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchedPagesNotifier.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/provider/ChromeBrowserProvider.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/GcmUma.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/junit/DEPS
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chrome/android/junit/src/org/chromium/chrome/browser/background_task_scheduler/NativeBackgroundTaskTest.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastBrowserHelper.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/content/browser/android/browser_startup_controller.cc
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/content/public/android/BUILD.gn
[rename] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/content/public/android/java/src/org/chromium/content/browser/BrowserStartupControllerImpl.java
[add] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/content/public/android/java/src/org/chromium/content_public/browser/BrowserStartupController.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/content/public/android/javatests/src/org/chromium/content/browser/BrowserStartupControllerTest.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/content/public/test/android/javatests/src/org/chromium/content/browser/test/NativeLibraryTestRule.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/content/shell/android/browsertests/src/org/chromium/content_shell/browsertests/ContentShellBrowserTestActivity.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java
[modify] https://crrev.com/796efeafdd23c1425afbfa35e79bcd7ef06e6e6d/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java
Project Member

Comment 44 by bugdroid1@chromium.org, May 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06918e4e54a6b10ecb3cfcd670f0ba61958235c6

commit 06918e4e54a6b10ecb3cfcd670f0ba61958235c6
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue May 29 23:29:20 2018

Android: New component for android embedder support libs

ActivityContentVideoViewEmbedder is used by Chrome, content shell,
and chromecast as an implementation of ContentVideoViewEmbedder.
This CL moves it to a new component, and deletes the DEPS exception
rule.

The new component will be a central place hosting all the libraries
that provides typical implementations of various content interfaces.

Bug:  617324 , 843882
Change-Id: I2a06e2fbf9d92ca8c02d52358e549224c44c65bc
Reviewed-on: https://chromium-review.googlesource.com/1053856
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562651}
[modify] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/chrome/android/BUILD.gn
[modify] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/chrome/android/java/DEPS
[modify] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java
[modify] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/chromecast/browser/android/BUILD.gn
[modify] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/chromecast/browser/android/DEPS
[modify] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsSurfaceHelper.java
[add] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/components/embedder_support/android/BUILD.gn
[add] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/components/embedder_support/android/DEPS
[add] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/components/embedder_support/android/OWNERS
[add] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/components/embedder_support/android/README
[rename] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/components/embedder_support/android/java/src/org/chromium/components/embedder_support/media/ActivityContentVideoViewEmbedder.java
[modify] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/content/public/android/BUILD.gn
[modify] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/content/shell/DEPS
[modify] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/content/shell/android/BUILD.gn
[modify] https://crrev.com/06918e4e54a6b10ecb3cfcd670f0ba61958235c6/content/shell/android/java/src/org/chromium/content_shell/Shell.java
Project Member

Comment 45 by bugdroid1@chromium.org, May 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50d157ac28c3759563697c0ac4ea0caa663d05c6

commit 50d157ac28c3759563697c0ac4ea0caa663d05c6
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Wed May 30 23:53:21 2018

Android: Moves HandleViewResources to ui/resources

Moves HandleViewResources to ui/resources.
Also removes the DEPS exception rule that becomes unnecessary.

Bug:  617324 
Change-Id: Ideb9b2d858ffe8a9f5ea7f345c7a9cdd3a9c38cd
Reviewed-on: https://chromium-review.googlesource.com/1071148
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563072}
[modify] https://crrev.com/50d157ac28c3759563697c0ac4ea0caa663d05c6/android_webview/java/DEPS
[modify] https://crrev.com/50d157ac28c3759563697c0ac4ea0caa663d05c6/android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java
[modify] https://crrev.com/50d157ac28c3759563697c0ac4ea0caa663d05c6/content/browser/android/selection/composited_touch_handle_drawable.cc
[modify] https://crrev.com/50d157ac28c3759563697c0ac4ea0caa663d05c6/content/browser/android/selection/composited_touch_handle_drawable.h
[modify] https://crrev.com/50d157ac28c3759563697c0ac4ea0caa663d05c6/content/public/android/BUILD.gn
[modify] https://crrev.com/50d157ac28c3759563697c0ac4ea0caa663d05c6/ui/android/BUILD.gn
[modify] https://crrev.com/50d157ac28c3759563697c0ac4ea0caa663d05c6/ui/android/DEPS
[add] https://crrev.com/50d157ac28c3759563697c0ac4ea0caa663d05c6/ui/android/handle_view_resources.cc
[add] https://crrev.com/50d157ac28c3759563697c0ac4ea0caa663d05c6/ui/android/handle_view_resources.h
[rename] https://crrev.com/50d157ac28c3759563697c0ac4ea0caa663d05c6/ui/android/java/src/org/chromium/ui/resources/HandleViewResources.java
Project Member

Comment 46 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6292daab2727e45ce244205246564b33684faec

commit c6292daab2727e45ce244205246564b33684faec
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Thu May 31 01:25:31 2018

Android: Public interface for ChildProcessCreationParams

This CL splits class ChildProcessCreationParams into interface
definition and implementation details, and moves the definition
to content_public. Sldo removes the DEPS exception rules.

Bug:  617324 
Change-Id: I27d87fbb0258a208aafa6a932e35b21846b73261
Reviewed-on: https://chromium-review.googlesource.com/1077711
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563107}
[modify] https://crrev.com/c6292daab2727e45ce244205246564b33684faec/android_webview/java/DEPS
[modify] https://crrev.com/c6292daab2727e45ce244205246564b33684faec/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/c6292daab2727e45ce244205246564b33684faec/chrome/android/java/DEPS
[modify] https://crrev.com/c6292daab2727e45ce244205246564b33684faec/chrome/android/java/src/org/chromium/chrome/browser/MonochromeApplication.java
[modify] https://crrev.com/c6292daab2727e45ce244205246564b33684faec/content/public/android/BUILD.gn
[modify] https://crrev.com/c6292daab2727e45ce244205246564b33684faec/content/public/android/java/src/org/chromium/content/app/ContentChildProcessServiceDelegate.java
[delete] https://crrev.com/932bd30cdff88280459b267d4b10167a17e5a23e/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java
[add] https://crrev.com/c6292daab2727e45ce244205246564b33684faec/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParamsImpl.java
[modify] https://crrev.com/c6292daab2727e45ce244205246564b33684faec/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java
[add] https://crrev.com/c6292daab2727e45ce244205246564b33684faec/content/public/android/java/src/org/chromium/content_public/browser/ChildProcessCreationParams.java
[modify] https://crrev.com/c6292daab2727e45ce244205246564b33684faec/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherHelperTest.java
[modify] https://crrev.com/c6292daab2727e45ce244205246564b33684faec/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java
Project Member

Comment 47 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a5f941ab400ac2008dab51327490235fa1b6e47

commit 1a5f941ab400ac2008dab51327490235fa1b6e47
Author: Attila Uygun <auygun@opera.com>
Date: Tue Jun 05 09:58:01 2018

Android: Move ContentViewRenderView to the embedder support component

Bug:  840360 ,  617324 
Change-Id: I66a3a35d5fb8df66ee003ae1be48cbb89ba848d2
Reviewed-on: https://chromium-review.googlesource.com/1070159
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Attila Uygun <auygun@opera.com>
Cr-Commit-Position: refs/heads/master@{#564425}
[modify] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/chromecast/browser/BUILD.gn
[modify] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/chromecast/browser/android/BUILD.gn
[modify] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsView.java
[modify] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/components/embedder_support/android/BUILD.gn
[modify] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/components/embedder_support/android/DEPS
[rename] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/components/embedder_support/android/java/src/org/chromium/components/embedder_support/view/ContentViewRenderView.java
[rename] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/components/embedder_support/android/view/content_view_render_view.cc
[rename] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/components/embedder_support/android/view/content_view_render_view.h
[modify] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/content/browser/BUILD.gn
[modify] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/content/public/android/BUILD.gn
[modify] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/content/shell/BUILD.gn
[modify] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/content/shell/android/BUILD.gn
[modify] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/content/shell/android/java/src/org/chromium/content_shell/Shell.java
[modify] https://crrev.com/1a5f941ab400ac2008dab51327490235fa1b6e47/content/shell/android/java/src/org/chromium/content_shell/ShellManager.java
Project Member

Comment 48 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f32fa8c7b36a7aae48269544c84b988c0f713b20

commit f32fa8c7b36a7aae48269544c84b988c0f713b20
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue Jun 12 16:14:45 2018

Android: Public interface for ChildProcessLauncherHelper

This CL splits class ChildProcessLauncherHelper into interface definition
and implementation details, and moves the definition to content_public.
Removes DEPS exception rules.

Bug:  617324 
Change-Id: Ibf7132ba6e6818d72448fa31f3cd96f46fadc0d5
Reviewed-on: https://chromium-review.googlesource.com/1072211
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566450}
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/chrome/android/javatests/DEPS
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/content/browser/child_process_launcher_helper_android.cc
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/content/public/android/BUILD.gn
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/content/public/android/java/src/org/chromium/content/browser/BindingManager.java
[rename] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelperImpl.java
[add] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/content/public/android/java/src/org/chromium/content_public/browser/ChildProcessLauncherHelper.java
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/content/public/android/java/src/org/chromium/content_public/browser/ChildProcessUtils.java
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherHelperTest.java
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherIntegrationTest.java
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/content/public/android/javatests/src/org/chromium/content/browser/webcontents/WebContentsTest.java
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettingsHook.java
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java
[modify] https://crrev.com/f32fa8c7b36a7aae48269544c84b988c0f713b20/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestUtils.java
Project Member

Comment 49 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/726f693b9c5172da20ac8f6d3038dc43a94095f8

commit 726f693b9c5172da20ac8f6d3038dc43a94095f8
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue Jun 12 18:20:22 2018

Android: Removed unused DEPS java exception rules

ChildProcessLauncherHelper is now in content_public. This CL
removes the exception rules not necessary any more. They should
have been in https://crrev.com/c/1072211 but were left out.

Bug:  617324 
Change-Id: I4bfca26b4a94e30194d8f2327faa7eabb32dc8ba
Reviewed-on: https://chromium-review.googlesource.com/1097466
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566505}
[modify] https://crrev.com/726f693b9c5172da20ac8f6d3038dc43a94095f8/android_webview/java/DEPS
[modify] https://crrev.com/726f693b9c5172da20ac8f6d3038dc43a94095f8/chrome/android/java/DEPS

Comment 50 by jinsuk...@chromium.org, Jun 12 2018

Status: Fixed (was: Started)
All the exception got removed! Now the public interface and implementation needs separation in the direction structure, and I think it can be tracked with Issue 335690. Closing this now.
►

Sign in to add a comment