Omnibox - Search Provider Does Case-Sensitive Comparisons |
|||
Issue descriptionSearchProvider sets the allowed_to_be_default_match badly. The suggestions (both search and navsuggestions) from the server are always lower-cased. If the input is lower-cased this is fine. If the input has some upper-case letters, then suggestions that should be allowed to be default are not. This is not as big an issue as it sounds because the fallback code that kicks in if there is no default match from search provider creates the what-you-typed match and marks it as inlinable. But it's still an issue and could result in weirdness (bad suggestion orders) in some cases.
,
Jun 6 2016
Good question. I have no idea. I'd imagine they are mostly case-insensitive. Maybe there are a few like codesearch that are not. But the question is moot because, for all non-google providers (which I assume do not use suggested relevance scores): (i) a navsuggestion will never be the highest scoring suggestion (assuming query-what-you-typed is allowed to be the default match), so its allowed_to_be_default_match status doesn't matter (ii) a search suggestion will never be the highest scoring suggestion (assuming query-what-you-typed is allowed to be the default match), so its allowed_to_be_default_match status doesn't matter. (iii) query-what-you-typed will be the highest scoring suggestion. It will always be allowed to be the default match. The problem only comes with suggested relevance scores. The examples I have mean nothing ends up inlinable. Our constraint enforcement code catches this and fixes it so there is no user-visible problem. The right things happen. I only discovered it because I was running in debug mode and typing mixed-cased input and hit a dcheck in the constraint enforcement code.
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dbf846a906d594289d4a761237489f0aa7ee328 commit 9dbf846a906d594289d4a761237489f0aa7ee328 Author: mpearson <mpearson@chromium.org> Date: Thu Jun 09 00:35:05 2016 Omnibox: Don't Barf When Suggestion is Mixed-Case Equivalent to Verbatim Make anything that's case-equivalent to the user's input / query-what-you-typed be allowed to the default match. BUG= 617312 Review-Url: https://codereview.chromium.org/2045873002 Cr-Commit-Position: refs/heads/master@{#398749} [modify] https://crrev.com/9dbf846a906d594289d4a761237489f0aa7ee328/chrome/browser/autocomplete/search_provider_unittest.cc [modify] https://crrev.com/9dbf846a906d594289d4a761237489f0aa7ee328/components/omnibox/browser/base_search_provider.cc
,
Jun 9 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by pkasting@chromium.org
, Jun 4 2016