Issue 617302 link

Starred by 2 users

Issue metadata

Status:	Verified
Owner:	msw@chromium.org
Closed:	Jun 2016
Components:	UI>Shell>Wallpaper UI>Shell>WindowManager
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
mustash mash VerifyIn-53 VerifyIn-54 VerifyIn-55

Mash wallpaper picker can't be dragged

Project Member Reported by msw@chromium.org, Jun 3 2016

Issue description

Mash wallpaper picker can't be dragged

(1) Open chrome --mash
(2) Right click desktop
(3) "Set wallpaper..."
(4) Try to drag the window (from the blank top part of the frame)

Expected: You can drag the window.
Actual: You can't drag the window.

Scott pointed me at mus::Window::SetClientArea...

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8d01e3bfa7e5febe399d48709805adf1259b800

commit b8d01e3bfa7e5febe399d48709805adf1259b800
Author: msw <msw@chromium.org>
Date: Thu Jun 16 23:48:08 2016

Support app window draggable areas in mash.

Some Chrome app windows use custom frames, with draggable regions.
Support NonClientView-powered window dragging without a standard frame.

Add a new 'RemoveStandardFrame' mus window property and helper function.
Add a new EmptyDraggableNonClientFrameView for hit testing without painting.
(parallels existing behavior w/Widget::InitParams::remove_standard_frame)
(avoids painting a frame, still handles non-client events/captures/drags)

Override UpdateDraggableRegions for mash app windows to:
- Specify insets that cover all draggable regions.
- Invert the region to specify "additional client areas".

BUG= 617302 
TEST=Wallpaper picker extensions window can be dragged in mash.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2042903002
Cr-Commit-Position: refs/heads/master@{#400305}

[modify] https://crrev.com/b8d01e3bfa7e5febe399d48709805adf1259b800/ash/mus/non_client_frame_controller.cc
[modify] https://crrev.com/b8d01e3bfa7e5febe399d48709805adf1259b800/ash/mus/property_util.cc
[modify] https://crrev.com/b8d01e3bfa7e5febe399d48709805adf1259b800/ash/mus/property_util.h
[modify] https://crrev.com/b8d01e3bfa7e5febe399d48709805adf1259b800/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/b8d01e3bfa7e5febe399d48709805adf1259b800/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h
[modify] https://crrev.com/b8d01e3bfa7e5febe399d48709805adf1259b800/components/mus/public/interfaces/window_manager.mojom