New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617281 link

Starred by 8 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 368442



Sign in to add a comment

Add all weights of Roboto (other than Regular and Bold)

Project Member Reported by js...@chromium.org, Jun 3 2016

Issue description

Spun off from bug 409047

At long last,  bug 368442  was fixed a few weeks ago. We can add all the weights (instead of just 2 weights) of Roboto.  Then, we should remove some of bundled instances of Roboto in built-in extensions because they become redundant. 

Noto to myself:  https://codereview.chromium.org/607473004  added Roboto-*.ttf to CrOS builds. ( chrome/app/theme has Roboto*ttf). 
 

Comment 1 by js...@chromium.org, Jun 3 2016

Blockedon: 368442

Comment 2 by js...@chromium.org, Jun 3 2016

https://chromium-review.googlesource.com/#/c/349730/ is a CL to update Roboto and add 4 more weights. 

Comment 3 by js...@chromium.org, Jun 3 2016

Cc: uekawa@chromium.org satorux@chromium.org
A question to ARC folks:  does ARC have its own copy of Roboto fonts or rely on Roboto bundled in Chrome OS?  

If it's the former, I'll add Roboto Condensed as well. My pending CL adds only Roboto (normal width).  

Comment 4 by js...@chromium.org, Jun 4 2016

There's another place where Roboto is bundled (in woff2): See bug 609573

Comment 5 by js...@chromium.org, Jun 10 2016

Cc: dzhioev@chromium.org

Comment 6 by fukino@chromium.org, Jun 17 2016

Is the CL in #2 going to land for M53?
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2e8591061ddd1583bb45aebd9227428535d77354

commit 2e8591061ddd1583bb45aebd9227428535d77354
Author: Jungshik Shin <jshin@chromium.org>
Date: Mon May 30 05:43:55 2016

Update Roboto to 2.132 and 4 more weights

Update Roboto built for CrOS from the upstream source with
a pending upstream CL applied (
https://github.com/google/roboto/pull/187).

What's new:

 - 4 more weights (Thin, Light, Medium, Black) now that
   Chrome can support all those weights. This matches what's available
   on Android weight-wise. Width-wise, we're only including normal width
   for now (i.e. Condensed is not included).
 - A lot of bug fixes in outlines, GSUB/GPOS/GDEF (shaping, kerning,
   etc)
 - Vertical metrics in OS/2 table were changed to match the upstream
   and Android values (2146, +-555). However, hhea vertical metrics were
   not changed.  FreeType uses hhea metrics to determine the
   'normal line-height' so that there should not be a change in the UI.

Roboto bundled as reosources will be removed. See
https://codereview.chromium.org/2043883004/ for that.

BUG= chromium:617281 
TEST=No change in the UI layout with line-height: normal in CSS.

Change-Id: I05619fe39912ee9b77b3c28c9f225b9912d2b5e5
Reviewed-on: https://chromium-review.googlesource.com/349730
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/2e8591061ddd1583bb45aebd9227428535d77354/media-fonts/robotofonts/robotofonts-2.132-r1.ebuild
[rename] https://crrev.com/2e8591061ddd1583bb45aebd9227428535d77354/media-fonts/robotofonts/robotofonts-2.132.ebuild
[delete] https://crrev.com/a9b6a661314418e8b78976a0b42d5b6da0b38207/media-fonts/robotofonts/robotofonts-20150625-r1.ebuild
[modify] https://crrev.com/2e8591061ddd1583bb45aebd9227428535d77354/media-fonts/robotofonts/Manifest

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af7381ce97d6a16c617e14356b42dfa6dba39dfb

commit af7381ce97d6a16c617e14356b42dfa6dba39dfb
Author: jshin <jshin@chromium.org>
Date: Mon Jul 18 18:06:36 2016

Remove Roboto fonts from the resource bundle

This should go in after
https://chromium-review.googlesource.com/#/c/349730/ is landed.

Update install-chromeos-fonts.py to install the latest notofonts
and roboto font packages for CrOS.

R=dzhioev
BUG= 617281 
TEST=OOBE screen still use Roboto
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2043883004
Cr-Commit-Position: refs/heads/master@{#406034}

[modify] https://crrev.com/af7381ce97d6a16c617e14356b42dfa6dba39dfb/build/linux/install-chromeos-fonts.py
[delete] https://crrev.com/078a84e8624eb27e3497bf86ae905550da8acc2d/chrome/app/theme/Roboto-Bold.ttf
[delete] https://crrev.com/078a84e8624eb27e3497bf86ae905550da8acc2d/chrome/app/theme/Roboto-Light.ttf
[delete] https://crrev.com/078a84e8624eb27e3497bf86ae905550da8acc2d/chrome/app/theme/Roboto-Medium.ttf
[delete] https://crrev.com/078a84e8624eb27e3497bf86ae905550da8acc2d/chrome/app/theme/Roboto-Regular.ttf
[delete] https://crrev.com/078a84e8624eb27e3497bf86ae905550da8acc2d/chrome/app/theme/Roboto-Thin.ttf
[modify] https://crrev.com/af7381ce97d6a16c617e14356b42dfa6dba39dfb/chrome/app/theme/chrome_unscaled_resources.grd
[modify] https://crrev.com/af7381ce97d6a16c617e14356b42dfa6dba39dfb/chrome/browser/resources/chromeos/login/oobe.html
[delete] https://crrev.com/078a84e8624eb27e3497bf86ae905550da8acc2d/chrome/browser/resources/chromeos/login/roboto_font.css
[modify] https://crrev.com/af7381ce97d6a16c617e14356b42dfa6dba39dfb/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc

Comment 9 by js...@chromium.org, Jul 19 2016

Status: Fixed (was: Started)

Comment 10 by js...@chromium.org, Jul 19 2016

fukino@: sorry for the late reply. It missed M53 train. 

Comment 11 by js...@chromium.org, Jul 21 2016

Status: Started (was: Fixed)
There's one more CL (review pending) to unbundle roboot*woff2 from Chrome on CrOS because CrOS has Roboto (6 weights) at the OS level. 

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e804d6180b3bee3e5eaf55b69ccddd9d075c5ce

commit 8e804d6180b3bee3e5eaf55b69ccddd9d075c5ce
Author: jshin <jshin@chromium.org>
Date: Thu Aug 04 22:38:00 2016

Do not bundle Roboto on CrOS

Roboto (all weights) are included in CrOS. No need to bundle
them in resources.

Make roboto.css empty on CrOS.

BUG= 617281 
TEST=Roboto is still used in web UI on CrOS.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2160303003
Cr-Commit-Position: refs/heads/master@{#409920}

[modify] https://crrev.com/8e804d6180b3bee3e5eaf55b69ccddd9d075c5ce/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/8e804d6180b3bee3e5eaf55b69ccddd9d075c5ce/ui/webui/resources/css/roboto.css
[modify] https://crrev.com/8e804d6180b3bee3e5eaf55b69ccddd9d075c5ce/ui/webui/resources/webui_resources.grd

re #3 ARC's android ships its own copy of fonts. 
we were hoping to dedupe some of it but we haven't, yet.
b/24950319

Thanks, uekawa@ !

Status: Fixed (was: Started)

Comment 16 by js...@chromium.org, Aug 26 2016

Cc: odean@chromium.org js...@chromium.org dbeam@chromium.org
 Issue 569137  has been merged into this issue.
Labels: VerifyIn-54
Labels: VerifyIn-55

Comment 19 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 20 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 21 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 22 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59
Status: Verified (was: Fixed)

Sign in to add a comment