New issue
Advanced search Search tips

Issue 617278 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 616514



Sign in to add a comment

[Blimp] Do not send RESIZE message to Engine with size 0x0, and send actual size before creating tab.

Project Member Reported by haibinlu@chromium.org, Jun 3 2016

Issue description

size 0x0 is not useful to engine. 

06-01 10:17:13.425 27636 27657 V chromium: [VERBOSE1:blimp_connection.cc(65)] Sending <BlimpMessage type=TAB_CONTROL subtype=CREATE_TAB byte_size=8>
06-01 10:17:13.426 27636 27657 V chromium: [VERBOSE1:blimp_connection.cc(65)] Sending <BlimpMessage type=TAB_CONTROL subtype=SIZE size=0x0:2.23 byte_size=17>
06-01 10:17:13.427 27636 27657 V chromium: [VERBOSE1:blimp_connection.cc(65)] Sending <BlimpMessage type=NAVIGATION subtype=LOAD_URL url="http://www.google.com/" target_tab_id=0 byte_size=36>
06-01 10:17:13.427 27636 27657 V chromium: [VERBOSE1:blimp_connection.cc(65)] Sending <BlimpMessage type=TAB_CONTROL subtype=SIZE size=1080x1635:2.23 byte_size=19>
 
Blocking: 616514
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e561c56fa3158e4a52136589f46ad60f4aa0c21

commit 0e561c56fa3158e4a52136589f46ad60f4aa0c21
Author: shaktisahu <shaktisahu@chromium.org>
Date: Tue Jun 07 17:56:50 2016

Blimp: Removed sending redundant RESIZE message to engine

At the startup, the blimp client sends a RESIZE message to the engine
with size 0x0 which is not useful for the engine. Removed sending of
this message. The correct display size is sent later when the native
android view inflates to its correct size.

BUG= 617278 

Review-Url: https://codereview.chromium.org/2046453003
Cr-Commit-Position: refs/heads/master@{#398332}

[modify] https://crrev.com/0e561c56fa3158e4a52136589f46ad60f4aa0c21/blimp/client/app/android/java/src/org/chromium/blimp/session/TabControlFeature.java

Status: Fixed (was: Untriaged)
Labels: Archive-Blimp

Sign in to add a comment