New issue
Advanced search Search tips

Issue 617268 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

LayerTreeHostTilesTestPartialInvalidation.PartialRaster_MultiThread_OneCopy is flaky under Dr. Memory

Project Member Reported by reillyg@chromium.org, Jun 3 2016

Issue description

When running on the Dr. Memory bots (a tool we use to find memory errors on Windows) LayerTreeHostTilesTestPartialInvalidation.PartialRaster_MultiThread_OneCopy is failing about a quarter of the time like this:

LayerTreeHostTilesTestPartialInvalidation.PartialRaster_MultiThread_OneCopy:
[2268:5076:0603/085644:3830323:ERROR:pixel_comparator.cc(50)] Number of pixel with an error: 30000
[2268:5076:0603/085644:3830464:ERROR:pixel_comparator.cc(51)] Error Bounding Box : 0,0 200x200
[2268:5076:0603/085644:3830932:ERROR:pixel_test_utils.cc(79)] Pixels do not match!
[2268:5076:0603/085644:3830932:ERROR:pixel_test_utils.cc(80)] Actual: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAMgAAADICAYAAACtWK6eAAACG0lEQVR4nO3VsQ2AQBDEwIP+ez4aQE7/g5kKNrH22Z0d4Nd7egDcTCAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBALhmdk9PQJu5UEgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCB8FuoGirIbyCwAAAAASUVORK5CYII=
[2268:5076:0603/085644:3830932:ERROR:pixel_test_utils.cc(81)] Expected: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAMgAAADICAYAAACtWK6eAAACPElEQVR4nO3VMYpDQQwFwdHi+19ZTjcwHX0YY6pO8BQ0mnN2D/DR3+0B8M0EAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBAEAkEgEAQCQSAQBAJBIBBetwc8ZXduT+Cfmb094RE+CASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCITZPXt7xBNmfuKMn7E7tyc8wgeBIBAIAoEgEAgCgSAQCAKBIBAIAoEgEAgCgSAQCAKBIBAIAoEgEAgCgSAQCAKBIBAIAoEgEAgCgSAQCAKBIBAIAoEgEAgCgSAQCAKBIBAIAoEgEAgCgSAQCAKBIBAIAoEgEAgCgSAQCAKBIBAIAoEgEAgCgSAQCAKBMLtnb4+Ab+WDQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQHgDx/kPiJ38QF8AAAAASUVORK5CYII=
c:\b\build\slave\drm-cr\build\src\cc\test\layer_tree_pixel_test.cc(96): error: Value of: MatchesPNGFile(*result_bitmap_, ref_file_path, *pixel_comparator_)
Actual: false
Expected: true

Example run:

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/7416

 
Cc: ericrk@chromium.org vmp...@chromium.org enne@chromium.org
Did this start recently?
It looks like the first time this particular test failed was 2016-05-19. You can look at the history of the last 200 runs which goes back about a month:

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29?numbuilds=200
Hm that's well before the change to use cc::Display. The failure is us failing to do partial raster, cuz the image is flipped, so it's doing the readback at the right time, not a problem with that. But it's failing to find a texture to use in the cache maybe? Do they time out now?
Two more tests in this set have started failing with a different error:

c:\b\build\slave\drm-cr\build\src\cc\test\layer_tree_pixel_test.cc(74): error: Value of: result->HasBitmap()
  Actual: false
Expected: true

Example:

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/7567/steps/memory%20test%3A%20cc/logs/stdio
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/492654213effcab4f6d12cc093baed065ed11009

commit 492654213effcab4f6d12cc093baed065ed11009
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Jun 21 20:05:29 2016

Disable two more cc_unittests failing under Dr. Memory.

LayerTreeHostTilesTestPartialInvalidation.FullRaster_SingleThread_OneCopy
LayerTreeHostTilesTestPartialInvalidation.FullRaster_SingleThread_GpuRaster

BUG= 617268 
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/2086113002 .

Cr-Commit-Position: refs/heads/master@{#401088}

[modify] https://crrev.com/492654213effcab4f6d12cc093baed065ed11009/tools/valgrind/gtest_exclude/cc_unittests.gtest-drmemory_win32.txt

Comment 7 by danakj@chromium.org, Sep 21 2016

Cc: sunn...@chromium.org
 Issue 648860  has been merged into this issue.

Comment 8 by loyso@chromium.org, Sep 22 2016

Components: Tests>Flaky
Labels: -Pri-3 OS-Linux Pri-1
It's not Dr. Memory specific. I'm unable to run cc_unittests locally to get consistent result.
It hangs on LayerTreePixelTest::CreateCopyOutputRequest failures (see 648860).

Comment 9 by danakj@chromium.org, Sep 22 2016

Nothing is ever Dr Memory specific in cc_unittests :) It just runs very loaded and exposes flake more consistently.
Labels: M-55
Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)
ericrk@ would you please take a look?
I think sunnyps is making copy requests not be flaky anymore.
Owner: sunn...@chromium.org
sunnyps@, feel free to assign back to me if this isn't related to your copy request work.

Comment 14 by loyso@chromium.org, Sep 29 2016

Cc: loyso@chromium.org

Comment 16 by enne@chromium.org, Nov 8 2016

sunnyps: can you take a look at this flake, please?
This will be addressed by my CL here: crbug.com/2609253003

I think this was always flaky - ran into some issues with my CL as well, hopefully that fix works here too.
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc1892fc0639464d4418ccfaedfd1f95a5b947d0

commit dc1892fc0639464d4418ccfaedfd1f95a5b947d0
Author: ericrk <ericrk@chromium.org>
Date: Wed Jan 11 23:54:13 2017

Remove ForceReclaimResources

We had previously added ForceReclaimResources to BeginCommit to throttle
frame output and prevent starving the display compositor's rasterization
tasks. Unfortunately, this introduces significant overhead as well.

With the addition of the Display Scheduler, this change no longer
appears to be needed. The scheduler has independent controls for
limiting the number of pending frames, and these should be used instead
(if further tweaking is necessary).

Removing this logic does not regress the benchmarks which it was
initially added for, and seems unneeded at this point. Removing.

R=reveman@chromium.org
BUG=676852,489515, 617268 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2609253003
Cr-Commit-Position: refs/heads/master@{#443061}

[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/output/compositor_frame_sink.h
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/surfaces/direct_compositor_frame_sink.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/surfaces/direct_compositor_frame_sink.h
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/surfaces/direct_compositor_frame_sink_unittest.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/surfaces/surface.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/surfaces/surface.h
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/surfaces/surface_factory.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/surfaces/surface_factory.h
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/test/layer_tree_test.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/test/test_compositor_frame_sink.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/test/test_compositor_frame_sink.h
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/trees/layer_tree_host_pixeltest_tiles.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/content/test/layouttest_support.cc
[modify] https://crrev.com/dc1892fc0639464d4418ccfaedfd1f95a5b947d0/ui/compositor/layer_unittest.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b443521bc4bc46b4bd1537910f089fbf1578273

commit 4b443521bc4bc46b4bd1537910f089fbf1578273
Author: ericrk <ericrk@chromium.org>
Date: Fri Jan 13 22:54:24 2017

Revert of Remove ForceReclaimResources (patchset #8 id:170001 of https://codereview.chromium.org/2609253003/ )

Reason for revert:
This has introduced flakiness into TextureLayerImplWithMailboxThreadedCallback.RunMultiThread_DelegatingRenderer, will address this and re-land.

Original issue's description:
> Remove ForceReclaimResources
>
> We had previously added ForceReclaimResources to BeginCommit to throttle
> frame output and prevent starving the display compositor's rasterization
> tasks. Unfortunately, this introduces significant overhead as well.
>
> With the addition of the Display Scheduler, this change no longer
> appears to be needed. The scheduler has independent controls for
> limiting the number of pending frames, and these should be used instead
> (if further tweaking is necessary).
>
> Removing this logic does not regress the benchmarks which it was
> initially added for, and seems unneeded at this point. Removing.
>
> R=reveman@chromium.org
> BUG=676852,489515, 617268 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2609253003
> Cr-Commit-Position: refs/heads/master@{#443061}
> Committed: https://chromium.googlesource.com/chromium/src/+/dc1892fc0639464d4418ccfaedfd1f95a5b947d0

TBR=reveman@chromium.org,danakj@chromium.org,enne@chromium.org,tommi@chromium.org,brianderson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=676852,489515, 617268 ,  681093 ,  680770 

Review-Url: https://codereview.chromium.org/2633563003
Cr-Commit-Position: refs/heads/master@{#443709}

[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/output/compositor_frame_sink.h
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/direct_compositor_frame_sink.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/direct_compositor_frame_sink.h
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/direct_compositor_frame_sink_unittest.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/surface.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/surface.h
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/surface_factory.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/surface_factory.h
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/test/layer_tree_test.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/test/test_compositor_frame_sink.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/test/test_compositor_frame_sink.h
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/trees/layer_tree_host_pixeltest_tiles.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/content/test/layouttest_support.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/ui/compositor/layer_unittest.cc

Owner: ericrk@chromium.org
Status: Started (was: Assigned)
Changing owner to reflect who is working on this.
Status: Fixed (was: Started)
Marked the wrong bug on the commit, but a fix has landed here: https://codereview.chromium.org/2649043010/

Sign in to add a comment