New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 617247 link

Starred by 1 user
Status: Verified
Owner:
█ rspangler@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
dnojiri@chromium.org
█ wfrichar@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 611535



Sign in to add a comment

vboot: Add tests for futility show output

Project Member Reported by rspangler@chromium.org, Jun 3 2016 
Currently the unit tests in 'make runfutiltests' verify that 'futility show' returns a normal exit code, but they don't verify its output.

Add tests to do so.  And for the legacy vbutil_{key,keyblock,firmware} verification too.

This is needed before refactoring futility to use vboot2, to ensure the refactored program provides the same output (or that any differences in formatting are intentional).
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/05cd8ce75f97a76c4ef155734d191cd275bac231

commit 05cd8ce75f97a76c4ef155734d191cd275bac231
Author: Randall Spangler <rspangler@chromium.org>
Date: Fri Jun 03 19:09:00 2016

test: Add tests for futility show and vbutil_*

Currently, the unit tests verify a 0 exit code, but don't check the
output.  Add tests to check the output.

BUG= chromium:617247 
BRANCH=none
TEST=make runtests

Change-Id: I842046bb6f788eee05a1f2f511c6fb08df4a5379
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/349670
Reviewed-by: Daisuke Nojiri <dnojiri@google.com>

[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/show.tests_devkeys_root_key.vbprivk
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/vbutil_key.tests_devkeys_root_key.vbpubk
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/show.tests_devkeys_root_key.vbpubk
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/show.tests_futility_data_fw_gbb.bin
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/show.tests_futility_data_bios_zgb_mp.bin
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/show.tests_futility_data_kern_preamble.bin
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/vbutil_firmware.tests_futility_data_fw_vblock.bin
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/show.tests_testkeys_key_rsa2048.pem
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/vbutil_key.tests_devkeys_root_key.vbprivk
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/show.tests_devkeys_kernel.keyblock
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/show.tests_futility_data_fw_vblock.bin
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/vbutil_firmware.verify
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/show.tests_futility_data_sample.vbpubk2
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/show.tests_futility_data_bios_mario_mp.bin
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/show.tests_testkeys_key_rsa8192.pub.pem
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/vbutil_keyblock.tests_devkeys_kernel.keyblock
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/vbutil_firmware.tests_futility_data_fw.vblock
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/test_show_contents.sh
[modify] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/run_test_scripts.sh
[add] https://crrev.com/05cd8ce75f97a76c4ef155734d191cd275bac231/tests/futility/expect_output/show.tests_futility_data_sample.vbprik2

Comment 2 by rspangler@chromium.org, Jun 21 2016

Status: Fixed (was: Started)

Comment 3 by patricia@chromium.org, Jul 1 2016

Status: Verified (was: Fixed)
Bulk verified
►

Sign in to add a comment