New issue
Advanced search Search tips

Issue 617245 link

Starred by 1 user
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Jun 2016
Cc:
tbuck...@chromium.org
bettes@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[People] Add 'Manage Supervised Users' row

Project Member Reported by tommycli@chromium.org, Jun 3 2016 
This should only appear if the user actually has supervised users.

See attached mock.

It remains an open question whether or not these should be combined into a single row.
Screenshot from 2016-06-03 12:15:23.png
47.8 KB View Download

Comment 1 by tbuck...@chromium.org, Jun 7 2016

Labels: Hotlist-MD-Settings-People
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dac5631a4c6eaf4a6466972db9e609ac61347c0

commit 4dac5631a4c6eaf4a6466972db9e609ac61347c0
Author: tommycli <tommycli@chromium.org>
Date: Sat Jun 11 01:02:48 2016

Settings People Revamp: Add 'Manage Supervised Users' row

Only displays when user actually has supervised users.

BUG= 617245 , 563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2062503002
Cr-Commit-Position: refs/heads/master@{#399341}

[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/app/settings_strings.grdp
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/resources/settings/people_page/profile_info_browser_proxy.js
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/ui/webui/settings/profile_info_handler.cc
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/ui/webui/settings/profile_info_handler.h
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/test/data/webui/settings/people_page_test.js

Comment 3 by tommycli@chromium.org, Jun 14 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dac5631a4c6eaf4a6466972db9e609ac61347c0

commit 4dac5631a4c6eaf4a6466972db9e609ac61347c0
Author: tommycli <tommycli@chromium.org>
Date: Sat Jun 11 01:02:48 2016

Settings People Revamp: Add 'Manage Supervised Users' row

Only displays when user actually has supervised users.

BUG= 617245 , 563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2062503002
Cr-Commit-Position: refs/heads/master@{#399341}

[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/app/settings_strings.grdp
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/resources/settings/people_page/profile_info_browser_proxy.js
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/ui/webui/settings/profile_info_handler.cc
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/ui/webui/settings/profile_info_handler.h
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc
[modify] https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0/chrome/test/data/webui/settings/people_page_test.js
►

Sign in to add a comment