MemoryInfra: Trace config should have information about allowed dump types |
|||
Issue descriptionBackground context:go/memory-infra: memory profiling in chrome://tracing For background tracing mode any components can request a global dump with heavy mode and we might end up uploading unexpected data in field trials. To fix this the trace config should be able to tell memory-infra that only specific dump modes are allowed for the tracing session. On the other hand trace config can also include a set of category names that are allowed to trigger a dump like "v8, blinkgc", etc..
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40638de0bd1dbd66662c09b95bdd1df09ab9258c commit 40638de0bd1dbd66662c09b95bdd1df09ab9258c Author: ssid <ssid@chromium.org> Date: Wed Jun 22 19:40:31 2016 [tracing] Introduce "allowed_dump_modes" for memory dump config The "allowed_dump_modes" contains a list of dump modes that are allowed for memory dumps in the current session. This is to prevent any other components from triggering explicit dumps with unexpected details. Trace config now controls the modes allowed. If not mentioned then by default all the modes are allowed. BUG= 617208 TBR=oysteine@chromium.org Review-Url: https://codereview.chromium.org/2041583003 Cr-Commit-Position: refs/heads/master@{#401382} [modify] https://crrev.com/40638de0bd1dbd66662c09b95bdd1df09ab9258c/base/trace_event/memory_dump_manager.cc [modify] https://crrev.com/40638de0bd1dbd66662c09b95bdd1df09ab9258c/base/trace_event/memory_dump_manager.h [modify] https://crrev.com/40638de0bd1dbd66662c09b95bdd1df09ab9258c/base/trace_event/memory_dump_manager_unittest.cc [modify] https://crrev.com/40638de0bd1dbd66662c09b95bdd1df09ab9258c/base/trace_event/memory_dump_request_args.h [modify] https://crrev.com/40638de0bd1dbd66662c09b95bdd1df09ab9258c/base/trace_event/trace_config.cc [modify] https://crrev.com/40638de0bd1dbd66662c09b95bdd1df09ab9258c/base/trace_event/trace_config.h [modify] https://crrev.com/40638de0bd1dbd66662c09b95bdd1df09ab9258c/base/trace_event/trace_config_memory_test_util.h [modify] https://crrev.com/40638de0bd1dbd66662c09b95bdd1df09ab9258c/base/trace_event/trace_config_unittest.cc [modify] https://crrev.com/40638de0bd1dbd66662c09b95bdd1df09ab9258c/content/browser/devtools/protocol/tracing_handler_unittest.cc [modify] https://crrev.com/40638de0bd1dbd66662c09b95bdd1df09ab9258c/content/browser/tracing/background_tracing_manager_impl.cc
,
Jun 23 2016
,
Jan 4 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ssid@chromium.org
, Jun 3 2016