https://github.com/w3c/browser-payment-api/issues/1
To be clear, does "Assigned" mean that you're planning to work on it, but have not started yet?
I can start to work on this. My plan is finishing this and 617194 issue in this weekend. Is it okay?
ok
When you actually start work, please mark it as "Started".
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26dc6730a200dfcb8e199de41a9c594b0744a004 commit 26dc6730a200dfcb8e199de41a9c594b0744a004 Author: gogag2 <gogag2@gmail.com> Date: Thu Jun 16 21:46:43 2016 Adding support for phone and email. This change adds support for two new PaymentOptions for payer’s email and payer’s phone number[1]. [1] https://github.com/w3c/browser-payment-api/pull/174 BUG= 617195 Review-Url: https://codereview.chromium.org/2038423002 Cr-Commit-Position: refs/heads/master@{#400268} [modify] https://crrev.com/26dc6730a200dfcb8e199de41a9c594b0744a004/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/26dc6730a200dfcb8e199de41a9c594b0744a004/third_party/WebKit/Source/modules/payments/PaymentOptions.idl [modify] https://crrev.com/26dc6730a200dfcb8e199de41a9c594b0744a004/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp [modify] https://crrev.com/26dc6730a200dfcb8e199de41a9c594b0744a004/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp [modify] https://crrev.com/26dc6730a200dfcb8e199de41a9c594b0744a004/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp [modify] https://crrev.com/26dc6730a200dfcb8e199de41a9c594b0744a004/third_party/WebKit/Source/modules/payments/PaymentResponse.h [modify] https://crrev.com/26dc6730a200dfcb8e199de41a9c594b0744a004/third_party/WebKit/Source/modules/payments/PaymentResponse.idl [modify] https://crrev.com/26dc6730a200dfcb8e199de41a9c594b0744a004/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp [modify] https://crrev.com/26dc6730a200dfcb8e199de41a9c594b0744a004/third_party/WebKit/public/platform/modules/payments/payment_request.mojom
I will take care of UI in http://crrev.com/2066483010
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2a570d184fac21f7299905ee6eaaea371f857b3 commit b2a570d184fac21f7299905ee6eaaea371f857b3 Author: rouslan <rouslan@chromium.org> Date: Fri Jun 17 04:20:33 2016 Reduce redundant code in PaymentRequest::OnPaymentComplete(). BUG= 617195 Review-Url: https://codereview.chromium.org/2077663002 Cr-Commit-Position: refs/heads/master@{#400352} [modify] https://crrev.com/b2a570d184fac21f7299905ee6eaaea371f857b3/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf584c715d7973f4c206bcacee348d64c0ea34e6 commit cf584c715d7973f4c206bcacee348d64c0ea34e6 Author: rouslan <rouslan@chromium.org> Date: Sat Jun 18 23:12:39 2016 Phone and email selection UI for PaymentRequest This patch adds the user interface for the user to select their preferred contact phone number and email address. An addition, this patch passes the request for these fields from Blink to the browser. BUG= 617195 Review-Url: https://codereview.chromium.org/2066483010 Cr-Commit-Position: refs/heads/master@{#400603} [add] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java [modify] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentInformation.java [modify] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java [modify] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/android/java_sources.gni [add] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java [add] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java [add] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/test/data/android/payments/contact_details.js [modify] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/test/data/android/payments/dynamic_shipping.js [modify] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/test/data/android/payments/free_shipping.js [modify] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/test/data/android/payments/no_shipping.js [add] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/chrome/test/data/android/payments/payment_request_contact_details_test.html [modify] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp [modify] https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6/third_party/WebKit/public/platform/modules/payments/payment_request.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c669e362933a62f3a3bf3714dbb405c1dc14277 commit 6c669e362933a62f3a3bf3714dbb405c1dc14277 Author: rouslan <rouslan@chromium.org> Date: Wed Jun 22 18:15:29 2016 Edit contacts UI for PaymentRequest BUG= 617195 , 621586 Review-Url: https://codereview.chromium.org/2081533002 Cr-Commit-Position: refs/heads/master@{#401350} [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/java/res/values/ids.xml [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [add] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java [add] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorModel.java [add] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/java_sources.gni [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestAbortTest.java [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingSingleAddressTest.java [add] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java [add] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java [add] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteEmailTest.java [add] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java [add] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java [modify] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java [add] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/test/data/android/payments/email.js [add] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/test/data/android/payments/payment_request_email_test.html [add] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/test/data/android/payments/payment_request_phone_test.html [add] https://crrev.com/6c669e362933a62f3a3bf3714dbb405c1dc14277/chrome/test/data/android/payments/phone.js
Comment 1 by rouslan@chromium.org
, Jun 3 2016