Update complete() method to take a string and clarify its purpose. - https://github.com/w3c/browser-payment-api/pull/161
WIP CL: https://codereview.chromium.org/2054823002
Thank you for keeping me in the loop.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5368cdb012e5b9e64f18d9b5bdd914694a6aef94 commit 5368cdb012e5b9e64f18d9b5bdd914694a6aef94 Author: jinho.bang <jinho.bang@samsung.com> Date: Fri Jun 17 10:08:10 2016 PaymentRequest: complete() method should take PaymentComplete enum value. Related spec links [1] https://w3c.github.io/browser-payment-api/#idl-def-paymentcomplete [2] https://github.com/w3c/browser-payment-api/pull/161 BUG= 617191 Review-Url: https://codereview.chromium.org/2054823002 Cr-Commit-Position: refs/heads/master@{#400410} [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultUIManager.java [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/chrome/test/data/android/payments/dynamic_shipping.js [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/chrome/test/data/android/payments/free_shipping.js [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/chrome/test/data/android/payments/no_shipping.js [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/third_party/WebKit/Source/modules/payments/PaymentCompleter.h [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/third_party/WebKit/Source/modules/payments/PaymentRequest.h [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/third_party/WebKit/Source/modules/payments/PaymentResponse.h [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/third_party/WebKit/Source/modules/payments/PaymentResponse.idl [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp [modify] https://crrev.com/5368cdb012e5b9e64f18d9b5bdd914694a6aef94/third_party/WebKit/public/platform/modules/payments/payment_request.mojom
Comment 1 by jinho.b...@samsung.com
, Jun 3 2016