remoting_start_host binary is much larger than other CRD binaries on Windows |
|||
Issue descriptionAfter installing a private MSI, the remoting_start_host binary is ~5MB and other binaries which rely on functionality in remoting_core.dll are ~100KB. We should investigate and see if the remoting_start_host on Windows is being built correctly or if it is linking in code that is already included in remoting_code.
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0452cbe2412f985f46c12234c4bcfb6a2922b0e8 commit 0452cbe2412f985f46c12234c4bcfb6a2922b0e8 Author: joedow <joedow@chromium.org> Date: Thu Jun 09 04:44:53 2016 Updating remoting_start_host to use remoting_core.dll The remoting_start_host binary is much larger than other exes in the Windows MSI (~5MB vs. 100KB). This is because it links in a bunch of code we already include in remoting_core.dll. This change moves the shared code into remoting_core.dll and sets up the remoting_start_host binary to use a shared library for other platforms if we decide to do so later on. It also updates the information that is stamped on the windows exe so it reflects the name and purpose of the tool. BUG= 617182 Review-Url: https://codereview.chromium.org/2049173003 Cr-Commit-Position: refs/heads/master@{#398787} [modify] https://crrev.com/0452cbe2412f985f46c12234c4bcfb6a2922b0e8/remoting/host/BUILD.gn [modify] https://crrev.com/0452cbe2412f985f46c12234c4bcfb6a2922b0e8/remoting/host/predefines_win.gni [add] https://crrev.com/0452cbe2412f985f46c12234c4bcfb6a2922b0e8/remoting/host/setup/start_host_entry_point.cc [rename] https://crrev.com/0452cbe2412f985f46c12234c4bcfb6a2922b0e8/remoting/host/setup/start_host_main.cc [add] https://crrev.com/0452cbe2412f985f46c12234c4bcfb6a2922b0e8/remoting/host/setup/start_host_main.h [modify] https://crrev.com/0452cbe2412f985f46c12234c4bcfb6a2922b0e8/remoting/host/win/version.rc.jinja2 [modify] https://crrev.com/0452cbe2412f985f46c12234c4bcfb6a2922b0e8/remoting/remoting.gyp [modify] https://crrev.com/0452cbe2412f985f46c12234c4bcfb6a2922b0e8/remoting/remoting_host.gypi [modify] https://crrev.com/0452cbe2412f985f46c12234c4bcfb6a2922b0e8/remoting/remoting_host_win.gypi [modify] https://crrev.com/0452cbe2412f985f46c12234c4bcfb6a2922b0e8/remoting/resources/remoting_strings.grd
,
Jun 9 2016
,
Jun 16 2016
remoting_start_host is now 161k, so the change is in. I found no regressions when testing the host version 53.0.2767.0 |
|||
►
Sign in to add a comment |
|||
Comment 1 by joedow@chromium.org
, Jun 7 2016