New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617167 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 615102



Sign in to add a comment

Struct traits for mapping mojom::Event directly to ui::Event

Project Member Reported by moshayedi@chromium.org, Jun 3 2016

Issue description

Currently we cannot directly map mojom::Event directly to ui::Event, and instead map it to unique_ptr<ui::Event>. This is because:

1. ui::Event is polymorphic.
2. Auto-generated struct traits code by Mojo does the allocation of deserialization target before calling the deserialization target (see  crbug.com/610729 ).

Using unique_ptr<ui::Event> instead of ui::Event:

1. Makes the code a bit more complex.
2. Forces us to call ui::Event::Clone() when calling from functions working with ui::Event to functions working with unique_ptr<ui::Event>.

One way to solve this is to remove polymorphism from ui::Event as suggested in crbug.com/615102.

 
Components: Internals>MUS
Labels: Proj-Mustash
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS
Labels: -Proj-Mustash Proj-Mash

Sign in to add a comment