New issue
Advanced search Search tips

Issue 617152 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 412381



Sign in to add a comment

imported/wpt/mediacapture-streams/GUM-impossible-constraint.html failing

Project Member Reported by nzolghadr@chromium.org, Jun 3 2016

Issue description

After the latest import of web platform tests there seems to be some changes to this file that caused this fail to test in Chrome. I'm no expert in that area. Can someone else look at it?

imported/wpt/mediacapture-streams/GUM-impossible-constraint.html
 

Comment 1 by mcasas@chromium.org, Jun 20 2016

Cc: guidou@chromium.org hta@chromium.org tommi@chromium.org foolip@chromium.org
Adding some folks working on that area.

Comment 2 by hta@chromium.org, Jun 21 2016

There are changes in Chrome's constraint handling that make this fail in a different (and more interesting) way.
Seriously addressing the W3C test suite is on our Q3 OKRs, but putting the basic compatibility in place has higher priority than individual tests.
Components: -Blink>MediaStream Blink>GetUserMedia
Status: Available (was: Untriaged)
hta: do you want to set a milestone now or keep this as Available for now?

Comment 5 by hta@chromium.org, Aug 16 2016

Owner: hta@chromium.org
Let's keep it as Available - I looked briefly at the failing test, it fails at requiring +inf width, which made me wonder about the handling of +inf.
Fix should be simple once I get around to it (so assigning to me).

Comment 6 by hta@chromium.org, Aug 19 2016

Status: WontFix (was: Available)
The behavior of +inf when converted to a long is weird (it's supposed to be converted to zero). Seee https://github.com/w3c/mediacapture-main/issues/384 for details and links.

In tip-of-tree (54.0.2833), the constraint gets translated as:

{width: {min: 0}}

which is correct according to spec. So closing as "working as intended" for now, and I'll update the WPT repo instead.

Comment 7 by hta@chromium.org, Aug 22 2016

https://github.com/w3c/web-platform-tests/pull/3500 fixes the problem, and is merged.

Comment 8 by hta@chromium.org, Sep 6 2016

Status: Started (was: WontFix)
Switching back to "started" because content_shell doesn't pass the test even after the fix to WPT has ben merged.

Comment 9 by hta@chromium.org, Sep 6 2016

Owner: guidou@chromium.org
The problem is that content_shell uses blink_test_runner.cc, which has AddMediaStreamVideoSourceAndTrack, which uses MockVideoCapturerSource, which has no constraints available.

This means that no content_shell test that uses a video source will work with constraints.

Assigning to Guido, so that he can address it as part of the algorithm redesign (we have to move the constraints from the source to the track anyway).

Blocking: 412381
Status: Fixed (was: Started)
This has been fixed by changes in the constraints algorithms and by a fix of error names (see  bug  721412 ).

Sign in to add a comment