New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617142 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 327676
issue 681824



Sign in to add a comment

Implement MediaStreamTrack.getSettings

Project Member Reported by hta@chromium.org, Jun 3 2016

Issue description

Implement the getSettings method of MediaStreamTrack.

This is part of the Constrainable interface, but deserves its own bug.

 

Comment 2 by hta@chromium.org, Jun 16 2016

Blocking: -543997

Comment 3 by hta@chromium.org, Jun 21 2016

Blocking: 327676

Comment 4 by rbyers@chromium.org, Sep 15 2016

Components: Blink>WebRTC
Labels: Hotlist-Interop
In ever other major browser: Hotlist-Interop

Comment 5 by hta@chromium.org, Jan 17 2017

Blocking: 681824

Comment 6 by guidou@chromium.org, Jan 19 2017

Cc: jansson@chromium.org hta@chromium.org guidou@chromium.org tommi@chromium.org tommyw@chromium.org
 Issue 338509  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 20 2017

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 31 2017

Labels: merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/786385548e85c79e9cbbeac3ac79d1837a49e326

commit 786385548e85c79e9cbbeac3ac79d1837a49e326
Author: Wu-Cheng Li <wuchengli@google.com>
Date: Tue Jan 31 02:55:19 2017

Add FacingMode to the values returned from MediaStreamTrack.getSettings.

Spec link:

https://w3c.github.io/mediacapture-main/getusermedia.html#dom-mediatracksettings-facingmode

Note on testing: Testing this properly at the JS API level requires the ability to insert fake devices with properties set by the test. That's too much for this CL.

Once https://codereview.chromium.org/2609863004/ lands, this can be manually tested on Chromebooks.

BUG= 617142 

Review-Url: https://codereview.chromium.org/2590193002
Cr-Commit-Position: refs/heads/master@{#445022}
(cherry picked from commit 2d50a1b3b003d4a51a8f2ff4153d29a0273586eb)

Review-Url: https://codereview.chromium.org/2663143002 .
Cr-Commit-Position: refs/branch-heads/2987@{#211}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/786385548e85c79e9cbbeac3ac79d1837a49e326/content/renderer/media/media_stream_video_track.cc
[modify] https://crrev.com/786385548e85c79e9cbbeac3ac79d1837a49e326/content/renderer/media/media_stream_video_track_unittest.cc
[modify] https://crrev.com/786385548e85c79e9cbbeac3ac79d1837a49e326/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getSettings.html
[modify] https://crrev.com/786385548e85c79e9cbbeac3ac79d1837a49e326/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/786385548e85c79e9cbbeac3ac79d1837a49e326/third_party/WebKit/public/platform/WebMediaStreamTrack.h

Comment 10 by hta@chromium.org, Mar 15 2017

Status: Fixed (was: Started)

Sign in to add a comment