New issue
Advanced search Search tips

Issue 617134 link

Starred by 1 user
Status: Fixed
Owner:
sdefresne@chromium.org
Closed: Jun 2016
Cc:
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

GN: Chrome on iOS needs to use tweak_info_plist

Project Member Reported by sdefresne@chromium.org, Jun 3 2016 
This is used with gyp, so needs to be supported with gn too.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0ab61670fb9d7826de41e313004a0e4d0379da6

commit e0ab61670fb9d7826de41e313004a0e4d0379da6
Author: sdefresne <sdefresne@chromium.org>
Date: Fri Jun 03 16:38:28 2016

[iOS/GN] Add support for info_plist_target to ios_info_plist.

Chrome on iOS needs to use tweak_info_plist, so port support
for info_plist_target from mac_info_plist to ios_info_plist.

BUG= 617134 

Review-Url: https://codereview.chromium.org/2033403003
Cr-Commit-Position: refs/heads/master@{#397727}

[modify] https://crrev.com/e0ab61670fb9d7826de41e313004a0e4d0379da6/build/config/ios/rules.gni
[modify] https://crrev.com/e0ab61670fb9d7826de41e313004a0e4d0379da6/build/config/mac/rules.gni
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 4 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/1691696c75209f52c8efaa9103d3446379dd0f5c

commit 1691696c75209f52c8efaa9103d3446379dd0f5c
Author: sdefresne <sdefresne@google.com>
Date: Sat Jun 04 12:49:02 2016

Comment 3 by sdefresne@chromium.org, Jun 4 2016

Status: Fixed (was: Started)
►

Sign in to add a comment