New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617122 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Calendar clock' app does not launch.

Reported by lpa...@etouch.net, Jun 3 2016

Issue description

Chrome Version: 53.0.2757.0 (Official Build) 31724d2879923fbf1adab8cd8d6a353a9888379a-refs/heads/master@{#397573} 32-64-bit.
OS: Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(Ubuntu 14.04 LTS).
URL: https://chrome.google.com/webstore/detail/calendar-clock/galgfocamdohgeifjlbefkfpaalankfi?utm_source=chrome-ntp-icon

Steps:
1. Launch chrome and navigate to above url.
2. 'Add to chrome' and launch the app, observe.

Actual: Calendar clock app does not launch.

Expected: Calendar clock app should launch.

This is a regression issue broken in M-53.

Manual Regression Range:
Good Build: 52.0.2743.19
Bad Build: 53.0.2745.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/6868e2b9440a4d4000b8bfa7e8399ac340c35891..495f126aa1c0f77e8b5a99fc0ea741501404ae7a?pretty=fuller&n=50

Suspecting: r395245 ?

Please re-assign if your change is not the cause of this issue.
 
Actual.mp4
128 KB Download
Expected.mp4
106 KB Download
Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression.
Owner: ----
Status: Untriaged (was: Assigned)
Not sure who caused this issue, but I'm certain that it's not me. My change had to do with a Javascript change to about:tracing
Labels: Needs-Feedback
Able to reproduce the issue on Windows 7 using chrome latest canary M53-53.0.2768.0. Observed the clock app is not able to launch it on chrome. 

lpanse@ - Since the assigned Dev confirmed it's not his change, Could you please rebisect this issue and assign it to the concerned Dev person.

Comment 4 by lpa...@etouch.net, Jun 16 2016

Labels: -Needs-Feedback
Owner: grt@chromium.org
Status: Assigned (was: Untriaged)
With response to comment #3:
Re-bisected on other machine, getting same bisect range
https://chromium.googlesource.com/chromium/src/+log/6868e2b9440a4d4000b8bfa7e8399ac340c35891..495f126aa1c0f77e8b5a99fc0ea741501404ae7a?pretty=fuller&n=50

Suspecting: r395244 ?

Please help to re-assign if your change is not the cause of this issue.
Cc: rnimmagadda@chromium.org
@grt: Could you please look into this issue.

Thank you.
Still able to reproduce the issue on Windows 7, Mac 10.11.5, Ubuntu 14.04 using 53.0.2780.0.

@grt: Could you please look into this issue.
Cc: ssamanoori@chromium.org brajkumar@chromium.org
Still able to repro this issue on Canary Version - 53.0.2784.1
Cc: ranjitkan@chromium.org
Just to update, this issue is still observed on canary 54.0.2794.0 on Windows 7, MAC 10.11.5, Ubuntu 14.04. Request someone to please take a look into it.

Thanks.!

Comment 9 by grt@chromium.org, Jul 13 2016

Components: Blink>JavaScript>API
Owner: ----
Status: Available (was: Assigned)
Looks to me like the app is throwing an exception:

"Uncaught TypeError: Cannot read property 'pattern' of undefined", source: chrome-extension://galgfocamdohgeifjlbefkfpaalankfi/background.js (7)

The problem is here:

  var dateFormat = new Intl.DateTimeFormat(undefined, { hour: 'numeric' });
  var pattern = dateFormat.resolved.pattern;

dateFormat.resolved is undefined, hence the error.

If this same app used to work, then something has changed in Chrome. Either the error didn't prevent the app from loading, or our DateTimeFormat used to have a "resolved" property. I don't have knowledge of either of these, so I'll step back and let someone else pick this up.
Labels: Needs-triage
Could someone please take an ownership for this issue, as it is marked with a Stable blocker and M53 is set to pushed to Beta Soon. Issue still persists on Dev #53.0.2785.8

Adding Needs-Triage label.

Thanks.!

Comment 11 by grt@chromium.org, Jul 20 2016

Owner: u...@chromium.org
Status: Assigned (was: Available)
ulan: Chrome 51 and 53 handle DateTimeFormat differently. Specifically, DateTimeFormat instances no longer have a "resolved" member. Could this be a result of your change at https://chromium.googlesource.com/v8/v8/+/1f6be3d73ce74460bed4c7a8b4ebec79e446fbe0? If no, could you help us find out what changed? Thanks for your help.

Comment 12 by u...@chromium.org, Jul 20 2016

Cc: u...@chromium.org
Owner: littledan@chromium.org
Found this by googling "chromium dateformat resolved" :)
https://bugs.chromium.org/p/v8/issues/detail?id=3785

There CL at the end:
https://codereview.chromium.org/1968893002

This patch removes the following properties, as their use count is
very low, they are V8-only, and not on a standards track.
- v8Parse
- resolved
- pattern

So looks like this is working as intended.

Deferring to Dan to confirm.

Comment 13 by grt@chromium.org, Jul 20 2016

The Google is strong with this one. :-) Thanks, ulan!

Can someone reach out to the developer of this app and tell them to update it?
Yes, these were purposely removed due to their low usage count and lack of standardization. In particular, Microsoft had objected to "pattern" as being too ICU/CLDR-specific in the past, and so it was purposely left out of the specification. Unfortunately, there is no replacement at the moment to get at that sort of internationalization data besides just formatting a time and then trying to parse it and see what you can get out of it (which I've heard some JS internationalization libraries in fact do). I'll contact the developer and report the issue.
I filed a bug and explained how to fix at https://github.com/kaydensigh/chromecalclock/issues/9
Status: Fixed (was: Assigned)
The author applied a fix at https://github.com/kaydensigh/chromecalclock/commit/5276fdf751cb7dec47669fe3ddc2c58ddbf70a36 .

Sign in to add a comment