New issue
Advanced search Search tips

Issue 617116 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 616941
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.7% regression in smoothness.top_25_smooth at 397215:397246

Project Member Reported by rmcilroy@chromium.org, Jun 3 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=617116

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg3KDlsgoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
Mergedinto: 616941
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Track DisplayItemClient aliveness for each PaintController
Author  : wangxianzhu
Commit description:
  
After CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS was enabled, we didn't get
crashes in DisplayItemClient::~DisplayItemClient() when the
DisplayItemClient should be alive. We still get crashes in
PaintController::updateCacheGeneration() [1]
which indicates that we still have short-lived DisplayItemClient but
not catched by aliveness checking. This might happen if there are
multiple PaintControllers (e.g. one created by SkPictureBuilder and
another by GraphicsLayer).

Separately track DisplayItemClient aliveness for each PaintController
in order to catch the issue.

[1] https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.ptype%3D%27renderer%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%20like%20%27blink%3A%3APaintController%3A%3A%25%27%20AND%20product.version%3D%2753.0.2751.0%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&stbtiq=&reportid=20bc8a5c00000000&index=2#4

BUG=609218

Review-Url: https://codereview.chromium.org/2031623002
Cr-Commit-Position: refs/heads/master@{#397243}
Commit  : 53559da8fd5faa99d30a00eadbc6da3aebbde2b1
Date    : Wed Jun 01 21:16:57 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev    N  Good?
chromium@397214  15.2626  0.142218   8  good
chromium@397230  15.436   0.152598   8  good
chromium@397238  15.3176  0.0948093  5  good
chromium@397242  15.273   0.0569868  5  good
chromium@397243  16.0046  0.135463   5  bad    <--
chromium@397244  15.9488  0.0731826  5  bad
chromium@397246  15.8686  0.174808   5  bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 617116

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.top_25_smooth
Test Metric: mean_input_event_latency/http___games.yahoo.com
Relative Change: 4.04%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1319
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9010880814321486112


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5220978007736320

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment