New issue
Advanced search Search tips

Issue 617115 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 616941
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.4%-1.8% regression in page_cycler.intl_ar_fa_he at 397225:397254

Project Member Reported by rmcilroy@chromium.org, Jun 3 2016

Issue description

See the link to graphs below.
 

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@397224  3465.14  463.295  9   good
chromium@397254  3071.58  455.804  12  bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 617115

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler.intl_ar_fa_he
Test Metric: warm_times/page_load_time
Relative Change: 11.37%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3716
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9010881237581071472


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5866719495585792

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Mergedinto: 616941
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Track DisplayItemClient aliveness for each PaintController
Author  : wangxianzhu
Commit description:
  
After CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS was enabled, we didn't get
crashes in DisplayItemClient::~DisplayItemClient() when the
DisplayItemClient should be alive. We still get crashes in
PaintController::updateCacheGeneration() [1]
which indicates that we still have short-lived DisplayItemClient but
not catched by aliveness checking. This might happen if there are
multiple PaintControllers (e.g. one created by SkPictureBuilder and
another by GraphicsLayer).

Separately track DisplayItemClient aliveness for each PaintController
in order to catch the issue.

[1] https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.ptype%3D%27renderer%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%20like%20%27blink%3A%3APaintController%3A%3A%25%27%20AND%20product.version%3D%2753.0.2751.0%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&stbtiq=&reportid=20bc8a5c00000000&index=2#4

BUG=609218

Review-Url: https://codereview.chromium.org/2031623002
Cr-Commit-Position: refs/heads/master@{#397243}
Commit  : 53559da8fd5faa99d30a00eadbc6da3aebbde2b1
Date    : Wed Jun 01 21:16:57 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@397224  10173.2  71.5171  5  good
chromium@397239  10219.4  12.5817  5  good
chromium@397241  10179.0  35.7141  5  good
chromium@397242  10219.6  66.9276  5  good
chromium@397243  10458.8  35.8427  5  bad    <--
chromium@397247  10434.0  34.271   5  bad
chromium@397254  10464.8  64.0835  5  bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 617115

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler.intl_ar_fa_he
Test Metric: cold_times/http___ynet.co.il_
Relative Change: 2.87%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3717
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9010880850227409152


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5323259969536000

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment