Peeking card is missing on NTP and NTP can't be scrolled to top. |
||||||||||||||||||||
Issue descriptionVersion: OS: Android What steps will reproduce the problem? (1) Enable Content Snippets (2) Open the NTP (3) Scroll to the Content Snippets below the fold and click on a snippet. (4) Wait for page to open and load. (5) Use the back button to navigate back to the NTP What is the expected output? 1 NTP can be scrolled to the top 2 Peaking card should show up. What do you see instead? 1 NTP can't be scrolled to the top 2 peaking card never shows up Please use labels and text to provide additional information.
,
Jun 3 2016
,
Jun 3 2016
,
Jun 3 2016
Please reassign as appropriate. Thanks!
,
Jun 3 2016
Strange, the NTP should be reloaded and be displayed in the initial state already, all the way at the top. I didn't manage to repro. Putting it in the pool of available tasks. We are also going to look as the use case of going back to the NTP after opening the snippets in issue 606356 . Will probably be fixed at that moment, if the bug is not found before.
,
Jun 6 2016
Please avoid removing both the label zine-mr-untriaged and Status:Untriaged, because otherwise it's hard for me to triage reliably :D
,
Jun 7 2016
I find this occurs when you click on something in Most Likely that takes you to a branded site (when the top bar turns the colour of the site, eg yahoo).
,
Jun 7 2016
Ah, that seems possible. We might not restore the state of the toolbar properly after coming back from a branded site.
,
Jun 7 2016
I'll remove the blocker, because this needs to be fixed at a higher priority than Issue 606356 . (If 606356 gets fixed at the same time that'll be a nice side effect).
,
Jun 13 2016
Hi Markus, I can't reproduce this. Does this still repro for you? Can you provide device and version details, plus the site you went to? Thanks Patrick
,
Jun 14 2016
Friendly ping :).
,
Jun 15 2016
Can't reproduce this on Chrome DEV on Android nor on a ToT build.
,
Jun 15 2016
,
Jun 22 2016
To reproduce it reliably, you need to go to a branded site (eg yahoo). I've attached a video of ToT on a Nexus 5X.
,
Jun 22 2016
I think we're carrying over some state from the toolbar for the branded page, so this might be related to issue 614690.
,
Jun 28 2016
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
,
Jul 7 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 8 2016
,
Jul 12 2016
,
Jul 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/975cd680f7ae920afb84cd8ca03ff3d96cfe39a2 commit 975cd680f7ae920afb84cd8ca03ff3d96cfe39a2 Author: mvanouwerkerk <mvanouwerkerk@chromium.org> Date: Tue Jul 12 23:36:35 2016 NTP: fix bad layout when navigating back from a page with a theme-color. When navigating back from a page with a theme-color, more measuring and layout work is done with different values for the viewport height. Avoid storing anything in the layout params based on these changing values, as this would cause subsequent layout passes to be incorrect. Manual test page: http://mvano.github.io/sandbox/themecolor.html BUG= 617109 Review-Url: https://codereview.chromium.org/2136353003 Cr-Commit-Position: refs/heads/master@{#404858} [modify] https://crrev.com/975cd680f7ae920afb84cd8ca03ff3d96cfe39a2/chrome/android/java/res/layout/new_tab_page_layout.xml [modify] https://crrev.com/975cd680f7ae920afb84cd8ca03ff3d96cfe39a2/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
,
Jul 13 2016
|
||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||
Comment 1 by markusheintz@chromium.org
, Jun 3 2016