New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617109 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Peeking card is missing on NTP and NTP can't be scrolled to top.

Project Member Reported by markusheintz@chromium.org, Jun 3 2016

Issue description

Version:
OS: Android

What steps will reproduce the problem?
(1) Enable Content Snippets
(2) Open the NTP
(3) Scroll to the Content Snippets below the fold and click on a snippet.
(4) Wait for page to open and load.
(5) Use the back button to navigate back to the NTP

What is the expected output?
1 NTP can be scrolled to the top
2 Peaking card should show up. 

What do you see instead?
1 NTP can't be scrolled to the top
2 peaking card never shows up 

Please use labels and text to provide additional information.

 
Screenshot_2016-06-03-12-14-36.png
69.6 KB View Download
Cc: bauerb@chromium.org
Cc: rachelis@chromium.org nepper@chromium.org
Cc: fi...@chromium.org

Comment 4 by pam@chromium.org, Jun 3 2016

Owner: dgn@chromium.org
Status: Assigned (was: Untriaged)
Summary: Peeking card is missing on NTP and NTP can't be scrolled to top. (was: Peaking card is missing on NTP and NTP can't be scrolled to top.)
Please reassign as appropriate. Thanks!

Comment 5 by dgn@chromium.org, Jun 3 2016

Blockedon: 606356
Cc: dgn@chromium.org
Labels: zine-mr-mile-MVP
Owner: ----
Status: Available (was: Assigned)
Strange, the NTP should be reloaded and be displayed in the initial state already, all the way at the top. I didn't manage to repro.

Putting it in the pool of available tasks. We are also going to look as the use case of going back to the NTP after opening the snippets in  issue 606356 . Will probably be fixed at that moment, if the bug is not found before.
Labels: -zine-mr M-53
Please avoid removing both the label zine-mr-untriaged and Status:Untriaged, because otherwise it's hard for me to triage reliably :D


I find this occurs when you click on something in Most Likely that takes you to a branded site (when the top bar turns the colour of the site, eg yahoo).
Ah, that seems possible. We might not restore the state of the toolbar properly after coming back from a branded site.
Blockedon: -606356
I'll remove the blocker, because this needs to be fixed at a higher priority than  Issue 606356 . (If 606356 gets fixed at the same time that'll be a nice side effect).
Owner: markusheintz@chromium.org
Status: Unconfirmed (was: Available)
Hi Markus,

I can't reproduce this. Does this still repro for you? Can you provide device and version details, plus the site you went to?

Thanks

Patrick
Friendly ping :).
Can't reproduce this on Chrome DEV on Android nor on a ToT build.
Status: WontFix (was: Unconfirmed)
Status: Available (was: WontFix)
To reproduce it reliably, you need to go to a branded site (eg yahoo).

I've attached a video of ToT on a Nexus 5X.
2016-06-22_17-46-23.mp4
2.4 MB View Download
Cc: markusheintz@chromium.org
Owner: ----
I think we're carrying over some state from the toolbar for the branded page, so this might be related to issue 614690.
Labels: zine-mr-iter-21
Owner: mvanouwe...@chromium.org
Status: Started (was: Available)
Labels: zine-mr-MVP
Labels: zine-16-06-27

Comment 19 by finkm@google.com, Jul 1 2016

Labels: -zine-mr-mvp
Labels: zine-mr-MVP
Project Member

Comment 21 by sheriffbot@chromium.org, Jul 7 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -zine-mr-mile-mvp -zine-mr-mvp zine-client-v1
Labels: zine-16-07-11
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/975cd680f7ae920afb84cd8ca03ff3d96cfe39a2

commit 975cd680f7ae920afb84cd8ca03ff3d96cfe39a2
Author: mvanouwerkerk <mvanouwerkerk@chromium.org>
Date: Tue Jul 12 23:36:35 2016

NTP: fix bad layout when navigating back from a page with a theme-color.

When navigating back from a page with a theme-color, more measuring and
layout work is done with different values for the viewport height. Avoid
storing anything in the layout params based on these changing values, as
this would cause subsequent layout passes to be incorrect.

Manual test page: http://mvano.github.io/sandbox/themecolor.html

BUG= 617109 

Review-Url: https://codereview.chromium.org/2136353003
Cr-Commit-Position: refs/heads/master@{#404858}

[modify] https://crrev.com/975cd680f7ae920afb84cd8ca03ff3d96cfe39a2/chrome/android/java/res/layout/new_tab_page_layout.xml
[modify] https://crrev.com/975cd680f7ae920afb84cd8ca03ff3d96cfe39a2/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java

Status: Fixed (was: Started)

Sign in to add a comment