New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617097 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security

Blocking:
issue 617536



Sign in to add a comment

Heap-buffer-overflow in webrtc::RtpDepacketizerH264::ProcessStapAOrSingleNalu

Project Member Reported by ClusterFuzz, Jun 3 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6393258519560192

Fuzzer: libfuzzer_h264_depacketizer_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x60500000cf2b
Crash State:
  webrtc::RtpDepacketizerH264::ProcessStapAOrSingleNalu
  webrtc::RtpDepacketizerH264::Parse
  webrtc::FuzzOneInput
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=397426:397565

Minimized Testcase (0.01 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95M5PkrVvtKYkjb4lLtLHTe_X4lWpvEKLHMX18Ql0RpGA0NVS1RO_Jv-Z5_1-r67NCVywDyjSJdOocHnGXi79dsrIrLgwylkD2l4I3sEmYQfLEdsbvIeHIgSq-AaIcBgEswZMLxAHwceM4xivUPaFNxTJ9jCw

Filer: mmoroz

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: mmoroz@chromium.org kcc@chromium.org aizatsky@chromium.org
Labels: Pri-1
Owner: pbos@chromium.org

Comment 2 by pbos@chromium.org, Jun 3 2016

Cc: pbos@chromium.org
Owner: danilchap@chromium.org
->danilchap@, please hand it back if you don't have the bandwidth to fix this
Project Member

Comment 3 by ClusterFuzz, Jun 3 2016

Status: Assigned (was: Available)
Owner: sprang@chromium.org
->sprang@, look like this one in function you just committed with https://codereview.webrtc.org/1979443004/

Comment 5 by pbos@chromium.org, Jun 3 2016

Cc: danilchap@chromium.org

Comment 6 by f...@chromium.org, Jun 3 2016

Components: Blink>WebRTC
Labels: M-53
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 4 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 617536

Comment 9 by pbos@chromium.org, Jun 6 2016

Let me know if you need any help reproducing fuzzing issues locally.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/6ebdf6b2cc0f3af30c95a085215cd05b91213a21

commit 6ebdf6b2cc0f3af30c95a085215cd05b91213a21
Author: Erik Språng <sprang@webrtc.org>
Date: Tue Jun 07 16:01:21 2016

Fix issue with parsing of incorrect (empty) Stap-A H264 NAL units.

Stap-A packets should be ignored if NAL unit size is less than one,
since that won't even fit the mandatory type header byte.

BUG= chromium:617097 
R=pbos@webrtc.org, stefan@webrtc.org

Review URL: https://codereview.webrtc.org/2039353002 .

Cr-Commit-Position: refs/heads/master@{#13057}

[modify] https://crrev.com/6ebdf6b2cc0f3af30c95a085215cd05b91213a21/webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc
[modify] https://crrev.com/6ebdf6b2cc0f3af30c95a085215cd05b91213a21/webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc

Project Member

Comment 11 by ClusterFuzz, Jun 10 2016

ClusterFuzz has detected this issue as fixed in range 398366:399171.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6393258519560192

Fuzzer: libfuzzer_h264_depacketizer_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x60500000cf2b
Crash State:
  webrtc::RtpDepacketizerH264::ProcessStapAOrSingleNalu
  webrtc::RtpDepacketizerH264::Parse
  webrtc::FuzzOneInput
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=397426:397565
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=398366:399171

Minimized Testcase (0.01 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96R6SVUoiKajRSRx9GGEZu9Okw_yyL9fxBPKBSYJXsAuZcW53qZ1l8qE2K9DgSmzfLy4d-5-94OqyV2UFN_NwZeAEhAcyDaP7aes94SQl3rFx3fDohnB5zN_itYDrNF31G5tMqH8V3eRP5tyfu4TtTWM0TcBw

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Jun 14 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 13 by ClusterFuzz, Jun 14 2016

Labels: Merge-NA
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 14 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ClusterFuzz-Verified
Status: Assigned (was: Verified)
Sorry for the incorrect ClusterFuzz update, please ignore it. Reopening bug.
Project Member

Comment 16 by ClusterFuzz, Jun 15 2016

Status: Fixed (was: Assigned)
Please mark security bugs as fixed as soon as the fix lands, and before requesting merges.

- Your friendly ClusterFuzz
Why was the ClusterFuzz update incorrect? I expected this to be fixed by webrtc r13057 (rolled into Chromium at r398550)
This case looks correct, but there were some changes on ClusterFuzz side regarding ClusterFuzz-Verified label, so that update could be wrong.
Labels: -ReleaseBlock-Beta -ClusterFuzz -merge-na Clusterfuzz Merge-na
Project Member

Comment 20 by sheriffbot@chromium.org, Sep 21 2016

Labels: -Restrict-View-SecurityNotify
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 21 by sheriffbot@chromium.org, Oct 1 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 22 by sheriffbot@chromium.org, Oct 2 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic

Sign in to add a comment