New issue
Advanced search Search tips

Issue 617094 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Human readable origins for Android credentials on Android OS

Project Member Reported by kolos@chromium.org, Jun 3 2016

Issue description

This CL (https://codereview.chromium.org/1615653005/) introduced human readable origins for the credentials that were saved in Android apps (e.g. it displays "netflix.com (Android)" instead of "android://com.netflix.mediaclient"). 

The CL affects only on desktop OSs. Human readable origins for Android credentials should be shown on Android OS as well. 



 

Comment 1 by kolos@chromium.org, Jun 3 2016

This CL (https://codereview.chromium.org/1627193003) that displays origins for Android might be useful.

The function that produces origins to show - GetShownOriginAndLinkUrl (https://cs.chromium.org/chromium/src/components/password_manager/core/browser/password_ui_utils.cc?q=GetShownOriginAndLinkUrl&l=24)

Comment 2 by vabr@chromium.org, Jun 3 2016

Labels: tracking_work
Owner: vabr@chromium.org
Status: Assigned (was: Untriaged)
Assigning temporarily to vabr@ until dozsa@ has edit bug privileges and can be assigned this bug.

Comment 3 by vabr@chromium.org, Jun 7 2016

Owner: dozsa@google.com

Comment 5 by vabr@chromium.org, Jun 13 2016

A follow-up task after r399453 is to change gluing IDS_PASSWORDS_ANDROID_URI_SUFFIX to the origin string to making the localized resource a format string and passing the origin to it. https://codereview.chromium.org/2042033003/diff/100001/chrome/browser/android/password_ui_view_android.cc#newcode52

Comment 6 by vabr@chromium.org, Jun 13 2016

And another follow-up task is to use link_url from GetShownOriginAndLinkUrl on Android -- it should likely be displayed in the "Edit password" view. It would be good to check this with the UI team, once there is a chance.

Comment 8 by vabr@chromium.org, Aug 25 2016

Cc: -vabr@chromium.org
Owner: vabr@chromium.org
The main issue was solved, but there are still two follow-ups: comments #5 and #6.

(We already received the guidance from the UI team on #6.)

dozsa@ finished the internship, so reassigning to myself.

Comment 9 by vabr@chromium.org, May 2 2017

Labels: -tracking_work Type-Task

Comment 10 by vabr@chromium.org, Jul 6 2017

Cc: -melandory@chromium.org vabr@chromium.org
Owner: melandory@chromium.org
Hi Tanja, another task related to viewing passwords on Android.

As for #5, I guess this is obsoleted by jdoerrie@'s work on bug 628988 -- once the support for app store names is added, we should use those instead of gluing "(Android)" to randomly chosen URLs.

As for #6, I feel stupid for noting in #8 that we have the guidance, but not stating the guidance. Perhaps it's in the mocks?
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9fc076120ab64a7ff2bfa46ce511830724a234f

commit b9fc076120ab64a7ff2bfa46ce511830724a234f
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Jul 14 10:39:30 2017

Add Support for App Display Names to GetShownOriginAndLinkUrl

This change adds support for app display names to Password UI Utils.
This is useful for the more human friendly display of Android
credentials, as this will display the Play Store name of the App, if
available.

Bug: 628988,  617094 ,  679434 
Change-Id: Ide7bc694805ce40cbbccf8e8496c32bcb677de25
Reviewed-on: https://chromium-review.googlesource.com/567936
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486721}
[modify] https://crrev.com/b9fc076120ab64a7ff2bfa46ce511830724a234f/chrome/browser/android/password_ui_view_android.cc
[modify] https://crrev.com/b9fc076120ab64a7ff2bfa46ce511830724a234f/chrome/browser/android/password_ui_view_android.h
[modify] https://crrev.com/b9fc076120ab64a7ff2bfa46ce511830724a234f/chrome/browser/extensions/api/passwords_private/passwords_private_utils.cc
[modify] https://crrev.com/b9fc076120ab64a7ff2bfa46ce511830724a234f/chrome/browser/extensions/api/passwords_private/passwords_private_utils.h
[modify] https://crrev.com/b9fc076120ab64a7ff2bfa46ce511830724a234f/chrome/browser/extensions/api/passwords_private/passwords_private_utils_unittest.cc
[modify] https://crrev.com/b9fc076120ab64a7ff2bfa46ce511830724a234f/chrome/browser/ui/passwords/password_manager_presenter.cc
[modify] https://crrev.com/b9fc076120ab64a7ff2bfa46ce511830724a234f/chrome/browser/ui/passwords/password_manager_presenter_unittest.cc
[modify] https://crrev.com/b9fc076120ab64a7ff2bfa46ce511830724a234f/chrome/browser/ui/webui/options/password_manager_handler.cc
[modify] https://crrev.com/b9fc076120ab64a7ff2bfa46ce511830724a234f/components/password_manager/core/browser/password_ui_utils.cc
[modify] https://crrev.com/b9fc076120ab64a7ff2bfa46ce511830724a234f/components/password_manager/core/browser/password_ui_utils.h
[modify] https://crrev.com/b9fc076120ab64a7ff2bfa46ce511830724a234f/components/password_manager/core/browser/password_ui_utils_unittest.cc

http://crrev.com/c/567936 fixed #c5, since it inlined |GetDisplayOriginForSettings| and got rid of appending " (Android)" to the shown origin.

While doing so I removed the "TODO( crbug.com/617094 ) Also display link_url." comment, even though it is still relevant. So #c6 should still be addressed.
Status: Fixed (was: Assigned)
Cc: -vabr@chromium.org

Sign in to add a comment