Add deprecation warnings when Web Audio is used in cross origin iframe without a user gesture |
|||||||
Issue descriptionWe aim to make this impossible in the future so we need to notify the developers about the change (in addition of checking whether this is common).
,
Aug 24 2016
,
Sep 7 2016
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e94d8acbaf7ffca80e06429422fe8cbd311f781 commit 8e94d8acbaf7ffca80e06429422fe8cbd311f781 Author: mlamouri <mlamouri@chromium.org> Date: Tue Sep 13 09:01:08 2016 Warn about Web Audio without user gesture on Android no longer allowed on cross origin iframes. This is a CL to send to M54 to warn users of Web Audio in cross origin iframes. Note that because of how Web Audio work this warning (and the use counter) are larger than reality: every `new AudioContext` in a cross origin iframe will warn if not inside an event handler even if they are not meant to be used yet. Intent to Intervene: https://groups.google.com/a/chromium.org/d/msg/blink-dev/51WbTwn0M_Y/VZuwn8-VAAAJ BUG= 617090 Review-Url: https://codereview.chromium.org/2311233002 Cr-Commit-Position: refs/heads/master@{#418201} [modify] https://crrev.com/8e94d8acbaf7ffca80e06429422fe8cbd311f781/third_party/WebKit/Source/core/frame/Deprecation.cpp [modify] https://crrev.com/8e94d8acbaf7ffca80e06429422fe8cbd311f781/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/8e94d8acbaf7ffca80e06429422fe8cbd311f781/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp [modify] https://crrev.com/8e94d8acbaf7ffca80e06429422fe8cbd311f781/tools/metrics/histograms/histograms.xml
,
Sep 13 2016
,
Sep 13 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fb1bdf0ffe1d08ed7ec098de07daf59447a1903 commit 2fb1bdf0ffe1d08ed7ec098de07daf59447a1903 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Tue Sep 13 09:16:10 2016 Warn about Web Audio without user gesture on Android no longer allowed on cross origin iframes. This is a CL to send to M54 to warn users of Web Audio in cross origin iframes. Note that because of how Web Audio work this warning (and the use counter) are larger than reality: every `new AudioContext` in a cross origin iframe will warn if not inside an event handler even if they are not meant to be used yet. Intent to Intervene: https://groups.google.com/a/chromium.org/d/msg/blink-dev/51WbTwn0M_Y/VZuwn8-VAAAJ BUG= 617090 Review-Url: https://codereview.chromium.org/2311233002 Cr-Commit-Position: refs/heads/master@{#418201} (cherry picked from commit 8e94d8acbaf7ffca80e06429422fe8cbd311f781) Review URL: https://codereview.chromium.org/2336143002 . Cr-Commit-Position: refs/branch-heads/2840@{#323} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/2fb1bdf0ffe1d08ed7ec098de07daf59447a1903/third_party/WebKit/Source/core/frame/Deprecation.cpp [modify] https://crrev.com/2fb1bdf0ffe1d08ed7ec098de07daf59447a1903/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/2fb1bdf0ffe1d08ed7ec098de07daf59447a1903/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp [modify] https://crrev.com/2fb1bdf0ffe1d08ed7ec098de07daf59447a1903/tools/metrics/histograms/histograms.xml
,
Sep 13 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fb1bdf0ffe1d08ed7ec098de07daf59447a1903 commit 2fb1bdf0ffe1d08ed7ec098de07daf59447a1903 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Tue Sep 13 09:16:10 2016 Warn about Web Audio without user gesture on Android no longer allowed on cross origin iframes. This is a CL to send to M54 to warn users of Web Audio in cross origin iframes. Note that because of how Web Audio work this warning (and the use counter) are larger than reality: every `new AudioContext` in a cross origin iframe will warn if not inside an event handler even if they are not meant to be used yet. Intent to Intervene: https://groups.google.com/a/chromium.org/d/msg/blink-dev/51WbTwn0M_Y/VZuwn8-VAAAJ BUG= 617090 Review-Url: https://codereview.chromium.org/2311233002 Cr-Commit-Position: refs/heads/master@{#418201} (cherry picked from commit 8e94d8acbaf7ffca80e06429422fe8cbd311f781) Review URL: https://codereview.chromium.org/2336143002 . Cr-Commit-Position: refs/branch-heads/2840@{#323} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/2fb1bdf0ffe1d08ed7ec098de07daf59447a1903/third_party/WebKit/Source/core/frame/Deprecation.cpp [modify] https://crrev.com/2fb1bdf0ffe1d08ed7ec098de07daf59447a1903/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/2fb1bdf0ffe1d08ed7ec098de07daf59447a1903/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp [modify] https://crrev.com/2fb1bdf0ffe1d08ed7ec098de07daf59447a1903/tools/metrics/histograms/histograms.xml |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mlamouri@chromium.org
, Jun 21 2016