Unnecessary video exiting from full-screen mode on cancelling the print preview.
Reported by
dchau...@etouch.net,
Jun 3 2016
|
||||||||
Issue descriptionChrome Version: 53.0.2757.0 (Official Build)31724d2879923fbf1adab8cd8d6a353a9888379a-refs/heads/master@{#397573} 32/64-bit. OS: Windows(7,8,10), Linux(Ubuntu 14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, go to www.youtube.com and play any video. 2. Click on fullscreen button and then give print command. 3. Now, press 'Esc' key from keyboard and observe. Unnecessary video exiting from full-screen mode. Video should not exit from full-screen mode only print window should get closed. This is a non regression issue, seen from M-30 series. Note: 1. This issue is not reproducible on Mac OS. 2. This issue is also reproducible on www.facebook.com for all the videos. Kindly review the attached screen-cast for reference.
,
Jul 7 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 19 2016
,
Jul 22 2016
Not sure this has anything to do with the video element itself, this happens with any fullscreen content (e.g. launch fullscreen on https://davidwalsh.name/demo/fullscreen.php and then press Esc).
,
May 2 2017
,
May 3 2017
Print preview (via ConstrainedWebDialogDelegateViewViews) currently consumes the key down event for the escape key. It closes when this event is received. So a webpage watching for the key down event on the escape key will not receive the event, but if the webpage is watching for the key up event on the escape key, it will receive the event since it occurs after the print preview dialog has closed. These full screen examples appear to be watching for the key up event and exiting full screen when it is received. Not sure how (or if) we want to fix this. It is possible to change the behavior so that the dialog consumes the key down event but remains open to consume the key up event. It will then close when the key up event is received. This prevents the background page from receiving any events from an Escape key press that occurs when Print Preview is active. However, this also means if a user holds down the escape key the print preview will remain visible and active until they release the key (currently, it will disappear as soon as escape is pressed down). It is also possible to make the dialog "disappear" without actually closing it when the key down event occurs. This can be achieved by making it transparent and too small to interact with. The dialog will actually close, invisibly to the user, when the key up event occurs, so that it can consume that event also. This will also prevent the underlying page from getting the key event and makes the dialog appear to close at the right time, but it also eliminates the current animation for the preview closing. The dialog will appear to simply vanish. Note that this same behavior can be observed with the Cast UI since it uses the same ConstrainedWebDialogDelegateViewViews class. cc-ing hwi@ and jawag@ for input on what the best option would be.
,
May 4 2017
In my opinion, neither of the options you are proposing seem too bad -- I would be surprised if many users "hold" the escape key for any significant period of time (do we know?) and I also have a hard time believing many users would notice a significant difference if we skipped the preview-close animation. It's pretty subtle. From a UX consistency standpoint I can see how one could argue against both of these options, but I think either would be an improvement over the current experience, with a slight preference for the latter option (skipping the close animation). Hwi, what do you think? +skonig, is the Cast team currently thinking about this? Any plans?
,
Jul 27 2017
Based on bug 728276 , this is now irrelevant, as opening the print preview dialog should cause the page to exit full screen. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tkonch...@chromium.org
, Jun 3 2016