New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617062 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Focus stuck on locked profile on pressing Shift+Tab key in 'Switch Person' window.

Reported by yfulgaon...@etouch.net, Jun 3 2016

Issue description

Chrome version : 53.0.2757.0 (Official Build) 31724d2879923fbf1adab8cd8d6a353a9888379a-refs/heads/master@{#397573} 32/64 bit
OS :  Windows (7,8,8.1,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS)

Pre-condition : Please enable ‘Material Design User Manager’ flag from chrome://flags.

What steps will reproduce the problem?
1) Launch chrome, Sign in to chrome and from 'People' section in 'chrome://settings' add/import a supervised user.
2) In parent window, click on avatar icon and select 'Exit and childlock' option.
3) Now in 'Switch person' window, press Shift+Tab key 3 - 4 times to move focus in reverse direction and observe the focus travel.

Actual : After step 3, focus stuck on locked profile and does not move in reverse direction.
Expected : After step 3, focus should not stuck and should move properly in reverse direction.

This is a regression issue, broken in 'M-53', below is the Manual Bisect and Change log info.
Good Build : 53.0.2750.0
Bad Build : 53.0.2751.0

Note: Issue not reproducible on Chromium builds as not able to Sign in to chrome, hence providing suspect from Change log URL.

Change log URL:
https://chromium.googlesource.com/chromium/src/+log/53.0.2750.0..53.0.2751.0?pretty=fuller&n=10000

Suspecting : r396502 from change log
 
Actual_focus.mp4
1.6 MB Download
Expected_focus.mp4
1.5 MB Download
Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression.
Labels: -ReleaseBlock-Stable
Cannot reproduce this on Ubuntu 14.04 Chromium 53.0.2757.0

The tab order has recently been changed the following:
Pod A -> Pod A overflow menu -> Pod B -> Pod overflow menu -> ...
instead of:
Pod A -> Pod B -> ... -> Pod A overflow menu -> Pod B overflow menu

If this is the behavior you're observing it is expected. Removing RB for now.
With response to comment #2,
Able to reproduce the above issue on build no 53.0.2761.2 in Win and Linux OS.

Note : The issue is reproducible only when there are 2 users (i.e one main user & one supervised user). It is not reproducible if there is a third user. Kindly review an attached screen cast. Thank you!
canary_behavior.mp4
2.3 MB Download
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 7 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-54 M-55
Just to update,

Able to reproduce the issue on Mac OS using canary build 55.0.2878.0 Thank you!
Cc: mahmadi@chromium.org
Owner: msarda@chromium.org
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 2 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by msarda@chromium.org, Jan 11 2017

Owner: jlebel@chromium.org
Cc: jlebel@chromium.org
Owner: scottchen@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4913f5ed2fb633f9f7872fd9d1203b3cdbfa35a

commit e4913f5ed2fb633f9f7872fd9d1203b3cdbfa35a
Author: Scott Chen <scottchen@chromium.org>
Date: Mon Oct 30 11:02:24 2017

MD User Manager: fix tab handling for locked user.

When a locked supervising user has no local credentials, the password
input will be hidden. However, the code currently still tries to focus
that input as the mainInput of the user pod, which puts tab navigation
in a limbo state.

This CL adds a check in DesktopUserPod to focus the correct element
instead of the hidden input while tabbing, when there's no local creds.

Bug:  617062 
Change-Id: Ia4e6edcecf8e25813debcdd89dcf72186f04be76
Reviewed-on: https://chromium-review.googlesource.com/741749
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512468}
[modify] https://crrev.com/e4913f5ed2fb633f9f7872fd9d1203b3cdbfa35a/ui/login/account_picker/user_pod_row.js

Labels: TE-Verified-M64 TE-Verified-64.0.3254.0
Update : 
Retested above issue on Windows(7,8,10), Mac(10.12.6) & Linux(14.04 LTS) OS using latest Canary #64.0.3254.0 and issue is fixed. Now focus doesn't stuck on locked profile picture on pressing 'Shift + Tab' key. Kindly review an attached screen cast.

Thank you!
Supervised_user.mp4
1.4 MB View Download
Status: Fixed (was: Started)

Sign in to add a comment