ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose flaky on Win7 |
||||||||||
Issue descriptionSample build: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/49298 Logs attached. Failure messages: ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose (run #1): [ RUN ] ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose [4020:4492:0602/195853:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! [2576:5596:0602/195854:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! [3648:4548:0602/195854:FATAL:square_ink_drop_ripple.cc(266)] Check failed: old_ink_drop_state == InkDropState::HIDDEN.
,
Jun 3 2016
,
Jun 3 2016
This looks like it started flaking shortly after r397555 from kylixrd@, which modified Ink Drop (and likely could have caused the failure in this test). It started failing consistently in the same build on the Site Isolation FYI bot as well, until it was disabled: https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/14843 I would suggest reverting r397555 and re-enabling the test, unless a fix can be landed right away. kylixrd@, can you take a look?
,
Jun 3 2016
A CL to fix this has been submitted for review: https://codereview.chromium.org/2034893003/
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e02d1460890d367b121a1d17a1e655a9bc6bef37 commit e02d1460890d367b121a1d17a1e655a9bc6bef37 Author: kylixrd <kylixrd@chromium.org> Date: Fri Jun 03 22:27:02 2016 Fixed interactive ui test regression BUG=617056 Review-Url: https://codereview.chromium.org/2034893003 Cr-Commit-Position: refs/heads/master@{#397822} [modify] https://crrev.com/e02d1460890d367b121a1d17a1e655a9bc6bef37/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc [modify] https://crrev.com/e02d1460890d367b121a1d17a1e655a9bc6bef37/ui/views/controls/button/custom_button.cc
,
Jun 7 2016
,
Jun 8 2016
,
Sep 15 2016
The test is failing flakily now. For example, in https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/52673: [ RUN ] ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose [1652:2668:0914/234510:WARNING:persistent_histogram_allocator.cc(485)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing). [3596:704:0914/234511:WARNING:persistent_histogram_allocator.cc(485)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing). [2164:2148:0914/234512:WARNING:persistent_histogram_allocator.cc(485)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing). [3116:252:0914/234513:WARNING:persistent_histogram_allocator.cc(485)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing). c:\b\c\b\win\src\chrome\browser\ui\views\toolbar\toolbar_action_view_interactive_uitest.cc(327): error: Value of: view_controller->is_showing_popup() Actual: true Expected: false c:\b\c\b\win\src\chrome\browser\ui\views\toolbar\toolbar_action_view_interactive_uitest.cc(328): error: Value of: toolbar_actions_bar->popup_owner() Actual: 3E442220 Expected: nullptr Which is: NULL [3184:4084:0914/234514:WARNING:persistent_histogram_allocator.cc(485)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing). [1652:2668:0914/234514:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread. [ FAILED ] ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose, where TypeParam = and GetParam() = (4119 ms)
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e549df170429c3ff33656ef88870af1a1e349b7 commit 0e549df170429c3ff33656ef88870af1a1e349b7 Author: grt <grt@chromium.org> Date: Thu Sep 15 08:21:03 2016 Disabling flaky DoubleClickToolbarActionToClose on Windows BUG=617056 TBR=rdevlin.cronin@chromium.org Review-Url: https://codereview.chromium.org/2331423006 Cr-Commit-Position: refs/heads/master@{#418808} [modify] https://crrev.com/0e549df170429c3ff33656ef88870af1a1e349b7/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc
,
Dec 2 2016
Flaked on Chrome OS now too: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/20337 Any updates?
,
Dec 21 2016
This is also flaky on Linux https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)/builds/59745/steps/browser_side_navigation_interactive_ui_tests/logs/ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose (run #1): [ RUN ] ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose Xlib: extension "RANDR" missing on display ":99". Xlib: extension "RANDR" missing on display ":99". [24906:24906:1221/092723.198369:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [24906:24906:1221/092723.198459:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected [24906:24906:1221/092723.462384:WARNING:password_store_factory.cc(248)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. ../../chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc:335: Failure Value of: view_controller->is_showing_popup() Actual: true Expected: false ../../chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc:336: Failure Value of: toolbar_actions_bar->popup_owner() Actual: 0xe6f781adb20 Expected: nullptr Which is: NULL [24906:24928:1221/092725.541980:WARNING:linux_util.cc(83)] Cannot open /proc/24981/task [24906:24906:1221/092725.987888:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread. [ FAILED ] ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose, where TypeParam = and GetParam() = (4080 ms)
,
Dec 21 2016
Disabling on Linux and ChromeOS https://codereview.chromium.org/2597823002/ (Also flaked in chromeos) https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/20823
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/765dac12e2d1d8fcd4432f32858f987edf08c9b3 commit 765dac12e2d1d8fcd4432f32858f987edf08c9b3 Author: hcarmona <hcarmona@chromium.org> Date: Thu Dec 22 00:21:19 2016 Disable flaky DoubleClickToolbarActionToClose on Linux and ChromeOS TBR=kylixrd@chromium.org BUG=617056 Review-Url: https://codereview.chromium.org/2597823002 Cr-Commit-Position: refs/heads/master@{#440277} [modify] https://crrev.com/765dac12e2d1d8fcd4432f32858f987edf08c9b3/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc
,
Jan 24 2018
,
Jan 24 2018
,
Nov 8
Mass UI Triage, archiving old bugs.
,
Dec 7
,
Jan 16
,
Jan 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e commit 632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e Author: Peter Kasting <pkasting@chromium.org> Date: Thu Jan 17 05:11:56 2019 Re-enable disabled tests in chrome/browser/ui/views/toolbar/. Bug: 163931, 401304 , 617056, 764111, 788112 , 823543, 824418 Change-Id: I6c1a8be7f5d30e0082b69af12aceb35851ce2f51 Reviewed-on: https://chromium-review.googlesource.com/c/1351805 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#623589} [modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/browser/ui/views/toolbar/outdated_upgrade_bubble_view_browsertest.cc [modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc [modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc [modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/test/base/view_event_test_base.cc [modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/test/base/view_event_test_base.h |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 3 2016