New issue
Advanced search Search tips

Issue 617056 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose flaky on Win7

Project Member Reported by vabr@chromium.org, Jun 3 2016

Issue description

Sample build: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/49298

Logs attached. Failure messages:

ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose (run #1):
[ RUN      ] ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose
[4020:4492:0602/195853:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread!
[2576:5596:0602/195854:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread!
[3648:4548:0602/195854:FATAL:square_ink_drop_ripple.cc(266)] Check failed: old_ink_drop_state == InkDropState::HIDDEN.
 
Log File contents.html
105 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93dac074a86a57e083d6554c6c7d5577b9759aad

commit 93dac074a86a57e083d6554c6c7d5577b9759aad
Author: vabr <vabr@chromium.org>
Date: Fri Jun 03 08:44:30 2016

Disable ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose on Win

It has been flaky on Win 7.

TBR=oshima@chromium.org,finnur@chromium.org,rdevlin.cronin@chromium.org
BUG=617056

Review-Url: https://codereview.chromium.org/2033333002
Cr-Commit-Position: refs/heads/master@{#397666}

[modify] https://crrev.com/93dac074a86a57e083d6554c6c7d5577b9759aad/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

Comment 2 by vabr@chromium.org, Jun 3 2016

Cc: vabr@chromium.org
 Issue 617068  has been merged into this issue.

Comment 3 by creis@chromium.org, Jun 3 2016

Labels: Proj-MaterialDesign-NativeUI
Owner: kylixrd@chromium.org
This looks like it started flaking shortly after r397555 from kylixrd@, which modified Ink Drop (and likely could have caused the failure in this test).

It started failing consistently in the same build on the Site Isolation FYI bot as well, until it was disabled:
https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/14843

I would suggest reverting r397555 and re-enabling the test, unless a fix can be landed right away.  kylixrd@, can you take a look?
A CL to fix this has been submitted for review: https://codereview.chromium.org/2034893003/

Comment 6 by vabr@chromium.org, Jun 7 2016

Cc: -vabr@chromium.org
Status: Fixed (was: Untriaged)

Comment 8 by grt@chromium.org, Sep 15 2016

Status: Assigned (was: Fixed)
The test is failing flakily now. For example, in https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/52673:

[ RUN      ] ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose

[1652:2668:0914/234510:WARNING:persistent_histogram_allocator.cc(485)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing).

[3596:704:0914/234511:WARNING:persistent_histogram_allocator.cc(485)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing).

[2164:2148:0914/234512:WARNING:persistent_histogram_allocator.cc(485)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing).

[3116:252:0914/234513:WARNING:persistent_histogram_allocator.cc(485)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing).

c:\b\c\b\win\src\chrome\browser\ui\views\toolbar\toolbar_action_view_interactive_uitest.cc(327): error: Value of: view_controller->is_showing_popup()

  Actual: true

Expected: false

c:\b\c\b\win\src\chrome\browser\ui\views\toolbar\toolbar_action_view_interactive_uitest.cc(328): error: Value of: toolbar_actions_bar->popup_owner()

  Actual: 3E442220

Expected: nullptr

Which is: NULL

[3184:4084:0914/234514:WARNING:persistent_histogram_allocator.cc(485)] Creating the results-histogram inside persistent memory can cause future allocations to crash if that memory is ever released (for testing).

[1652:2668:0914/234514:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.

[  FAILED  ] ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose, where TypeParam =  and GetParam() =  (4119 ms)
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e549df170429c3ff33656ef88870af1a1e349b7

commit 0e549df170429c3ff33656ef88870af1a1e349b7
Author: grt <grt@chromium.org>
Date: Thu Sep 15 08:21:03 2016

Disabling flaky DoubleClickToolbarActionToClose on Windows

BUG=617056
TBR=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2331423006
Cr-Commit-Position: refs/heads/master@{#418808}

[modify] https://crrev.com/0e549df170429c3ff33656ef88870af1a1e349b7/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

Labels: OS-Linux
This is also flaky on Linux

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)/builds/59745/steps/browser_side_navigation_interactive_ui_tests/logs/ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose

ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose (run #1):
[ RUN      ] ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose
Xlib:  extension "RANDR" missing on display ":99".
Xlib:  extension "RANDR" missing on display ":99".
[24906:24906:1221/092723.198369:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected
[24906:24906:1221/092723.198459:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected
[24906:24906:1221/092723.462384:WARNING:password_store_factory.cc(248)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
../../chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc:335: Failure
Value of: view_controller->is_showing_popup()
  Actual: true
Expected: false
../../chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc:336: Failure
Value of: toolbar_actions_bar->popup_owner()
  Actual: 0xe6f781adb20
Expected: nullptr
Which is: NULL
[24906:24928:1221/092725.541980:WARNING:linux_util.cc(83)] Cannot open /proc/24981/task
[24906:24906:1221/092725.987888:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose, where TypeParam =  and GetParam() =  (4080 ms)
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/765dac12e2d1d8fcd4432f32858f987edf08c9b3

commit 765dac12e2d1d8fcd4432f32858f987edf08c9b3
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Dec 22 00:21:19 2016

Disable flaky DoubleClickToolbarActionToClose on Linux and ChromeOS

TBR=kylixrd@chromium.org

BUG=617056

Review-Url: https://codereview.chromium.org/2597823002
Cr-Commit-Position: refs/heads/master@{#440277}

[modify] https://crrev.com/765dac12e2d1d8fcd4432f32858f987edf08c9b3/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

Components: Tests>Disabled
Labels: Test-Disabled
Labels: Hotlist-DesktopUIChecked
Status: Archived (was: Assigned)
Mass UI Triage, archiving old bugs.
Owner: pkasting@chromium.org
Status: Started (was: Archived)
Cc: rdevlin....@chromium.org
 Issue 788112  has been merged into this issue.
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 17

Sign in to add a comment