tables/mozilla/bugs/bug30692.html failed on Mac 10.11 after auto-rebaseline |
|||||||
Issue descriptionBuild: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/3397 Failure (full log attached): 22:32:36.892 9417 "/b/build/slave/WebKit_Mac10_11__retina_/build/src/out/Release/image_diff --diff /tmp/tmp2WmGQV/actual.png /tmp/tmp2WmGQV/expected.png /tmp/tmp2WmGQV/diff.png" took 0.20s 22:32:37.113 9417 "ruby -I /b/build/slave/WebKit_Mac10_11__retina_/build/src/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch /b/build/slave/WebKit_Mac10_11__retina_/build/src/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch/prettify.rb /b/build/slave/WebKit_Mac10_11__retina_/build/layout-test-results/tables/mozilla/bugs/ bug30692 -diff.txt" took 0.17s 22:32:37.232 9390 [40388/41088] tables/mozilla/bugs/ bug30692 .html failed unexpectedly (text diff, image diff) 22:32:37.230 9417 worker/2 tables/mozilla/bugs/ bug30692 .html failed: 22:32:37.231 9417 worker/2 text diff 22:32:37.231 9417 worker/2 image diff
,
Jun 3 2016
Actually, maybe it is because the rebaseline did not include Mac 10.11 (it did change Mac 10.10, for example).
,
Jun 3 2016
Ad #2 and #1 -- I don't know, really, not sure how the test expectations work there. Will just disable the test on Mac for now and move on with sheriffing.
,
Jun 3 2016
I've been told on IRC that wkorman is a good contact in case this is indeed related to the auto-rebaseline. wkorman@ -- could you please have a look? If you don't think this is auto-rebaseline-related, then please just say so, unassign from yourself and mark as Untriaged. Thanks!
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98bb6267e7954dde9082785b792bdcf815d51c30 commit 98bb6267e7954dde9082785b792bdcf815d51c30 Author: vabr <vabr@chromium.org> Date: Fri Jun 03 11:25:40 2016 Disable tables/mozilla/bugs/ bug30692 .html on Mac10.11 The test fails on Mac 10.11 after auto-rebaseline, see the bug for more info. TBR=glebl@chromium.org BUG= 617033 Added NOTRY, because there is a lot of other breakage in Blink currently. NOTRY=true Review-Url: https://codereview.chromium.org/2031243002 Cr-Commit-Position: refs/heads/master@{#397682} [modify] https://crrev.com/98bb6267e7954dde9082785b792bdcf815d51c30/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 3 2016
The disabling did not work, apparently: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/3410. Trying to figure out why.
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3831cba2aad23496e608e5fe39b51cf20d1371ac commit 3831cba2aad23496e608e5fe39b51cf20d1371ac Author: vabr <vabr@chromium.org> Date: Fri Jun 03 13:37:46 2016 Fix incorrect test specification Apparently, the Retina specifier was missing when disabling tables/mozilla/bugs/ bug30692 .html on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/. NOTRY=true TBR=mkwst@chromium.org BUG= 617033 Review-Url: https://codereview.chromium.org/2032093003 Cr-Commit-Position: refs/heads/master@{#397699} [modify] https://crrev.com/3831cba2aad23496e608e5fe39b51cf20d1371ac/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 6 2016
,
Jun 6 2016
,
Jun 6 2016
This doesn't look fixed -- the TestExpectations line is still there.
,
Jun 6 2016
Oh, incorrect grepping on my part. Never mind :p
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c065affd6e62ba7e1658ace14f0d1186f789f503 commit c065affd6e62ba7e1658ace14f0d1186f789f503 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Jun 21 18:11:40 2016 Update expectations for bug 621915 , 617033 , 621892 BUG= 621915 , 617033 , 621892 Review URL: https://codereview.chromium.org/2086723003 . Cr-Commit-Position: refs/heads/master@{#401049} [modify] https://crrev.com/c065affd6e62ba7e1658ace14f0d1186f789f503/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 21 2016
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af7b3c880a41a64af7c6a567fa70884877794613 commit af7b3c880a41a64af7c6a567fa70884877794613 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Tue Jun 21 19:38:00 2016 Auto-rebaseline for r401049 https://chromium.googlesource.com/chromium/src/+/c065affd6 BUG= 617033 TBR=wangxianzhu@chromium.org Review URL: https://codereview.chromium.org/2082783004 . Cr-Commit-Position: refs/heads/master@{#401080} [modify] https://crrev.com/af7b3c880a41a64af7c6a567fa70884877794613/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/098645c6ee78757f03819207645ff151b8edf01d/third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla/bugs/bug30692-expected.png [delete] https://crrev.com/098645c6ee78757f03819207645ff151b8edf01d/third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla/bugs/bug30692-expected.txt |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by vabr@chromium.org
, Jun 3 2016