New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 617033 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

tables/mozilla/bugs/bug30692.html failed on Mac 10.11 after auto-rebaseline

Project Member Reported by vabr@chromium.org, Jun 3 2016

Issue description

Build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/3397

Failure (full log attached):
22:32:36.892 9417 "/b/build/slave/WebKit_Mac10_11__retina_/build/src/out/Release/image_diff --diff /tmp/tmp2WmGQV/actual.png /tmp/tmp2WmGQV/expected.png /tmp/tmp2WmGQV/diff.png" took 0.20s
22:32:37.113 9417 "ruby -I /b/build/slave/WebKit_Mac10_11__retina_/build/src/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch /b/build/slave/WebKit_Mac10_11__retina_/build/src/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch/prettify.rb /b/build/slave/WebKit_Mac10_11__retina_/build/layout-test-results/tables/mozilla/bugs/ bug30692 -diff.txt" took 0.17s
22:32:37.232 9390 [40388/41088] tables/mozilla/bugs/ bug30692 .html failed unexpectedly (text diff, image diff)
22:32:37.230 9417 worker/2 tables/mozilla/bugs/ bug30692 .html failed:
22:32:37.231 9417 worker/2  text diff
22:32:37.231 9417 worker/2  image diff
 
Log File contents.html
7.8 MB View Download

Comment 1 by vabr@chromium.org, Jun 3 2016

This is likely due to the auto-rebaseline: https://codereview.chromium.org/2036063002

Comment 2 by vabr@chromium.org, Jun 3 2016

Actually, maybe it is because the rebaseline did not include Mac 10.11 (it did change Mac 10.10, for example).

Comment 3 by vabr@chromium.org, Jun 3 2016

Ad #2 and #1 -- I don't know, really, not sure how the test expectations work there. Will just disable the test on Mac for now and move on with sheriffing.

Comment 4 by vabr@chromium.org, Jun 3 2016

Owner: wkorman@chromium.org
Status: Assigned (was: Untriaged)
I've been told on IRC that wkorman is a good contact in case this is indeed related to the auto-rebaseline.

wkorman@ -- could you please have a look? If you don't think this is auto-rebaseline-related, then please just say so, unassign from yourself and mark as Untriaged.

Thanks!
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98bb6267e7954dde9082785b792bdcf815d51c30

commit 98bb6267e7954dde9082785b792bdcf815d51c30
Author: vabr <vabr@chromium.org>
Date: Fri Jun 03 11:25:40 2016

Disable tables/mozilla/bugs/ bug30692 .html on Mac10.11

The test fails on Mac 10.11 after auto-rebaseline, see the bug for more info.

TBR=glebl@chromium.org
BUG= 617033 

Added NOTRY, because there is a lot of other breakage in Blink currently.
NOTRY=true

Review-Url: https://codereview.chromium.org/2031243002
Cr-Commit-Position: refs/heads/master@{#397682}

[modify] https://crrev.com/98bb6267e7954dde9082785b792bdcf815d51c30/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by vabr@chromium.org, Jun 3 2016

The disabling did not work, apparently: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/3410. Trying to figure out why.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3831cba2aad23496e608e5fe39b51cf20d1371ac

commit 3831cba2aad23496e608e5fe39b51cf20d1371ac
Author: vabr <vabr@chromium.org>
Date: Fri Jun 03 13:37:46 2016

Fix incorrect test specification

Apparently, the Retina specifier was missing when disabling
tables/mozilla/bugs/ bug30692 .html on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/.

NOTRY=true

TBR=mkwst@chromium.org
BUG= 617033 

Review-Url: https://codereview.chromium.org/2032093003
Cr-Commit-Position: refs/heads/master@{#397699}

[modify] https://crrev.com/3831cba2aad23496e608e5fe39b51cf20d1371ac/third_party/WebKit/LayoutTests/TestExpectations

Components: -Blink Blink>Layout>Table

Comment 9 by e...@chromium.org, Jun 6 2016

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
This doesn't look fixed -- the TestExpectations line is still there.

Comment 11 by e...@chromium.org, Jun 6 2016

Labels: -Pri-1 Pri-2
Oh, incorrect grepping on my part. Never mind :p 
Status: Fixed (was: Assigned)

Sign in to add a comment