New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616995 link

Starred by 6 users

Issue metadata

Status: Archived
Owner: ----
Closed: Nov 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug

Blocked on:
issue 622553
issue 642370

Blocking:
issue 603651



Sign in to add a comment

Scroll offset animation duration should account for main thread jank

Project Member Reported by ymalik@chromium.org, Jun 3 2016

Issue description

There is some time delay between the user initiating the scroll and the scroll animation actually starting. We want to take this delay into account when determining the duration of the animation so that it feels more snappy on janky pages.
 
Components: Blink>Scroll

Comment 2 by skobes@chromium.org, Jun 23 2016

Blockedon: 622553

Comment 3 by ymalik@chromium.org, Aug 30 2016

Blockedon: 642370
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddfc352c8851b8eaee293446048316c84cbabc7d

commit ddfc352c8851b8eaee293446048316c84cbabc7d
Author: ymalik <ymalik@chromium.org>
Date: Mon Sep 05 18:40:37 2016

Take MT jank into account when animating the scroll offset on CC

This CL calculates the jank by subtracting base::TimeTicks::Now from
the event platform time when GestureScrollUpdate is called.

BUG= 616995 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2040543002
Cr-Commit-Position: refs/heads/master@{#416561}

[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/animation/animation_host.cc
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/animation/animation_host.h
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/animation/animation_host_unittest.cc
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/animation/scroll_offset_animation_curve.cc
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/animation/scroll_offset_animation_curve.h
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/animation/scroll_offset_animation_curve_unittest.cc
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/animation/scroll_offset_animations_impl.cc
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/animation/scroll_offset_animations_impl.h
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/input/input_handler.h
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/layers/viewport.cc
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/layers/viewport.h
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/cc/trees/layer_tree_host_unittest_animation.cc
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/ddfc352c8851b8eaee293446048316c84cbabc7d/ui/events/blink/input_handler_proxy_unittest.cc

Status: Fixed (was: Started)
Isn't there another side of this for scrolls animated on the main thread?
Status: Available (was: Fixed)
Oops you're right. Re-opening.

Comment 8 by ymalik@chromium.org, Nov 15 2016

Blocking: 603651

Comment 9 by ymalik@chromium.org, Nov 16 2016

Cc: ymalik@chromium.org
Owner: skobes@chromium.org
My patch in comment 4 does this for the impl thread. To do this on the main thread, we need to plumb event information to the ScrollAnimator and take that into account when creating / updating the animation curve.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 17 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: ----
Status: Available (was: Untriaged)
Project Member

Comment 12 by sheriffbot@chromium.org, Nov 19

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: bokan@chromium.org
Status: Archived (was: Untriaged)
I believe this will be addressed with scroll unification work folks are working on. bokan@ can you confirm this? Is there a bug we can mark this as duplicate of that?
That's my expectation, yes, since the animation would always be started from the compositor thread.

Sign in to add a comment