New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 616977 link

Starred by 2 users
Status: Verified
Owner:
█ bryanlew@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
█ dshi@chromium.org
█ jrbarnette@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Verify on adb_host gets stuck for an hour for a bad host.

Project Member Reported by sbasi@chromium.org, Jun 3 2016 
The device is down, verify should run quickly so repair can kick off...

6/02 16:53:08.026 DEBUG|          adb_host:0383| Command: adb -s edisond493c34d logcat -v time -d > "/var/tmp/autoserv-iyY9dO/logcat.log"
06/02 16:53:08.026 DEBUG|          ssh_host:0180| Running (ssh) 'adb -s edisond493c34d logcat -v time -d > "/var/tmp/autoserv-iyY9dO/logcat.log"'
06/02 16:53:08.356 ERROR|        base_utils:0278| [stderr] - waiting for device -
06/02 17:53:08.233 WARNI|        base_utils:0910| run process timeout (3600) fired on: /usr/bin/ssh -a -x  -o ControlPath=/tmp/_autotmp_0dykxBssh-master/socket -o StrictHostKeyChecking=no -o UserKnownHostsFile=/tmp/tmpSzkgsk -o BatchMode=yes -o ConnectTimeout=30 -o ServerAliveInterval=300 -l root -p 22 brillolabstation3-legorack-edisond493c34d " if type \"logger\" > /dev/null 2>&1; then logger -tag \"autotest\" \"server[stack::adb_run|_device_run|run] -> ssh_run(adb -s edisond493c34d logcat -v time -d > \\\"/var/tmp/autoserv-iyY9dO/logcat.log\\\")\";fi; adb -s edisond493c34d logcat -v time -d > \"/var/tmp/autoserv-iyY9dO/logcat.log\""

Looks like the logcat code. Please fix ASAP.

Comment 1 by bryanlew@chromium.org, Jun 3 2016 

Are there instructions for how to reproduce this so I can look into it?

Comment 2 by sbasi@chromium.org, Jun 3 2016 

Hmm, maybe try running a test against a serial that doesn't exist?

Pretty sure this is a 1 line change somewhere.

Comment 3 by sbasi@chromium.org, Jun 3 2016 

Try changing the timeout variable on line 722

06/02 17:53:09.240 ERROR|         traceback:0013| Traceback (most recent call last):
06/02 17:53:09.241 ERROR|         traceback:0013|   File "/usr/local/autotest/server/autoserv", line 551, in run_autoserv
06/02 17:53:09.241 ERROR|         traceback:0013|     host.close()
06/02 17:53:09.242 ERROR|         traceback:0013|   File "/usr/local/autotest/server/hosts/adb_host.py", line 747, in close
06/02 17:53:09.242 ERROR|         traceback:0013|     return super(ADBHost, self).close()
06/02 17:53:09.243 ERROR|         traceback:0013|   File "/usr/local/autotest/server/hosts/abstract_ssh.py", line 683, in close
06/02 17:53:09.243 ERROR|         traceback:0013|     super(AbstractSSHHost, self).close()
06/02 17:53:09.243 ERROR|         traceback:0013|   File "/usr/local/autotest/server/hosts/remote.py", line 48, in close
06/02 17:53:09.244 ERROR|         traceback:0013|     self.stop_loggers()
06/02 17:53:09.244 ERROR|         traceback:0013|   File "/usr/local/autotest/server/hosts/adb_host.py", line 722, in stop_loggers
06/02 17:53:09.245 ERROR|         traceback:0013|     self.adb_run('logcat -v time -d > "%s"' % (teststation_filename))
06/02 17:53:09.245 ERROR|         traceback:0013|   File "/usr/local/autotest/server/hosts/adb_host.py", line 301, in adb_run
06/02 17:53:09.246 ERROR|         traceback:0013|     return self._device_run(ADB_CMD, command, **kwargs)
06/02 17:53:09.246 ERROR|         traceback:0013|   File "/usr/local/autotest/server/hosts/adb_host.py", line 389, in _device_run
06/02 17:53:09.246 ERROR|         traceback:0013|     connect_timeout=connect_timeout, args=args)
06/02 17:53:09.247 ERROR|         traceback:0013|   File "/usr/local/autotest/server/hosts/teststation_host.py", line 130, in run
06/02 17:53:09.248 ERROR|         traceback:0013|     return super(TestStationHost, self).run(cmd, *args, **dargs)
06/02 17:53:09.248 ERROR|         traceback:0013|   File "/usr/local/autotest/server/hosts/ssh_host.py", line 195, in run
06/02 17:53:09.249 ERROR|         traceback:0013|     raise error.AutoservRunError(timeout_message, cmderr.args[1])

Comment 4 by bryanlew@chromium.org, Jun 3 2016

Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ea4a06d29336d6a2b5cae2509f460904176a3887

commit ea4a06d29336d6a2b5cae2509f460904176a3887
Author: Bryan Lewandowski <bryanlew@google.com>
Date: Fri Jun 03 18:25:54 2016

Add timeouts to run calls.

Logcat collection and time sync calls might fail.  Add explicit timeouts
so that the default 3600 second timeout is not triggered.  This case
happens when a device is or becomes unavailable.

BUG= chromium:616977 
TEST=test_droid against local board
TEST=test_droid against remote test station's board

Change-Id: Iacea4d8d973337f3dd121ba6f64d3e889f38fa87
Reviewed-on: https://chromium-review.googlesource.com/349631
Commit-Ready: Simran Basi <sbasi@chromium.org>
Tested-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>

[modify] https://crrev.com/ea4a06d29336d6a2b5cae2509f460904176a3887/server/hosts/adb_host.py

Comment 6 by bryanlew@chromium.org, Jun 27 2016

Status: Verified (was: Started)
Resolved, closed.
►

Sign in to add a comment