New issue
Advanced search Search tips

Issue 616960 link

Starred by 0 users

Issue metadata

Status: Verified
Owner: ----
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
OKR



Sign in to add a comment

Update policy_* tests to use class methods.

Project Member Reported by scunning...@chromium.org, Jun 2 2016

Issue description

Many of the early policy_* tests had their own internal methods for cleanup, run_once, run_test_case, and _get_policy_data_for_case. These methods are now available in the class. Update the tests to use the class methods.

policy_CookiesAllowedForUrls
policy_CookiesBlockedForUrls
policy_EditBookmarksEnabled
policy_ForceGoogleSafeSearch
policy_ForceYouTubeSafetyMode
policy_ImagesAllowedForUrls
policy_ImagesBlockedForUrls
policy_JavaScriptAllowedForUrls
policy_JavaScriptBlockedForUrls
policy_ManagedBookmarks
policy_PopupsAllowedForUrls
policy_PopupsBlockedForUrls
policy_ProxySettings
policy_RestoreOnStartupURLs
policy_URLBlacklist
policy_URLWhitelist
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f5ac2571588478039a79b5dbc8723fe9e9de1717

commit f5ac2571588478039a79b5dbc8723fe9e9de1717
Author: Scott Cunningham <scunningham@chromium.org>
Date: Thu Jun 02 23:50:28 2016

Update early policy_* tests to use class methods.

Many of the early policy_* tests had their own internal methods for
cleanup, run_once, run_test_case, and _get_policy_data_for_case.
These methods are now available in the class. Update the tests to
use the class methods.

policy_CookiesAllowedForUrls
policy_CookiesBlockedForUrls
policy_EditBookmarksEnabled
policy_ImagesAllowedForUrls
policy_ImagesBlockedForUrls
policy_JavaScriptAllowedForUrls
policy_JavaScriptBlockedForUrls
policy_ManagedBookmarks
policy_PopupsAllowedForUrls
policy_PopupsBlockedForUrls
policy_ProxySettings
policy_RestoreOnStartupURLs
policy_URLBlacklist
policy_URLWhitelist

BUG= chromium:616960 
TEST=Run test_that <IP> <test> for each policy_* test.

Change-Id: I98aa0727a6594891def20444dfae694974e8df64
Reviewed-on: https://chromium-review.googlesource.com/349671
Commit-Ready: Scott Cunningham <scunningham@chromium.org>
Tested-by: Scott Cunningham <scunningham@chromium.org>
Reviewed-by: Scott Cunningham <scunningham@chromium.org>
Reviewed-by: Krishna Gavini <krishnargv@chromium.org>

[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_CookiesAllowedForUrls/policy_CookiesAllowedForUrls.py
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_JavaScriptBlockedForUrls/control
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_PopupsBlockedForUrls/policy_PopupsBlockedForUrls.py
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_ProxySettings/policy_ProxySettings.py
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_ImagesAllowedForUrls/policy_ImagesAllowedForUrls.py
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_JavaScriptAllowedForUrls/policy_JavaScriptAllowedForUrls.py
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_URLBlacklist/control
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_JavaScriptAllowedForUrls/control
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_PopupsAllowedForUrls/control
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_URLBlacklist/policy_URLBlacklist.py
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_CookiesBlockedForUrls/policy_CookiesBlockedForUrls.py
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_EditBookmarksEnabled/policy_EditBookmarksEnabled.py
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_RestoreOnStartupURLs/policy_RestoreOnStartupURLs.py
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_ImagesBlockedForUrls/policy_ImagesBlockedForUrls.py
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_URLWhitelist/policy_URLWhitelist.py
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_PopupsAllowedForUrls/policy_PopupsAllowedForUrls.py
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_URLWhitelist/control
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_ManagedBookmarks/policy_ManagedBookmarks.py
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_PopupsBlockedForUrls/control
[modify] https://crrev.com/f5ac2571588478039a79b5dbc8723fe9e9de1717/client/site_tests/policy_JavaScriptBlockedForUrls/policy_JavaScriptBlockedForUrls.py

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Bulk verified
Owner: ----

Sign in to add a comment