New issue
Advanced search Search tips

Issue 616958 link

Starred by 3 users
Status: Available
Owner: ----
Cc:
ricea@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

WebSocketBrowserTest.SendCloseFrameWhenTabIsClosed is failing flakily in Win10 Tests x64

Project Member Reported by holte@chromium.org, Jun 2 2016 
Revision range:
chromium 397485 : 397500

Failing builders:
Win10 Tests x64: https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64

e.g.

https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/1512

WebSocketBrowserTest.SendCloseFrameWhenTabIsClosed (run #1):
[ RUN      ] WebSocketBrowserTest.SendCloseFrameWhenTabIsClosed
Trying to start websocket server on ws://127.0.0.1:0...
WebSocket server started on ws://127.0.0.1:52595...
sending server_data: {"host": "127.0.0.1", "port": 52595} (36 bytes)
vm794-m4.golo.chromium.org - code 404, message File not found
Exception in processing request from: ('127.0.0.1', 52604)
Traceback (most recent call last):
  File "e:\depot_tools\python276_bin\lib\SocketServer.py", line 593, in process_request_thread
    self.finish_request(request, client_address)
  File "e:\depot_tools\python276_bin\lib\SocketServer.py", line 334, in finish_request
    self.RequestHandlerClass(request, client_address, self)
    self, request, client_address, server)
  File "e:\depot_tools\python276_bin\lib\SocketServer.py", line 651, in __init__
    self.finish()
  File "e:\depot_tools\python276_bin\lib\SocketServer.py", line 710, in finish
    self.wfile.close()
  File "e:\depot_tools\python276_bin\lib\socket.py", line 279, in close
    self.flush()
  File "e:\depot_tools\python276_bin\lib\socket.py", line 303, in flush
    self._sock.sendall(view[write_offset:write_offset+buffer_size])
error: [Errno 10053] An established connection was aborted by the software in your host machine
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0d71a26bbb231efc212cf23081450a50344831a

commit a0d71a26bbb231efc212cf23081450a50344831a
Author: holte <holte@chromium.org>
Date: Fri Jun 03 02:44:56 2016

Disable flaky SendCloseFrameWhenTabIsClosed

TBR=rsleevi

BUG=616958

Review-Url: https://codereview.chromium.org/2038713002
Cr-Commit-Position: refs/heads/master@{#397599}

[modify] https://crrev.com/a0d71a26bbb231efc212cf23081450a50344831a/chrome/browser/net/websocket_browsertest.cc

Comment 2 by holte@chromium.org, Jun 3 2016

Labels: Tests-Disabled

Comment 3 by jbroman@chromium.org, Jun 6 2016

Cc: ricea@chromium.org
Components: Blink>Network>WebSockets
Owner: yhirano@chromium.org
Status: Assigned (was: Available)
Adding component and owner so this doesn't get forgotten.

Comment 4 by ricea@chromium.org, Jun 7 2016 

The exception may be unrelated to the actual cause of the error. The counter used by the test is incremented before attempting to close the socket, and IIRC pywebsocket only abandons one connection on exceptions, so subsequent connections should still work.

Comment 5 by dpranke@chromium.org, Jan 22 2018

Labels: Test-Disabled
Adding Test-Disabled label, the Tests>Disabled component is going away.

Comment 6 by yhirano@chromium.org, Jul 2

Owner: ----
Status: Available (was: Assigned)
Releasing the bug...

Comment 7 by ricea@chromium.org, Jul 2

Status: Started (was: Available)
I'm going to take this briefly while I see if I can reproduce locally.

Comment 8 by ricea@chromium.org, Jul 2

Owner: ricea@chromium.org

Comment 9 by ricea@chromium.org, Jul 2

Labels: Pri-3 Type-Bug

Comment 10 by ricea@chromium.org, Jul 3

Owner: ----
Status: Available (was: Started)
I can't reproduce locally. There may be something about the bot environments that tickles it. Or it may actually have got better for some reason.

Comment 11 by ricea@chromium.org, Jul 3 

I ran the test 10,000 times on my Windows 10 workstation. No failures.
►

Sign in to add a comment