Precache GCM task should be scheduled even if current network is cellular |
||||||
Issue descriptionupdateEnabledSync() calls canPrefetchAndPrerender() which returns false if current network type is cellular (though its enabled in preference). When user opens chrome in cellular, this causes the periodic precache task to be cancelled. The task gets scheduled again only when user opens chrome in WiFi.
,
Jun 3 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fd4cfeadfcdb8b2c29d4d747fe8106200b8855b commit 2fd4cfeadfcdb8b2c29d4d747fe8106200b8855b Author: rajendrant <rajendrant@chromium.org> Date: Mon Jun 06 20:54:37 2016 Do not cancel precache periodic GCM task if current network is non-WiFi Only the network prediction enabled preference should be used to schedule or cancel periodic GCM task. The GCM task itself will run only when suitable for precaching. BUG= 616956 Review-Url: https://codereview.chromium.org/2037913002 Cr-Commit-Position: refs/heads/master@{#398119} [modify] https://crrev.com/2fd4cfeadfcdb8b2c29d4d747fe8106200b8855b/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
,
Jun 23 2016
Is this fixed?
,
Jun 28 2016
,
Jun 28 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/102c583b8750c57f91285db22de30ccf5aaa842f commit 102c583b8750c57f91285db22de30ccf5aaa842f Author: Tarun Bansal <tbansal@google.com> Date: Thu Jun 30 20:17:58 2016 Do not cancel precache periodic GCM task if current network is non-WiFi Only the network prediction enabled preference should be used to schedule or cancel periodic GCM task. The GCM task itself will run only when suitable for precaching. BUG= 616956 Review-Url: https://codereview.chromium.org/2037913002 Cr-Commit-Position: refs/heads/master@{#398119} (cherry picked from commit 2fd4cfeadfcdb8b2c29d4d747fe8106200b8855b) Review URL: https://codereview.chromium.org/2114763002 . Cr-Commit-Position: refs/branch-heads/2743@{#553} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/102c583b8750c57f91285db22de30ccf5aaa842f/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
,
Jun 30 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rajendrant@chromium.org
, Jun 2 2016