Show panel for ARIA attributes separate from computed properties.
Initial attempt
Swapped order of Computed Properties and ARIA Attributes, made Computed Properties have a light grey background.
Current working version, showing before, during, and after editing a single attribute's value.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9d64446c281cd18bb374ac0370bf9fb4cf5cb32 commit c9d64446c281cd18bb374ac0370bf9fb4cf5cb32 Author: aboxhall <aboxhall@chromium.org> Date: Tue Jul 26 20:05:12 2016 Add ARIA panel to accessibility sidebar pane. Incomplete, but usable: - Can edit attribute values only. - Can not add extra attributes yet. - No autocomplete yet. - No validation yet. - No moving between attributes via keyboard yet. Minimal usable version to get started, will add missing features in follow-ups. BUG= 616950 Review-Url: https://codereview.chromium.org/2058323002 Cr-Commit-Position: refs/heads/master@{#407891} [add] https://crrev.com/c9d64446c281cd18bb374ac0370bf9fb4cf5cb32/third_party/WebKit/LayoutTests/inspector/elements/accessibility/accessibility-pane-test.js [add] https://crrev.com/c9d64446c281cd18bb374ac0370bf9fb4cf5cb32/third_party/WebKit/LayoutTests/inspector/elements/accessibility/edit-aria-attributes-expected.txt [add] https://crrev.com/c9d64446c281cd18bb374ac0370bf9fb4cf5cb32/third_party/WebKit/LayoutTests/inspector/elements/accessibility/edit-aria-attributes.html [modify] https://crrev.com/c9d64446c281cd18bb374ac0370bf9fb4cf5cb32/third_party/WebKit/Source/devtools/devtools.gypi [add] https://crrev.com/c9d64446c281cd18bb374ac0370bf9fb4cf5cb32/third_party/WebKit/Source/devtools/front_end/accessibility/ARIAAttributesView.js [modify] https://crrev.com/c9d64446c281cd18bb374ac0370bf9fb4cf5cb32/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js [modify] https://crrev.com/c9d64446c281cd18bb374ac0370bf9fb4cf5cb32/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js [modify] https://crrev.com/c9d64446c281cd18bb374ac0370bf9fb4cf5cb32/third_party/WebKit/Source/devtools/front_end/accessibility/accessibilityNode.css [modify] https://crrev.com/c9d64446c281cd18bb374ac0370bf9fb4cf5cb32/third_party/WebKit/Source/devtools/front_end/accessibility/module.json [modify] https://crrev.com/c9d64446c281cd18bb374ac0370bf9fb4cf5cb32/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js [modify] https://crrev.com/c9d64446c281cd18bb374ac0370bf9fb4cf5cb32/third_party/WebKit/Source/devtools/front_end/main/Main.js [modify] https://crrev.com/c9d64446c281cd18bb374ac0370bf9fb4cf5cb32/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
Screenshot of suggestions in action.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/515495b524fa67e475f0068809f42f814370866d commit 515495b524fa67e475f0068809f42f814370866d Author: aboxhall <aboxhall@chromium.org> Date: Tue Aug 30 04:27:50 2016 DevTools: Add autocomplete for ARIA. BUG= 616950 Review-Url: https://codereview.chromium.org/2200893003 Cr-Commit-Position: refs/heads/master@{#415094} [add] https://crrev.com/515495b524fa67e475f0068809f42f814370866d/third_party/WebKit/LayoutTests/inspector/elements/accessibility/autocomplete-attribute-expected.txt [add] https://crrev.com/515495b524fa67e475f0068809f42f814370866d/third_party/WebKit/LayoutTests/inspector/elements/accessibility/autocomplete-attribute.html [modify] https://crrev.com/515495b524fa67e475f0068809f42f814370866d/third_party/WebKit/Source/devtools/devtools.gypi [modify] https://crrev.com/515495b524fa67e475f0068809f42f814370866d/third_party/WebKit/Source/devtools/front_end/accessibility/ARIAAttributesView.js [add] https://crrev.com/515495b524fa67e475f0068809f42f814370866d/third_party/WebKit/Source/devtools/front_end/accessibility/ARIAConfig.js [add] https://crrev.com/515495b524fa67e475f0068809f42f814370866d/third_party/WebKit/Source/devtools/front_end/accessibility/ARIAMetadata.js [modify] https://crrev.com/515495b524fa67e475f0068809f42f814370866d/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js [modify] https://crrev.com/515495b524fa67e475f0068809f42f814370866d/third_party/WebKit/Source/devtools/front_end/accessibility/module.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3691cc167a224f40ff2909dcf51193b93b244c0d commit 3691cc167a224f40ff2909dcf51193b93b244c0d Author: aboxhall <aboxhall@chromium.org> Date: Thu Jun 29 12:51:15 2017 Show ARIA pane based on whether AXNode is DOM node, instead of based on whether it is ignored. BUG= 616950 Review-Url: https://codereview.chromium.org/2958173003 Cr-Commit-Position: refs/heads/master@{#483339} [modify] https://crrev.com/3691cc167a224f40ff2909dcf51193b93b244c0d/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11353980a216e622907d7077541128c4384c7850 commit 11353980a216e622907d7077541128c4384c7850 Author: aboxhall <aboxhall@chromium.org> Date: Mon Jul 10 02:24:25 2017 Bring ARIA config up to date with ARIA 1.1 (https://www.w3.org/TR/wai-aria-1.1) BUG= 616950 Review-Url: https://codereview.chromium.org/2962673003 Cr-Commit-Position: refs/heads/master@{#485174} [modify] https://crrev.com/11353980a216e622907d7077541128c4384c7850/third_party/WebKit/Source/devtools/front_end/accessibility/ARIAConfig.js
Closing this. There are more things that could be done with this panel, but it works ok for now.
Comment 1 by aboxhall@chromium.org
, Jun 2 2016110 KB
110 KB View Download