New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616949 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove variant_boards concept in release group config.

Project Member Reported by nxia@chromium.org, Jun 2 2016

Issue description

Confirmed we could have "chrome_sdk=True' in both follower_boards and variant_boards (see comments from 
https://bugs.chromium.org/p/chromium/issues/detail?id=616293#c4). so it's safe to get rid of variant_boards concept. It'll simplify the config file and the template file we're going to generate for the Golden Eye build config project. 

 

Comment 1 by nxia@chromium.org, Jun 2 2016

Summary: Remove variant_boards concept in release group config. (was: Remove variant_boards concept in release group group.)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/93dc1833aa3709db8a2656c5e77fae55fdc05782

commit 93dc1833aa3709db8a2656c5e77fae55fdc05782
Author: Ningning Xia <nxia@chromium.org>
Date: Thu Jun 02 23:11:47 2016

Remove variant_boards concept in leader/follower release configs.

As we don't need to explicitly set chrome_sdk to False for
variant_boards, there's no other difference between variant_board and
follower_board. Remove variant_boards concept in release configs.

BUG= chromium:616949 
TEST=run_tests

Change-Id: I0874ef78b692b37d539becac3af1628a7f0f28a5
Reviewed-on: https://chromium-review.googlesource.com/349277
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/93dc1833aa3709db8a2656c5e77fae55fdc05782/cbuildbot/config_dump.json
[modify] https://crrev.com/93dc1833aa3709db8a2656c5e77fae55fdc05782/cbuildbot/chromeos_config.py

Comment 3 by nxia@chromium.org, Jun 7 2016

Status: Fixed (was: Untriaged)
Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment