New issue
Advanced search Search tips

Issue 616948 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocking:
issue 587995



Sign in to add a comment

Add 'selected' boolean to 'ShippingOption'

Project Member Reported by rouslan@chromium.org, Jun 2 2016

Issue description

ShippingOption.selected is a new boolean member variable.

"This is set to true to indicate that this is the default selected ShippingOption in a sequence. User agents should display this option by default in the user interface."

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#idl-def-shippingoption
 
Labels: M-53
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d784539e0ff790124c695b9e704752fa8e0ce525

commit d784539e0ff790124c695b9e704752fa8e0ce525
Author: rouslan <rouslan@chromium.org>
Date: Wed Jun 08 03:25:33 2016

Add 'selected' boolean to 'ShippingOption'

ShippingOption.selected is a new boolean member variable used in
PaymentRequest.

"This is set to true to indicate that this is the default selected
ShippingOption in a sequence. User agents should display this option by
default in the user interface."

The website now has a more powerful way to specify the selected shipping
option. Prior to this patch, specifying a single shipping option would
result in that option being selected as the default. After this patch,
only the option that has "selected: true" is selected by default. This
makes calculation of totals more deterministic, as the web developer now
knows which shipping option is selected in UI.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#idl-def-shippingoption
https://github.com/w3c/browser-payment-api/commit/684603787c80d46d06b76f73b00a28a938e4b291

BUG= 616948 

Review-Url: https://codereview.chromium.org/2045833002
Cr-Commit-Position: refs/heads/master@{#398471}

[modify] https://crrev.com/d784539e0ff790124c695b9e704752fa8e0ce525/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/d784539e0ff790124c695b9e704752fa8e0ce525/chrome/test/data/android/payments/dynamic_shipping.js
[modify] https://crrev.com/d784539e0ff790124c695b9e704752fa8e0ce525/chrome/test/data/android/payments/free_shipping.js
[modify] https://crrev.com/d784539e0ff790124c695b9e704752fa8e0ce525/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/d784539e0ff790124c695b9e704752fa8e0ce525/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/d784539e0ff790124c695b9e704752fa8e0ce525/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/d784539e0ff790124c695b9e704752fa8e0ce525/third_party/WebKit/Source/modules/payments/ShippingOption.idl
[modify] https://crrev.com/d784539e0ff790124c695b9e704752fa8e0ce525/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment